Bug MicroDVD subtitles do not work properly
#1
Hey!

When I am using external MicroDVD subtitles (.sub extension), Kodi will not show about first 25 lines. I think first 1024b of subtitle file is missing. This is happening in Kodi 15.x and 16.
in 14.2 everything was okay!

So I compared about 15.1 and 14.2 source codes. And I thought that CDVDSubtitleStream::IsIncompatible() function is causing that problem, in file xbmc/cores/dvdplayer/DVDSubtitles/DVDSubtitleStream.cpp.

Then I removed:
Code:
if (URIUtils::HasExtension(strFile, ".sub") && IsIncompatible(pInputStream))
    {
      CLog::Log(LOGDEBUG, "%s: file %s seems to be a vob sub"
        "file without an idx file, skipping it", __FUNCTION__, pInputStream->GetFileName().c_str());
      delete pInputStream;
      return false;
    }

and then I built it. And now microdvd subtitles is working again perfectly!
Reply
#2
Can you post that MicroDVD subtitle file somewhere?
Reply
#3
This is happening in every microdvd subtitle file.

Example this one:
https://www.dropbox.com/s/lhpo94gbseoxb1...N.sub?dl=0

first shown line is:
Code:
{3098}{3160}On lääkityksen aika.


One work around is change extension from .sub to .srt
Reply
#4
You were right, this should fix it: https://github.com/xbmc/xbmc/pull/8023
Reply
#5
It works! Thank you! Smile
Reply

Logout Mark Read Team Forum Stats Members Help
MicroDVD subtitles do not work properly0