[MacGyver]

There are two changes that conflict with each other.

Post #36 (2015-09-01 removed window - VisualisationPresetList.xml) and Post #40 (2015-09-01 new infobool - Visualisation.HasPresets)

The first one says to remove the VisualisationPresetList.xml window and use a spin control instead, while the second one describes a conditional to better launch VisualisationPresetList.xml).

The overview doesn't mention its removal either.

removed windows

• MusicOverlay.xml (details)
  
• VideoOverlay.xml (details)
  
• DialogPVRGuideInfo.xml (details)
  
• DialogPVRRecordingInfo.xml (details)
  

Please clarify which is to be applied.

[braz]

The bool is for showing presets using the select dialog, not VisualisationPresetList.xml.

[MacGyver]

Then why does it call <onclick>ActivateWindow(122)</onclick> (VisualisationPresetList.xml)?

In the commit.

Presets are now called by a spinner in settings, not directly from the music OSD, I thought.

[phil65]

122 isnt VisualisationPresetList.xml anymore (it is removed now to save skinning work), it´s DialogSelect. You could still use Window.IsActive(122) as a condition inside DialogSelect though if you want a custom design. We do it the same in other areas (all PVR windows for example can either be the radio version or the TV version)

[MacGyver]

It's my version, 16 Alpha 2, 2015-08-31. It's late (3am) and clearly my brain has gone. I'll pull a nightly tomorrow and I bet it will work just fine.

Thanks guys.

[UPDATE]

The nightly worked fine.