2015-10-30, 15:14
Tolriq I didn't create the current musicbrainz tag processing, and I am not going to try and justify it, but I can understand what it does and why. I don't feel a rush to fix anything, but I do want to be sure that I have explained things clearly and accurately (for everyone) so here are some answers to your questions.
The artist table entry created for the first album gets updated when the second album is scanned to include an MBID for that artist. Only one artist is created, and this is how it has been for some time.
IMO this is a good thing. Without MBID Kodi has to assume that artists are uniquely identified by name only. Adding MBID whenever it can means that future additions can identify artists with more certainty using the MBID.
Yes you do get artists with the same name e.g. John Williams the classical guitarist and John Williams the conductor and film music composer (Star Wars etc.). Without MBID they are treated as one person. Use MBID for only one of them they are still treated as one person. To differentiate between them and separate their music you have to tag all tracks from all albums for both of them with the approriate artist MBID.
The tag pairs that go together (as an "artist credit") are
The song pair are processed first, creating artist table entry with "The Corrs", "acf6c776-d0f6-4239-b5a2-a45a613ffa52". The album pair then only matches on MBID and finds the artist.
There is a clear link in the tags between "The Corrs" and the MBID. Historically tagging for album artist is messy, ID3 doesn't have an ALBUMARTIST tag in the way that FLAC does so TPE2 (intended to be conductor) was used. Musicbrainz/Picard offer a MUSICBRAINZ ALBUM ARTIST tag as a replacement, but many use ALBUMARTIST
I don't agree. Mostly the update of artists without MBID by adding it when music for that artist with MBID tags is scanned is accurate, useful and painless. If the tags for the album had been consistent you would not have noticed any thing, and if you later used a scraper it would have accurately return info about the Corrs.
I think that the tag logic should be clearly documented, and we could benefit from a tagging guide for users too.
But I don't see the processing as incomplete, and normal tag data does not overwrite Musicbrainz tags. Tag accurately and Kodi delivers.
But none of this belongs in a discussion of my JSON fix
(2015-10-30, 12:45)Tolriq Wrote: So if I had first scanned an album with artist The Corrs without MBID then scanned a new one with the MBID what happens ? (Like 2 different albums)
2 artists are created ? (Was the case before) Or there's a name match and the MBID is added to the first artist ?
What about different artists with the same name ? (Rare but pretty sure this exists)
The artist table entry created for the first album gets updated when the second album is scanned to include an MBID for that artist. Only one artist is created, and this is how it has been for some time.
IMO this is a good thing. Without MBID Kodi has to assume that artists are uniquely identified by name only. Adding MBID whenever it can means that future additions can identify artists with more certainty using the MBID.
Yes you do get artists with the same name e.g. John Williams the classical guitarist and John Williams the conductor and film music composer (Star Wars etc.). Without MBID they are treated as one person. Use MBID for only one of them they are still treated as one person. To differentiate between them and separate their music you have to tag all tracks from all albums for both of them with the approriate artist MBID.
Quote:About artist again :
MUSICBRAINZ ARTIST ID = "acf6c776-d0f6-4239-b5a2-a45a613ffa52"
MUSICBRAINZ ALBUM ARTIST = "he Corrs"
So why does Kodi creates the artist with The Corrs and set the artist id from MBID?
IMO this : "Song processed first and song.strArtists = "The Corrs", and entry in the artist table is created from the artist tags with artist.strArtist = "The Corrs" and artist.MBID = "acf6c...". " is not logical when you say that MB have presidence.
In that case all MB tags should have presidence and not a mix with the normal tag for name and the MBID for the id as this leads to the mix.
Nowhere in the TAGS there's a link between The Corrs and the MBID.
The tag pairs that go together (as an "artist credit") are
Code:
[ARTIST, MUSICBRAINZ ARTIST ID] and
[MUSICBRAINZ ALBUM ARTIST (or ALBUMARTIST), MUSICBRAINZ ALBUM ARTIST ID]
There is a clear link in the tags between "The Corrs" and the MBID. Historically tagging for album artist is messy, ID3 doesn't have an ALBUMARTIST tag in the way that FLAC does so TPE2 (intended to be conductor) was used. Musicbrainz/Picard offer a MUSICBRAINZ ALBUM ARTIST tag as a replacement, but many use ALBUMARTIST
Quote:My point is that ok the files are messed up, but Kodi should have created 2 albums and 2 artists and use all MB data for one and none for the other.
I don't agree. Mostly the update of artists without MBID by adding it when music for that artist with MBID tags is scanned is accurate, useful and painless. If the tags for the album had been consistent you would not have noticed any thing, and if you later used a scraper it would have accurately return info about the Corrs.
Quote:Current mix is incomplete and it's hard for users to understand what TAG is used when, there's no point to have perfect MB data if an invalid normal TAG value can overwrite those.
Should be either MB > All or All > MB.
I think that the tag logic should be clearly documented, and we could benefit from a tagging guide for users too.
But I don't see the processing as incomplete, and normal tag data does not overwrite Musicbrainz tags. Tag accurately and Kodi delivers.
But none of this belongs in a discussion of my JSON fix