[HEADS UP] PR to change include syntax.
#1
Feel free to discuss or give your +1 / -1, either here or on GitHub.
https://github.com/xbmc/xbmc/pull/9114
Donate: https://kodi.tv/contribute/donate (foundation), 146Gr48FqHM7TPB9q33HHv6uWpgQqdz1yk (BTC personal)
Estuary: Kodis new default skin - ExtendedInfo Script - KodiDevKit
Reply
#2
+1
Reply
#3
+1
If required a FULL debug log can now be submitted from the skin in settings->skin settings->support. Or follow instructions here if you can't access skin settings.

FAQ's located at :- http://kodi.wiki/view/Add-on:AppTV
Reply
#4
I take it this is for all includes, not just ones that take params?

scott s.
.
maintainer of skin  Aeon MQ5 mods for post-Gotham Kodi releases:
Matrix see: Aeon MQ5 Mod Matrix release thread
Nexus see: Aeon MQ5 Mod Nexus release thread
Aeon MQ 5 skin and addon repo 11.1.0
Reply
#5
+1 for changing that tag.

But I would call it <include param="%s">.
Defintion is such a long word Wink

Edit:
And it seems that it's predestined for making a typo..
Main: Lancool II Mesh  - Ryzen 9 5900x - MSI x570 Unify - Zotac RTX 3080 AMP HOLO - 32GB Trident Z Neo 3600 CL16 -  EVO 960 M.2 250GB / EVO 940 250GB / MX100 512GB /  Crucial P1 2TB / WD Blue 3D Nand 2TB 
Sound: Saxx AS30 DSP - Beyer Dynamic Custom One Pro 
TV: Nvidia Shield 2019 Pro- Adalight 114x LEDs - Sony 65XG9505 - Kodi / Emby - Yamaha RX-V683 - Heco Victa 700/101/251a + Dynavoice Magic FX-4
Server: i3 Skylake - 8GB - OMV4 - 22TB Storage
Reply
#6
Hmm, I don't get it.
You mean :

definition <include definition="MyInclude">
call <include name="MyInclude">

or both <include definition="MyInclude"> ?

Is is intended to separate calls end defs ?

EDIT : Just my 2 cents but until I get if this is typo only (sublimetext ?) I'm fine with the name="" tag but that's right it maybe needs to clear if it's call or def. Since vars work also with the same tag as def, it's somehow confusing me changing it to definition="" (also with <definition> in Advanced includes). So about vars and calls, getting an info is mostly done using $TYPE[] and for consistency what about :

definition <include name="MyInclude">
call <include name="$INCLUDE[MyInclude]"> or <include>$INCLUDE[MyInclude]</include> ?

Anyway, I will adapt to the changes Wink
[Skin] KOver - V1.1.0 Stable (Repo version)
[WIP] ReKOver - Skinning tool project

If I've been helpful or you like my work, hit "THANK USER" button ;) ...
Reply
#7
As Phil just pointed out on Slack changing the definition isn't consistent with other definitions ie constants, vars, colors, etc so I suggest we only change calling the include to something other than 'name'. eg call?

Stays the -
PHP Code:
<includes>
    <include 
name="foo">
        <
control type="bar" id="$PARAM[ID]">
        ...
        </
control>
    </include>
</
includes

Changes -
PHP Code:
<include call="foo">
    <
param name="bar" value="1" />
    ...
</include> 
Reply
#8
@Hitcher :

Definitely sounds better to me. +1
[Skin] KOver - V1.1.0 Stable (Repo version)
[WIP] ReKOver - Skinning tool project

If I've been helpful or you like my work, hit "THANK USER" button ;) ...
Reply
#9
+1 call is great
Main: Lancool II Mesh  - Ryzen 9 5900x - MSI x570 Unify - Zotac RTX 3080 AMP HOLO - 32GB Trident Z Neo 3600 CL16 -  EVO 960 M.2 250GB / EVO 940 250GB / MX100 512GB /  Crucial P1 2TB / WD Blue 3D Nand 2TB 
Sound: Saxx AS30 DSP - Beyer Dynamic Custom One Pro 
TV: Nvidia Shield 2019 Pro- Adalight 114x LEDs - Sony 65XG9505 - Kodi / Emby - Yamaha RX-V683 - Heco Victa 700/101/251a + Dynavoice Magic FX-4
Server: i3 Skylake - 8GB - OMV4 - 22TB Storage
Reply
#10
(2016-02-12, 10:45)Hitcher Wrote:
PHP Code:
<include call="foo">
    <
param name="bar" value="1" />
    ...
</include> 

I really like this solution! But I think that 'call' suggests that the skin file is actually a program, so I would prefer 'import'. I think this reflects the static nature of the skin a little better. Blush

PHP Code:
<include import="foo">
    <
param name="bar" value="1" />
    ...
</include> 
Reply
#11
no real preference, but i'll trow in my suggestion anyway :-)

PHP Code:
<include id="foo">
    <
param name="bar" value="1" />
    ...
</include> 
Do not PM or e-mail Team-Kodi members directly asking for support.
Always read the Forum rules, Kodi online-manual, FAQ, Help and Search the forum before posting.
Reply
#12
(2016-02-12, 16:09)ronie Wrote: no real preference, but i'll trow in my suggestion anyway :-)

PHP Code:
<include id="foo">
    <
param name="bar" value="1" />
    ...
</include> 

This makes the most sense to me...
Reply
#13
I would also be fine with "include id". Keep in mind though that changing the syntax of the references is definitely more work for skinners than changing the syntax of the include definitions.

Should I prepare that change then when I find some time? Any objections?

Sorry to BobCratchett for being a bit to quick with pushing for changes.
Donate: https://kodi.tv/contribute/donate (foundation), 146Gr48FqHM7TPB9q33HHv6uWpgQqdz1yk (BTC personal)
Estuary: Kodis new default skin - ExtendedInfo Script - KodiDevKit
Reply
#14
(2016-02-12, 16:59)phil65 Wrote: I would also be fine with "include id". Keep in mind though that changing the syntax of the references is definitely more work for skinners than changing the syntax of the include definitions.

Should I prepare that change then when I find some time? Any objections?

Sorry to BobCratchett for being a bit to quick with pushing for changes.

The endresult will be

<include definition="blabla">
</include>

and

<include id="blabla">
<param name="blah" value="blah"/>
</include>

right ?
Reply
#15
(2016-02-12, 16:09)ronie Wrote: no real preference, but i'll trow in my suggestion anyway :-)

PHP Code:
<include id="foo">
    <
param name="bar" value="1" />
    ...
</include> 

I dont have a preference either, but id is only used as integer up till now afaik. Maybe new skinners will think you can use alphanumerics for the other id attributes too if we use this?
Reply



Logout Mark Read Team Forum Stats Members Help
[HEADS UP] PR to change include syntax.0
This forum uses Lukasz Tkacz MyBB addons.