API - deprecated features v18

  Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
MatthewLundberg Offline
Member
Posts: 61
Joined: Apr 2017
Reputation: 0
Post: #31
Does this mean that the client function GetLiveStreamURL is also going away?

It sounds like the PVR is now required to handle the network IO for reading remote streams, as this could be previously specified by strStreamURL.

Assuming that this is correct, are there calls into Kodi that I can make to handle the networking? The HDHomeRun PVR is now using strStreamURl to specify the stream, which is opened by the *DVD* reader.
(This post was last modified: 2017-06-06 02:40 by MatthewLundberg.)
find quote
MatthewLundberg Offline
Member
Posts: 61
Joined: Apr 2017
Reputation: 0
Post: #32
Partially answering my own question, it looks like I can create an object of type CDVDInputStreamFFmpeg, as in the function CDVDFactoryInputStream::CreateInputStream. Once I figure out how to build the CFileItem that it needs...

Can I call these functions from within the PVR code?
(This post was last modified: 2017-06-06 06:43 by MatthewLundberg.)
find quote
ksooo Offline
Team-Kodi Member
Posts: 855
Joined: Jan 2015
Reputation: 43
Location: Hamburg, Germany
Post: #33
(2017-06-06 06:10)MatthewLundberg Wrote:  Partially answering my own question, it looks like I can create an object of type CDVDInputStreamFFmpeg, as in the function CDVDFactoryInputStream::CreateInputStream. Once I figure out how to build the CFileItem that it needs...

Can I call these functions from within the PVR code?


Sorry, no. These classes/functions are not part of the official Kodi API, thus can change incompatible at any (!) random point in time, breaking your add-on.

You may want to take a look at kodi-platform, which provides stable basic functionality that can be used safely in kodi binary add-ons. => https://github.com/Pulse-Eight/platform
find quote
MatthewLundberg Offline
Member
Posts: 61
Joined: Apr 2017
Reputation: 0
Post: #34
Thanks, ksooo, I am looking there. It appears to have everything that I will need.

I did notice though, that the P8PLATFORM::PreventCopy class does not allow moves. Is this code being actively maintained?
find quote
ksooo Offline
Team-Kodi Member
Posts: 855
Joined: Jan 2015
Reputation: 43
Location: Hamburg, Germany
Post: #35
As far as I know, yes.

@opdenkamp might have more insights.
find quote
MatthewLundberg Offline
Member
Posts: 61
Joined: Apr 2017
Reputation: 0
Post: #36
Confirmed, it is easy to support ReadLiveStream, and I have done so in yet-to-be-pushed code. No more strStreamURL or ThisIsAHack calling GetLiveStreamURL. And maybe it's my imagination, but channel changes seem to be faster and smoother.

I do have a question about this though. In this thread, picture-in-picture is mentioned. However, the function for ReadLiveStream does not indicate a channel or any other handle to allow the PVR to supply multiple streams. Is picture-in-picture only supported for two instances of the PVR, or for the PVR and another stream (say, from a file)?
(This post was last modified: 2017-06-07 05:23 by MatthewLundberg.)
find quote
ksooo Offline
Team-Kodi Member
Posts: 855
Joined: Jan 2015
Reputation: 43
Location: Hamburg, Germany
Post: #37
(2017-06-07 05:20)MatthewLundberg Wrote:  Confirmed, it is easy to support ReadLiveStream, and I have done so in yet-to-be-pushed code. No more strStreamURL or ThisIsAHack calling GetLiveStreamURL. And maybe it's my imagination, but channel changes seem to be faster and smoother.

I do have a question about this though. In this thread, picture-in-picture is mentioned. However, the function for ReadLiveStream does not indicate a channel or any other handle to allow the PVR to supply multiple streams. Is picture-in-picture only supported for two instances of the PVR, or for the PVR and another stream (say, from a file)?


PIP is currently not supported at all. Larger changes in Kodi core and add-ons (including API) are required for this. We're working on this, but still a long way to go, no release date scheduled so far.
find quote
rbuehlma Online
Member
Posts: 60
Joined: Aug 2014
Reputation: 4
Post: #38
(2017-06-07 05:20)MatthewLundberg Wrote:  Confirmed, it is easy to support ReadLiveStream, and I have done so in yet-to-be-pushed code. No more strStreamURL or ThisIsAHack calling GetLiveStreamURL. And maybe it's my imagination, but channel changes seem to be faster and smoother.

Do you know if that would also work for streams which should be handled by an inputstream addon (e.g. a DASH stream)?
find quote
MatthewLundberg Offline
Member
Posts: 61
Joined: Apr 2017
Reputation: 0
Post: #39
I don't know what a DASH stream is. It would probably work for the simple IPTV addon, on which the first version of the HDHomeRun PVR is based.

See here: https://github.com/MatthewLundberg/pvr.h...e5bdb440c0
find quote
noggin Offline
Super Moderator
Posts: 4,734
Joined: Oct 2008
Reputation: 125
Location: United Kingdom
Post: #40
(2017-06-07 14:19)MatthewLundberg Wrote:  I don't know what a DASH stream is. It would probably work for the simple IPTV addon, on which the first version of the HDHomeRun PVR is based.

See here: https://github.com/MatthewLundberg/pvr.h...e5bdb440c0

DASH = MPEG-DASH - a streaming standard that allows dynamic bitrate switching whilst streaming. It's increasingly used by Catch Up TV and OTT operators.
find quote
FernetMenta Offline
Team-Kodi Developer
Posts: 6,243
Joined: Jul 2010
Reputation: 146
Location: Munich
Post: #41
post #1 updated. SwitchChannel is deprecated: https://github.com/xbmc/xbmc/blob/master...dll.h#L418
find quote
margro Offline
Posting Freak
Posts: 815
Joined: Oct 2009
Reputation: 28
Location: The Netherlands
Post: #42
Please reconsider this. Dropping this will break many PVR addons like the Mediaportal PVR addon and the ArgusTV addon and I cannot fix them since I don't know how...
Removing deprecated functions is ok, but I don't see a viable alternative.

I understand that changing the path is a hack. I came up with this since my other proposal to add a return value to the OpenLiveStream function which indicates that Kodi should open an URL instead was rejected.
The GetLiveStreamURL() url is used to let the Kodi player play MediaPortals rtsp stream or IPTV stream or web radio URLs. I do us the OpenLiveStream() and OpenRecordedStream() for normal DVB streams but I'm not planning in any way to re-invent the wheel by extending the addon with logic to play streams that the Kodi player already handles.

So my question is what the new way is of playing RTSP streams, mp3 streams, and other webstream from a PVR addon? I haven't seen a solution for this yet...

W.r.t to the removal of SwitchChannel:
What is the new calling sequence for this?
Is this just another OpenLiveStream() call without closing the existing stream or is this a CloseLiveStream() followed by a new OpenLiveStream(). The latter will break my fast channel switching logic for RTSP streams since closing followed by opening will add more that 3 seconds to a channel switch.

I hope to see some good suggestions for my questions and some time for me to implement them before you remove the deprecated functions. One week is waaay tooo short.

Developer of the MediaPortal PVR addon and retired developer of the Argus-TV PVR-addon.
http://www.scintilla.utwente.nl/~marcelg/xbmc
find quote
Martijn Offline
Team Kodi
Posts: 17,018
Joined: Jul 2011
Reputation: 312
Location: Dawn of time
Post: #43
What's too short? V18 release date has not been set yet so there enough time for some one to fix it. During alpha I simply don't care if some Addons are broken. If it doesn't happen we'll then sorry for those who use those addons. They can stick with v17

Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
(This post was last modified: 2017-07-23 20:22 by Martijn.)
find quote
margro Offline
Posting Freak
Posts: 815
Joined: Oct 2009
Reputation: 28
Location: The Netherlands
Post: #44
Well the PR mentions "merge in 1 week if there are no objections". That is a bit short to prepare if I don't know yet how to fix the addon in a proper way Wink

Developer of the MediaPortal PVR addon and retired developer of the Argus-TV PVR-addon.
http://www.scintilla.utwente.nl/~marcelg/xbmc
find quote
Martijn Offline
Team Kodi
Posts: 17,018
Joined: Jul 2011
Reputation: 312
Location: Dawn of time
Post: #45
Well then in one week the addon is broken for alpha builds. I can't see the issue in that. After that there's probably some months left for someone to pick up whatever needs to be done.

Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
find quote