Posts: 118
Joined: Apr 2017
Reputation:
0
2017-06-04, 04:39
(This post was last modified: 2017-06-06, 02:40 by MatthewLundberg.)
Does this mean that the client function GetLiveStreamURL is also going away?
It sounds like the PVR is now required to handle the network IO for reading remote streams, as this could be previously specified by strStreamURL.
Assuming that this is correct, are there calls into Kodi that I can make to handle the networking? The HDHomeRun PVR is now using strStreamURl to specify the stream, which is opened by the *DVD* reader.
Posts: 118
Joined: Apr 2017
Reputation:
0
2017-06-06, 06:10
(This post was last modified: 2017-06-06, 06:43 by MatthewLundberg.)
Partially answering my own question, it looks like I can create an object of type CDVDInputStreamFFmpeg, as in the function CDVDFactoryInputStream::CreateInputStream. Once I figure out how to build the CFileItem that it needs...
Can I call these functions from within the PVR code?
Posts: 118
Joined: Apr 2017
Reputation:
0
2017-06-07, 05:20
(This post was last modified: 2017-06-07, 05:23 by MatthewLundberg.)
Confirmed, it is easy to support ReadLiveStream, and I have done so in yet-to-be-pushed code. No more strStreamURL or ThisIsAHack calling GetLiveStreamURL. And maybe it's my imagination, but channel changes seem to be faster and smoother.
I do have a question about this though. In this thread, picture-in-picture is mentioned. However, the function for ReadLiveStream does not indicate a channel or any other handle to allow the PVR to supply multiple streams. Is picture-in-picture only supported for two instances of the PVR, or for the PVR and another stream (say, from a file)?
Posts: 883
Joined: Oct 2009
Reputation:
37
margro
Posting Freak
Posts: 883
Please reconsider this. Dropping this will break many PVR addons like the Mediaportal PVR addon and the ArgusTV addon and I cannot fix them since I don't know how...
Removing deprecated functions is ok, but I don't see a viable alternative.
I understand that changing the path is a hack. I came up with this since my other proposal to add a return value to the OpenLiveStream function which indicates that Kodi should open an URL instead was rejected.
The GetLiveStreamURL() url is used to let the Kodi player play MediaPortals rtsp stream or IPTV stream or web radio URLs. I do us the OpenLiveStream() and OpenRecordedStream() for normal DVB streams but I'm not planning in any way to re-invent the wheel by extending the addon with logic to play streams that the Kodi player already handles.
So my question is what the new way is of playing RTSP streams, mp3 streams, and other webstream from a PVR addon? I haven't seen a solution for this yet...
W.r.t to the removal of SwitchChannel:
What is the new calling sequence for this?
Is this just another OpenLiveStream() call without closing the existing stream or is this a CloseLiveStream() followed by a new OpenLiveStream(). The latter will break my fast channel switching logic for RTSP streams since closing followed by opening will add more that 3 seconds to a channel switch.
I hope to see some good suggestions for my questions and some time for me to implement them before you remove the deprecated functions. One week is waaay tooo short.
Posts: 17,859
Joined: Jul 2011
Reputation:
371
2017-07-23, 20:22
(This post was last modified: 2017-07-23, 20:22 by Martijn.)
What's too short? V18 release date has not been set yet so there enough time for some one to fix it. During alpha I simply don't care if some Addons are broken. If it doesn't happen we'll then sorry for those who use those addons. They can stick with v17
Posts: 17,859
Joined: Jul 2011
Reputation:
371
Well then in one week the addon is broken for alpha builds. I can't see the issue in that. After that there's probably some months left for someone to pick up whatever needs to be done.
reventCopy class does not allow moves. Is this code being actively maintained?
