Posts: 4,545
Joined: Jun 2015
Reputation:
269
Embedded images in my Flac files with Vorbis comments work OK, but not sure about ogg. Should be the same code, perhaps? Then again I'm not sure I am seeing the results of METADATA_BLOCK_PICTURE or COVERART tags.
Wiki could easily be wrong. If you can try a trace of the code during scan of TagLoaderTagLib.cpp - I notced a PR so wondering if you have some dev skills.?
Posts: 23
Joined: Jun 2016
Reputation:
1
2016-06-09, 09:11
(This post was last modified: 2016-06-09, 09:40 by beedaddy.)
After digging more in the code and reading the TagLib API documentation, I think found the problem. I'll prepare a PR which (hopefully) fixes loading embedded cover art for xiph comments.
EDIT: Just saw that this is due to an API change in TagLib (1.11). So it's a litte bit more complicated...
Posts: 4,545
Joined: Jun 2015
Reputation:
269
Great, ping me on that PR when done. Also help if you can provide some (licence free) ogg files for testing (same is true of your Opus file PR). I am away from my dev env at the moment, so can't do any trace or testing.
Posts: 23
Joined: Jun 2016
Reputation:
1
@DaveBlake: Hopefully PR #9935 does the trick.
Posts: 23
Joined: Jun 2016
Reputation:
1
@DaveBlake: Don't know why but sending a PM here doesn't work. Do you still need example files?
Posts: 4,545
Joined: Jun 2015
Reputation:
269
You need a few more posts (10 in fact) and PM becomes an option. Meanwhile I can PM you my email address, which can't take music file attachments but a dropbox link would work.
Need to get some testing done before merge, but I will support your PRs into v17 no worries.
Time is always the issue for everyone, and once you start you can find Kodi eating weeks of your life! I need to type up my job list sometime, the forum feature request list is very long too. And there are bugs listed in Trac, so many date back 18months or more, but hard to get a handle on. I really it is about what areas of Kodi interest you. Are there things it does you would like it to do better, more etc.? I'm happy to talk about the stuff I know a little about.
As for "topics" just as a random example, immediately related to what you have done is the way Kodi makes embedded art available to the skins. It can scan upto 3 images from tags, but only shows one. For multiple artist music you only see the first artist image, not the others etc. I have not dug into this any further to define the task, but there are clues out on the forum.
Posts: 4,545
Joined: Jun 2015
Reputation:
269
Now I have some files to start with I can make ogg and opus files as I want. Shame that the ones you sent weren't smaller!
Meanwhile I and getting some odd behaviour with images in FLAC files. I have ended up with a zombie image, that is no longer embedded in the music files AKAIK, but Kodi v17 keeps finding it. Yet v16 doesn't (taglib 1.10). Fancy helping me out to track this down?
Posts: 23
Joined: Jun 2016
Reputation:
1
When it comes to FLAC files I'm not sure about how pictures *should* be stored. kid3/easytag/picard all doesn't save a tag name, they just save the image. Can you confirm that? So neither the "old" (which looks for METADATA_BLOCK_PICTURE) nor the new code (which uses pictureList() which also looks for METADATA_BLOCK_PICTURE) in ParseTag() can find the pictures. But both v16 and v17 use SetFlacArt() which doesn't depend on this tag name. At least this is how I understand it. So, no, this does not answer the question why v17 keeps finding your zombie image. :-D
How did you come to this zombie image? Could you make this (or an equivalent free file) available for me?
(And, talking about v17 you mean WITH my PR?)
Posts: 4,545
Joined: Jun 2015
Reputation:
269
Thanks for engaging with this. No I'm not sure either about how images in FLAC work, and I had not questioned it until your PR, which works fine BTW.
During testing I noticed one of my test albums had low res thumb, and for no real reason decided to replace it with a higher one. So I used Mp3tag to remove the embedded art and add a better cover image, but this better image never appeared. So I swapped for a completedly different image to make it more obvious, v17 (with and without your PR, it is nothing related to anything you did) still shows the original.
Load the same music files into v16 I see my new image, look in Mp3tag and Picard it is the only image embedded, but back in v17 up comes the old one. I have deleted cache etc. Messed with versions that don't call SetFlacArt, and then I get no thumbnail, so the art isn't comming from somewhere else.
It would seem to be an interaction between how Mp3tag edits cover art in FLAC and how taglib 1.11 reads it.
I'm going to see if I can repeat it the issue with smaller (fake) music files that will be easier to pass about for analysis.