Bug adsp.basic crashes when cancel is clicked
#1
(2016-06-20, 01:55)Milhouse Wrote: I'll include the ADSP addons in the next build (#0620) but if at all possible I'd really like to avoid discussing ADSP-related issues in this thread. I've asked @wisler how he wants to handle this - a general "Bug reports" thread worked well for Estuary so could work well for ADSP. Alternatively, individual "Bug" threads could be started in the Audio DSP sub-forum.

I've found a way to crash Kodi using the ADSP add-ons, I'll report it here until we know how @wisler wants similar reports handled in future:

1. Enable "Audio DSP Basic Processor" and "Free Surround Processor" Audio DSP add-ons
2. Settings > Audio - enable audio DSP processing, then in Audio DSP manager enable "Speaker correction" post-processing
3. Play a music track
4. Access "Audio DSP settings" from OSD
5. Click on "Speaker / Output setup..."
6. Click on "Speaker distance..."
7. Click on "Cancel" button (or click Back remote button) and Kodi will crash
8. Crash log: http://sprunge.us/HAXa

Thanks @Milhouse for reporting this issue. I will try if I can replicate your bug.

So far I can see you crash happens because the xml settings file is incorrect or not available:

PHP Code:
#0  0x00541d6c in ActiveAE::CActiveAEDSPAddon::InputProcess(ADDON_HANDLE_STRUCT*, float const**, unsigned int) ()
[Current thread is 1 (Thread 0x6fbfe3a0 (LWP 1434))]
...
00:36:19 1049.828125 T:1962475520   ERRORAddOnLogAudio DSP Basic Processorinvalid settings data (no <demotag found)
...
00:36:22 1052.906982 T:1962475520   ERRORActiveAE DSP Unhandled exception caught while trying to call 'CallMenuHook' on add-on 'Basic audio DSP processing system'becomes diabledPlease contact the developer of this add-onTeam KODI
00
:36:22 1052.907104 T:1962475520   DEBUGActiveAE DSP Destroy destroying audio dsp add-on 'Basic audio DSP processing system'
00:36:22 1052.907471 T:1962475520   DEBUGSECTION:UnloadDll(/usr/lib/kodi/addons/adsp.basic/adsp.basic.so.0.3.0)
00:36:22 1052.907837 T:1962475520    INFOADDONDll Destroyed Audio DSP Basic Processor 

Could you test it again with these instructions? First click OK and let the add-on create his xml settings file. Afterwards reopen the dialog and click cancel. Do these instructions prevent the crash?
Latest news about AudioDSP and my libraries is available on Twitter.

Developers can follow me on Github.
Reply
#2
(2016-06-20, 08:09)wisler Wrote: Could you test it again with these instructions? First click OK and let the add-on create his xml settings file. Afterwards reopen the dialog and click cancel. Do these instructions prevent the crash?

Yes, that has stopped it from crashing, thanks.
Texture Cache Maintenance Utility: Preload your texture cache for optimal UI performance. Remotely manage media libraries. Purge unused artwork to free up space. Find missing media. Configurable QA check to highlight metadata issues. Aid in diagnosis of library and cache related problems.
Reply

Logout Mark Read Team Forum Stats Members Help
adsp.basic crashes when cancel is clicked0