Kodi 17 - Playback of ongoing recording

  Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
jobisoft Offline
Junior Member
Posts: 20
Joined: Jun 2016
Reputation: 0
Post: #1
I am using dvb.viewer 2.3.2 with Kodi 17 and I want to try out "RecordingReader: Allows playback of ongoing recordings" which was added to the "developer version" as mentioned in the "Important Thread" in this forum (http://forum.kodi.tv/showthread.php?tid=221529).

What is that? How can I use it? It does not seem to be an developer version of the dvb viewer addon...

Thanks for your help.
(This post was last modified: 2016-06-22 08:47 by jobisoft.)
find quote
manül Offline
Moderator
Posts: 402
Joined: Mar 2013
Reputation: 24
Post: #2
That forum thread is rather old. I probably should delete it.

Playback of ongoing recordings was broken because Kodi looks up the filesize only on playback start. For ongoing recordings the filesize will grow while watching. So the playback stopped after reaching the filesize the recording had at the beginning.
However please note that this is broken again in Kodi 17 because of an PVR API change or rather removal. I didn't have time to find an alternate approach.
(This post was last modified: 2016-06-21 23:37 by manül.)
find quote
jobisoft Offline
Junior Member
Posts: 20
Joined: Jun 2016
Reputation: 0
Post: #3
Thanks for your quick answer! So it should work in Kodi 16? How do I trigger that special playback?

Do you plan on fixing this in the future for Kodi 17? I am willing to help in testing!


Thanks for your time!

Btw, have you asked the kodi dev team, to re-integrate the removed API, so it can work again without having to "fix" it?
(This post was last modified: 2016-06-21 23:53 by jobisoft.)
find quote
manül Offline
Moderator
Posts: 402
Joined: Mar 2013
Reputation: 24
Post: #4
(2016-06-21 23:51)jobisoft Wrote:  Thanks for your quick answer! So it should work in Kodi 16? How do I trigger that special playback?
It should work in Kodi 16, yes. However sometimes it just doesn't work. The whole mechanism of refreshing the file size is buggy and messy.
There's nothing to trigger from your side. It gets enabled if you start playing an ongoing recording.

(2016-06-21 23:51)jobisoft Wrote:  Do you plan on fixing this in the future for Kodi 17? I am willing to help in testing!
Sure, but I doubt that I'll have enough (or any) time before Kodi 17. Also fixing this is rather low priority. Just wait until the recording completes.

(2016-06-21 23:51)jobisoft Wrote:  Btw, have you asked the kodi dev team, to re-integrate the removed API, so it can work again without having to "fix" it?
Yes. But they have removed it for a reason.
find quote
jobisoft Offline
Junior Member
Posts: 20
Joined: Jun 2016
Reputation: 0
Post: #5
I just tried Kodi 16 and it works very nice.

If allowed, I would like to help to bring this back to Kodi 17. Could you guide me to the git commits, where you introduced that feature in the first place, to see how you did it and to start learning? And also the git commits, where you updated to the new API and removed the feature again?

If this feature is coming back, I would propose a small change: Do not just update the end time if playback reaches the end marker, but always, so it is possible to fast forward to the end at any given time.

Thanks for your time
John
(This post was last modified: 2016-06-22 17:44 by jobisoft.)
find quote
manül Offline
Moderator
Posts: 402
Joined: Mar 2013
Reputation: 24
Post: #6
(2016-06-22 17:41)jobisoft Wrote:  I just tried Kodi 16 and it works very nice.

If allowed, I would like to help to bring this back to Kodi 17. Could you guide me to the git commits, where you introduced that feature in the first place, to see how you did it and to start learning? And also the git commits, where you updated to the new API and removed the feature again?

Implementation: https://github.com/kodi-pvr/pvr.dvbviewe...e7ce94a557
Broken since: https://github.com/kodi-pvr/pvr.dvbviewe...3d2a6bc8b7
Reason why the onPlay is required: https://github.com/kodi-pvr/pvr.dvbviewe...-213570263

As explained in the comment, the best way to solve this is to integrate/write a small http library which pulls the stream data on it's own. Every now and then we issue a HEAD to get the new file size. Kodi integrates curl, however curl is abstracted away and we can't make use of curls API. Linking curl is a no go because of duplicated symbols.

(2016-06-22 17:41)jobisoft Wrote:  If this feature is coming back, I would propose a small change: Do not just update the end time if playback reaches the end marker, but always, so it is possible to fast forward to the end at any given time.

It's refreshing the file size every REOPEN_INTERVAL (30) seconds. If it's close to the end, refresh interval increases to REOPEN_INTERVAL_FAST (10) seconds. However this close + reopen is a really ugly workaround.
find quote
logifuse Offline
Junior Member
Posts: 8
Joined: Jan 2017
Reputation: 0
Post: #7
Just mentioning that this is still broken in 17 final & the 18 nightlies. Any sign of a fix? It's a big step backwards & is a necessary feature of a PVR.

Thanks
find quote
junias Offline
Senior Member
Posts: 118
Joined: Apr 2014
Reputation: 0
Post: #8
Workaround for me with Kodi 17:
Add your folder for recordings to the video library. Then just play the ongoing recording through the video section, instead of the pvr section.
For me, then i can watch the ongoing recording without stopping Smile
find quote
manül Offline
Moderator
Posts: 402
Joined: Mar 2013
Reputation: 24
Post: #9
(2017-02-08 06:56)logifuse Wrote:  Just mentioning that this is still broken in 17 final & the 18 nightlies. Any sign of a fix? It's a big step backwards & is a necessary feature of a PVR.
Subscribe to https://github.com/kodi-pvr/pvr.dvbviewer/issues/35 and you'll be notified as soon as it's fixed.
find quote
logifuse Offline
Junior Member
Posts: 8
Joined: Jan 2017
Reputation: 0
Post: #10
Thanks junias & manül.
find quote
junias Offline
Senior Member
Posts: 118
Joined: Apr 2014
Reputation: 0
Post: #11
You´re welcome
find quote