Mac OS X - [Mac Mini] [v17 Nightly] Choppy Video Playback

  Thread Rating:
  • 1 Vote(s) - 5 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
Waltman Offline
Senior Member
Posts: 291
Joined: Dec 2012
Reputation: 6
Location: below sea level
Post: #46
Jingai, i tested the second build, first one is was not available

Mac Mini 2011 intel HD3000
MACOS Sierra 01.12
kodi-20160930-27c4bc6-jingai-osx_vtb_timing_memphiz_422YpCbCr8_iosurface-x86_64
VTB = ON
Log at : http://pastebin.com/s8XVYxCD

conclusion
result: smooth playback
cpu at 20 - 30%
This test build solves the VTB problems.

How to post a debug log ; MacOS acces the hidden userdata folder ; How to post a question ; How to fix gatekeeper issues
(This post was last modified: 2016-10-03 08:01 by Waltman.)
find quote
FernetMenta Offline
Team-Kodi Developer
Posts: 6,190
Joined: Jul 2010
Reputation: 140
Location: Munich
Post: #47
Can anybody make a short video of the screen when the issue shows? I would like to see what you see. Please do this with current nightly and turn component logging for video on, ffmpeg off. Please post debug log with video.
find quote
jingai Offline
Skilled Skinner
Posts: 2,146
Joined: Mar 2010
Reputation: 36
Post: #48
(2016-10-03 10:40)FernetMenta Wrote:  Can anybody make a short video of the screen when the issue shows? I would like to see what you see. Please do this with current nightly and turn component logging for video on, ffmpeg off. Please post debug log with video.

Video showing the problem.

Debug log with component logging for video on, everything else off.
find quote
FernetMenta Offline
Team-Kodi Developer
Posts: 6,190
Joined: Jul 2010
Reputation: 140
Location: Munich
Post: #49
Thanks. dropbox seems incredible slow today. Still trying to download the video, 3rd attempt now...
In the meantime, could you please try this change? https://github.com/FernetMenta/xbmc/tree/vtb
find quote
jingai Offline
Skilled Skinner
Posts: 2,146
Joined: Mar 2010
Reputation: 36
Post: #50
(2016-10-03 16:05)FernetMenta Wrote:  In the meantime, could you please try this change? https://github.com/FernetMenta/xbmc/tree/vtb

Built it, but will have to test when I get home. I'll get back with you this evening.
find quote
FernetMenta Offline
Team-Kodi Developer
Posts: 6,190
Joined: Jul 2010
Reputation: 140
Location: Munich
Post: #51
Got the video now. Looks pretty much like buffer reuse/overwrite before the GPU actually processed the buffer. I think the 422 format only worked by chance.
find quote
FernetMenta Offline
Team-Kodi Developer
Posts: 6,190
Joined: Jul 2010
Reputation: 140
Location: Munich
Post: #52
I updated the my branch. Please make sure to get latest changes.
find quote
Waltman Offline
Senior Member
Posts: 291
Joined: Dec 2012
Reputation: 6
Location: below sea level
Post: #53
kodi-20161002-25601d3-master-x86_64
video showing the problem
kodi log with component loggin for video on

How to post a debug log ; MacOS acces the hidden userdata folder ; How to post a question ; How to fix gatekeeper issues
find quote
FernetMenta Offline
Team-Kodi Developer
Posts: 6,190
Joined: Jul 2010
Reputation: 140
Location: Munich
Post: #54
(2016-10-03 18:30)Walt74 Wrote:  kodi-20161002-25601d3-master-x86_64
video showing the problem
kodi log with component loggin for video on

This is no performance issue, measured fps does not drop. You get this effect as shown in the video if a buffer is reused for decoding before the last content of the buffer has been processed by the GPU and rendered to screen. The new frame is in the future. This makes the video look jumping back and forth.
In my linked branch I implemented the same concept (fence) as I did for vdpau and vaapi.
find quote
Waltman Offline
Senior Member
Posts: 291
Joined: Dec 2012
Reputation: 6
Location: below sea level
Post: #55
(2016-10-03 18:48)FernetMenta Wrote:  
(2016-10-03 18:30)Walt74 Wrote:  kodi-20161002-25601d3-master-x86_64
video showing the problem
kodi log with component loggin for video on

This is no performance issue, measured fps does not drop. You get this effect as shown in the video if a buffer is reused for decoding before the last content of the buffer has been processed by the GPU and rendered to screen. The new frame is in the future. This makes the video look jumping back and forth.
In my linked branch I implemented the same concept (fence) as I did for vdpau and vaapi.

Is there a build i should test with the changes you made ?

How to post a debug log ; MacOS acces the hidden userdata folder ; How to post a question ; How to fix gatekeeper issues
find quote
jingai Offline
Skilled Skinner
Posts: 2,146
Joined: Mar 2010
Reputation: 36
Post: #56
I will post a build with FernetMenta's patches tonight.
find quote
jingai Offline
Skilled Skinner
Posts: 2,146
Joined: Mar 2010
Reputation: 36
Post: #57
(removed test builds -- see here)
(This post was last modified: 2016-10-04 03:09 by jingai.)
find quote
jingai Offline
Skilled Skinner
Posts: 2,146
Joined: Mar 2010
Reputation: 36
Post: #58
@FernetMenta,

Unfortunately your patches (commits 6d5af7d and 00682bc) did not solve the problem. The symptoms are the same as before (buffer reuse, videos appears to be jumping back and forth).

My debug log is here.
find quote
jingai Offline
Skilled Skinner
Posts: 2,146
Joined: Mar 2010
Reputation: 36
Post: #59
Ah, there was a typo on line 236 of RendererVTBGL.cpp. If I dump that return, it does indeed work fine Smile

Debug log in case you wanted to see it.

For those that want to test it, here is a build with FernetMenta's patches applied.
(This post was last modified: 2016-10-04 03:36 by jingai.)
find quote
FernetMenta Offline
Team-Kodi Developer
Posts: 6,190
Joined: Jul 2010
Reputation: 140
Location: Munich
Post: #60
(2016-10-04 02:53)jingai Wrote:  Ah, there was a typo on line 236 of RendererVTBGL.cpp. If I dump that return, it does indeed work fine Smile

Debug log in case you wanted to see it.

For those that want to test it, here is a build with FernetMenta's patches applied.

Thank you very much. Great that you noticed the error in the code. Was a left over from my testing.
find quote
Post Reply