2016-09-19, 14:06
I'd say: if you can add it. The reason is not the functionality but what "blocking" does. This basically means: block until data is consumed. Depending on other implementations it would run into fragmentation with non blocking. E.g. it will return and application needs to fragment the data. In kodi's case we rely on a blocking sink to consume data.
I'd handle this gracefully, e.g. if (whatever) do whatever else do the opposite.
There is something I don't like about the API. Both short[] methods are "documented" with opening the sink with PCM_16bit, which we can't - as we want to use IEC format.
What would you suggest?
Quote:Should these lines also be added to Lollipop as it is in Marshmallow or not needed and will cause other problems?
https://github.com/geekboxzone/mmallow_f...1846-L1849
I'd handle this gracefully, e.g. if (whatever) do whatever else do the opposite.
There is something I don't like about the API. Both short[] methods are "documented" with opening the sink with PCM_16bit, which we can't - as we want to use IEC format.
What would you suggest?
