Public Estuary GitHub repository
#16
(2017-09-20, 10:37)subzero78 Wrote:
(2016-09-22, 01:20)phil65 Wrote: If people want to contribute to Estuary, here is a public branch which i intend to keep in sync with the skin from our main kodi repo.

https://github.com/phil65/skin.estuary

So if you feel like putting up a PR or if you are interested in the past development of the skin, then this is the place to go. Wink

Problem with install from zip xbmc gue version can.t install from zip kodi 17.4

Why are you doing this when Estuary is included?

Anyway what is you likely doing is downloading the zip for the Master branch which at this time will be Leia v18 only, if you want Estuary for v17 you need to switch to the Krypton branch via the drop down menu see https://github.com/phil65/skin.estuary/tree/krypton
Reply
#17
(2017-09-20, 11:41)jjd-uk Wrote:
(2017-09-20, 10:37)subzero78 Wrote:
(2016-09-22, 01:20)phil65 Wrote: If people want to contribute to Estuary, here is a public branch which i intend to keep in sync with the skin from our main kodi repo.

https://github.com/phil65/skin.estuary

So if you feel like putting up a PR or if you are interested in the past development of the skin, then this is the place to go. Wink

Problem with install from zip xbmc gue version can.t install from zip kodi 17.4

Why are you doing this when Estuary is included?
I busy with making a New skin and i use estuary for base because i like this skin i use this for making some chance
Know working from git idd have used the Master branch Confused

Anyway what is you likely doing is downloading the zip for the Master branch which at this time will be Leia v18 only, if you want Estuary for v17 you need to switch to the Krypton branch via the drop down menu see https://github.com/phil65/skin.estuary/tree/krypton
Reply
#18
Your options are:

1. Use Krypton version as your base, you can download zip for this from link I gave.

2. Undo this change in Master branch https://github.com/phil65/skin.estuary/c...b893cc1e69 to revert to

Code:
<import addon="xbmc.gui" version="5.12.0"/>

However note that running a skin designed for v18 on a older version of Kodi such as v17 could result in errors being observed.
Reply
#19
Just to add the obvious as well, since Estuary Master is for v18 development builds then do your skin work on v18 nightlies.
Reply
#20
Is this repo still the way to submit suggested changes and bug fixes to Estuary?  I submitted a pull request a little while back on the master branch and just noticed that there are pull requests as far back as November of 2016 that have no action on them.
Reply
#21
@pkscout

Can you give me the link to the PR and I will ask for you in the Estuary channel.
My Signature
Links to : Official:Forum rules (wiki) | Official:Forum rules/Banned add-ons (wiki) | Debug Log (wiki)
Links to : HOW-TO:Create Music Library (wiki) | HOW-TO:Create_Video_Library (wiki) || Artwork (wiki) | Basic controls (wiki) | Import-export library (wiki) | Movie sets (wiki) | Movie universe (wiki) | NFO files (wiki) | Quick start guide (wiki)
Reply
#22
(2018-07-11, 02:16)Karellen Wrote: @pkscout

Can you give me the link to the PR and I will ask for you in the Estuary channel.
 https://github.com/phil65/skin.estuary/pull/252

It's kind of a big functional change (without changing any aesthetics), so I won't feel bad if it doesn't get accepted.  But I did all the work for my mod, so I thought I'd roll the dice and see what happens.
Reply
#23
You're be better off submitting to the XBMC repo so the changes go straight into the nightlies if accepted, it's how all recent Estuary changes have gone in which haven't come from Phil. Just to be clear submit to https://github.com/xbmc/xbmc
Reply
#24
Thanks. I have posted a message. The Estuary channel is very quiet, not a lot happens in there. Lately it has been ronie that is responding there, but he hasn't been about for a few days.
My Signature
Links to : Official:Forum rules (wiki) | Official:Forum rules/Banned add-ons (wiki) | Debug Log (wiki)
Links to : HOW-TO:Create Music Library (wiki) | HOW-TO:Create_Video_Library (wiki) || Artwork (wiki) | Basic controls (wiki) | Import-export library (wiki) | Movie sets (wiki) | Movie universe (wiki) | NFO files (wiki) | Quick start guide (wiki)
Reply
#25
+ what @jjd-uk said Smile
My Signature
Links to : Official:Forum rules (wiki) | Official:Forum rules/Banned add-ons (wiki) | Debug Log (wiki)
Links to : HOW-TO:Create Music Library (wiki) | HOW-TO:Create_Video_Library (wiki) || Artwork (wiki) | Basic controls (wiki) | Import-export library (wiki) | Movie sets (wiki) | Movie universe (wiki) | NFO files (wiki) | Quick start guide (wiki)
Reply
#26
Oh and when submitting include Estuary in name of PR see here https://github.com/xbmc/xbmc/pulls?q=is%...s%3Aclosed
Reply
#27
Best to break up the PR into smaller PR's I think as well, it will most likely be quickly rejected in its current form I think.
Image Image
Reply
#28
Let's see what @ronie has to say about it since Phil seems to MIA at tbe moment. Personally I'd like to see these kind of customisation options accepted to make for a better user experience.
Reply
#29
i won't have any time to look into it for the next 2 weeks.
Do not PM or e-mail Team-Kodi members directly asking for support.
Always read the Forum rules, Kodi online-manual, FAQ, Help and Search the forum before posting.
Reply
#30
Can somebody, who maybe also likes the idea, work in a context-menu code for:

"Go to Collection" or "Show Collection" or something like that?

Image
Reply



Logout Mark Read Team Forum Stats Members Help
Public Estuary GitHub repository3
This forum uses Lukasz Tkacz MyBB addons.