Posts: 883
Joined: Oct 2009
Reputation:
37
margro
Posting Freak
Posts: 883
The PVR addon is properly sending a ADDON_STATUS_LOST_CONNECTION state to Kodi, so it is a Kodi bug if it behaves different from Jarvis.
I haven't seen any PVR deprecation notice indicating that the pvr addon devs should modify this, so if it is broken (and yes I can confirm that is broken), it is a regression bug in Kodi.
I will not fix the addon for things that I did not break.
I checked all PVR addons and almost all use the same ADDON_STATUS_LOST_CONNECTION state that I'm using already since XBMC Frodo.
Posts: 883
Joined: Oct 2009
Reputation:
37
margro
Posting Freak
Posts: 883
@ksooo: Well, I haven't seen any PVR API change a deprecation warning or any documentation about how to implement the new stuff, so without proper notice in time, no PVR addon developer will update their addons.
I checked all of them yesterday and only TVHeadend seems to implement the new async stuff. All others use PVR_ERROR_CONNECTION_LOST.
I completely agree with the new solution, but removing the old way of working before the PVR addons are updated is asking for trouble.
Therefore I consider the current situation as a regression bug since known to work addons are suddenly getting bug reports for stuff that is suddenly broken without any announcement.
I won't have time to update the addon so I will advice people to stay on Jarvis. I'm not going to update the MediaPortal PVR addon for Krypton.
Posts: 6,810
Joined: Jul 2010
Reputation:
198
In general I announce API changes in the forum but for some reason I have missed that for this change. Sorry for that, was not by intent.
Posts: 883
Joined: Oct 2009
Reputation:
37
margro
Posting Freak
Posts: 883
Apologies accepted ;-)
It was a bit of an unpleasant surprise for me, therefore overreacted a bit out of frustration.
It is probably still a good idea to put the mssing references to the Krypton PVR API changes (at least a reference to the pull requests) in the PVR API change thread such that also the other PVR devs are aware of the extensions.
Anyway, I'm currently trying to implement the async stuff by reverse engineering the TVHeadend PVR addon changes. With a bit of luck (and time) I will have something ready soon.
Posts: 34
Joined: Mar 2016
Reputation:
0
lokum
Junior Member
Posts: 34
Just wanted to say thanks to margro for implementing this feature into the latest Krypton nightly. Works great. Thanks so much!
Posts: 1,016
Joined: Sep 2012
Reputation:
55
janbar
Posting Freak
Posts: 1,016
Hi,
I haven't seen any announcement about this change. Could you drive me to explain what has been changed in the behavior and how to handle it in krypton. Thanks.