v17 replaygain doesn't seem to be working
#19
The PR that changed how the player applied gain in v17 is https://github.com/xbmc/xbmc/pull/10924

It fixed the initial issue raised by this thread (gain was ingored unless peak was tagged too), but also changed how clipping was applied. This is player stuff, my only contribution was removing the "avoid clipping" setting that had become redundant.

Discussion refered to this article https://en.wikipedia.org/wiki/Loudness_war, and from that Fernet concluded that "our code for considering clipping is very wrong". He said "ActiveAE has clipping protection when stream amplification is applied. So we should apply replayGain as replayGain if m_peak equals 1.0 and as volume amplification for the other cases. The old setting “avoidClipping” seems useless should imo go away."

I do not know enough to see if this change has produced what you are experiencing, I simply offer up the information that I have.

Edit: but if you can give me access to some test files I will trace through debug and see if I can understand more.
Reply


Messages In This Thread
RE: replaygain doesn't seem to be working - by DaveBlake - 2017-02-11, 11:32


Logout Mark Read Team Forum Stats Members Help
replaygain doesn't seem to be working0
This forum uses Lukasz Tkacz MyBB addons.