2017-03-16, 18:15
(2017-02-08, 14:32)tkgafs Wrote: Taking this slightly off topic does anyone know of a free program for batch adding replaygain tags to tracks on a windows platformhttp://i.imgur.com/c7Gf87d.png
(2017-02-08, 14:32)tkgafs Wrote: Taking this slightly off topic does anyone know of a free program for batch adding replaygain tags to tracks on a windows platformhttp://i.imgur.com/c7Gf87d.png
(2017-03-17, 17:03)DaveBlake Wrote: Anyone got a technical reference as to how replaygain is intended to work?
+ if (peak == 1.0)
+ si->m_stream->SetReplayGain(gain);
+ else
+ si->m_stream->SetAmplification(gain);
(2017-03-17, 17:17)jjd-uk Wrote: Any replaygain issues should probably be raised on trac with clear description, sample file, and log file then assigned to Fernetmenta.True. But it could be quicker to talk to me clearly instead.
(2017-03-17, 17:44)Gracus Wrote:Thanks, as it happens I was just looking at that.(2017-03-17, 17:03)DaveBlake Wrote: Anyone got a technical reference as to how replaygain is intended to work?
http://wiki.hydrogenaud.io/index.php?tit...cification
(2017-03-17, 19:45)DaveBlake Wrote:Point taken, but as the necessary ReplayGain user options haven't been implemented yet, these actions aren't a requirement.(2017-03-17, 17:17)jjd-uk Wrote: Any replaygain issues should probably be raised on trac with clear description, sample file, and log file then assigned to Fernetmenta.True. But it could be quicker to talk to me clearly instead.
(2017-03-17, 19:45)DaveBlake Wrote: I now have some doubts about the removal of the old “avoidClipping” setting.Agreed, this action was a reduction in user-selectable options.
(2017-03-17, 19:45)DaveBlake Wrote: It could be good for Kodi to always enforce some kind of clipping protection...No, the user should always have control over this option.
(2017-03-17, 19:45)DaveBlake Wrote: The solution to this is probably simple, I just don't quite get it (yet).We require ReplayGain user-selectable settings:
(2017-03-17, 22:32)John R Leddy Wrote:Odd attitude John. I came along this morning with the intention of trying to solve this issue, now I feel quite unlike doing so.(2017-03-17, 19:45)DaveBlake Wrote:Point taken, but as the necessary ReplayGain user options haven't been implemented yet, these actions aren't a requirement.(2017-03-17, 17:17)jjd-uk Wrote: Any replaygain issues should probably be raised on trac with clear description, sample file, and log file then assigned to Fernetmenta.True. But it could be quicker to talk to me clearly instead.
(2017-03-18, 09:19)DaveBlake Wrote:Dave,(2017-03-17, 22:32)John R Leddy Wrote:Odd attitude John. I came along this morning with the intention of trying to solve this issue, now I feel quite unlike doing so.(2017-03-17, 19:45)DaveBlake Wrote: True. But it could be quicker to talk to me clearly instead.Point taken, but as the necessary ReplayGain user options haven't been implemented yet, these actions aren't a requirement.
Of course users are not "required" to raise Trac issues, and reciprocally no one on the dev team is "required" to implement or fix anything, or provide support. You go on to state what you think users require, do you think that means someone will be motivated do anything about what you want?
What Kodi needs most right now is friendly collaboration: the dev team is tiny, the user base is vast. There is no place for an attitude of entitlement, which is how your tone sounded to me.
Fernet knows most about the player, but does not watch the forum, so a clearly stated Trac issue is the best way to get his attention. JJD was giving good advise. I understand how hard it can be to express problems clearly, and how a Trac ticket that isn't clear can just linger, so I was just offering to help out.
(2017-03-18, 10:48)John R Leddy Wrote: I was being polite when I stated, "...these actions aren't a requirement." Truth is, we can't log anything of relevance for something which hasn't been coded yet.You seem confused. The things being discussed in this thread have been implemented previously and then that implementation changed in v17. It is not a discussion of new feature requirements, and it would only confuse matters to turn it into one. A Trac ticket could have been raised.
(2017-03-18, 12:08)DaveBlake Wrote:(2017-03-17, 19:01)Hallucyn8 Wrote: I took a step away from this after my initial investigation as I don't really know what else I can add to help push towards a resolution.
I have a test build underway, would you or any one else be able to test how replaygain is working once it is on the mirrors?
(2017-03-18, 18:53)DaveBlake Wrote: Thanks. Test builds are on the mirrors http://mirrors.kodi.tv/test-builds/win32...e-HEAD.exe or for platform.
These are v18 but will prove the concept (or not). I attempted v17 patch builds too, but they failed for some unrelated reason.