[Mettbrot]

Hey,

I noticed some flaws in the PVR logic of Kodi:

1. When I am watching a channel timeshifted and hit the record button in the OSD I would expect the recording to start where I am right now. Not where the channel is live at this moment.
   
2. When I select a channel which is recording I get asked if I want to view from the beginning. Nice feature! But when I do so I dont get the recording control in the OSD so I have no chance to stop the recording. Same goes for starting the recording directly (which is the same as hitting yes on the dialog I guess).
   
3. There is also no indication that a recording is still in progress when you look at the recordings list.
   

I think most of this has to do with the distinction between timeshift and recording in kodi. Maybe in the future they could be handled more closely/as the same to give PVR a more natural feel.
Just some thoughts I had the other day

[ksooo]

Thanks for the valuable feedback.

Which version of Kodi are you using and which pvr backend?

Some things you mentioned are related to the feature set of the pvr backend / kodi pvr client add-on.

For instance, to my knowledge, tvheadend does not support to start a recording at current timeshift buffer position. I really wish it would because I instantly could and would start to implement this for the tvheadend Kodi pvr client add-on. ;-)

[Mettbrot]

I am using a recent(4.1-2309) tvheadend on a server in my network and the latest libreelec 7.90.008 inlcuding kodi beta 5. Maybe this would be best adressed in the tvheadend forum then. (edit, I believe this would be the proper feature request http://tvheadend.org/issues/3991)

What about the recording indicator in the list of recordings, is that backend dependent too?

[ksooo]

What about the recording indicator in the list of recordings, is that backend dependent too?

No, this is a missing feature in Kodi pvr core. If I find some time I will implement it. Should not be too difficult... ;-)

[ksooo]

What about the recording indicator in the list of recordings, is that backend dependent too?

No, this is a missing feature in Kodi pvr core. If I find some time I will implement it. Should not be too difficult... ;-)

@Mettbrot fyi, I implemented the in progress indicator for the recordings window and just merged it into Krypton master. => https://github.com/xbmc/xbmc/pull/10954 Means, this feature will be included in Krypton beta 6. ;-)

[Mettbrot]

Sweet, thank you!

I just noticed another flaw: When you watch a recording that is still in progress close to live and stop the recording it is marked as watched. I assume its because of the logic that applies to movies where its marked as watched even when you stop it ~5% before the end (for credits and stuff). This does not apply for recordings still in progress. Instead it would be wise to save the current position as "progress" if the recording is still running when you stop watching. There is an edge case in it though where you are so close to the end that the recording is still runinng (maybe due to extra added 10 minutes at the end or so) but you are finished watching the actual show. We could either disregard that case or check the "progress" on stop against the scheduled length(not the length at the moment) of the recording and decide with the ~5% rule.

[Mettbrot]

I just noticed that you fixed this behaviour in https://github.com/xbmc/xbmc/pull/12445 Thank you!

[ksooo]

I just noticed that you fixed this behaviour in https://github.com/xbmc/xbmc/pull/12445 Thank you!

You are welcome.