v17 cpack_generator=deb on rbpi platform
#1
Hi

I'm trying to compile kodi for Raspberry Pi and setting the CPACK_GENERATOR=DEB to generate debian packages at the end.

However, since CORE_SYSTEM_NAME is set to rbpi, it makes use of the Install.cmake file from cmake/scripts/rbpi which in turn it's a symlink to cmake/scripts/linux/Install.cmake.

This file has a check for CORE_SYSTEM_NAME STREQUAL linux (https://github.com/xbmc/xbmc/blob/master...cmake#L353) which will not work for the rbpi platform, because the core system name is different.

I see three options here:
- check CMAKE_SYSTEM_NAME instead of CORE_SYSTEM_NAME [preferred]
Code:
if(CPACK_GENERATOR STREQUAL DEB AND CMAKE_SYSTEM_NAME STREQUAL linux )

- replace that line with
Code:
if(CPACK_GENERATOR STREQUAL DEB AND ( CORE_SYSTEM_NAME STREQUAL linux OR CORE_SYSTEM_NAME STREQUAL rbpi) )

- copy the file and change the line to:
Code:
if(CPACK_GENERATOR STREQUAL DEB AND CORE_SYSTEM_NAME STREQUAL rbpi )

Any thoughts on this?

Thanks in advance.
Nuno
Reply
#2
Added a third option, which is now my preferred one Smile
Reply
#3
Is this the only change needed to package on rpi? Could you create a pull request on github for the second option? We try to use CORE_SYSTEM_NAME everywhere.
Reply
#4
Hi Fetzerch.

Yes, that's the only change needed for rpi. I've tested it myself.

I'll create a pull request today.

There's also something missing to package WiiRemote as well, but I'll create a new pull request for that as well.

Thanks for the input.

Nuno
Reply
#5
I've added both changes in the same pull request: https://github.com/xbmc/xbmc/pull/11321

Thanks.
Reply

Logout Mark Read Team Forum Stats Members Help
cpack_generator=deb on rbpi platform0