2017-08-24, 04:17
OK so your helper addon runs every time another addon needs to use widevine, in which case libssd_wv.so should always match whatever is installed (in OS, or add-on)? If so that sounds fine.
However in terms of your copy, just one nit-pick (which others might not agree with). You're prioritising the addon path over the OS path - I'd always see the OS version of the file having priority over any add-on version myself. For instance, say the user has installed an add-on that included libssd_wv.so, then upgrades to a new version of the OS that includes a more recent version of the addon (built-in) and also a newer version of /usr/lib/libssd_wv.so so that now the built-in add-on is used in preference to the user-installed addon. Your copy code will continue to copy the older version of libssd_wv.so from the user-installed add-on path, and ignore the OS version.
However this discussion probably isn't appropriate for this thread. If it's an issue I guess we'll find out (PM me if you want to discuss it further).
However in terms of your copy, just one nit-pick (which others might not agree with). You're prioritising the addon path over the OS path - I'd always see the OS version of the file having priority over any add-on version myself. For instance, say the user has installed an add-on that included libssd_wv.so, then upgrades to a new version of the OS that includes a more recent version of the addon (built-in) and also a newer version of /usr/lib/libssd_wv.so so that now the built-in add-on is used in preference to the user-installed addon. Your copy code will continue to copy the older version of libssd_wv.so from the user-installed add-on path, and ignore the OS version.
However this discussion probably isn't appropriate for this thread. If it's an issue I guess we'll find out (PM me if you want to discuss it further).