Posts: 1,736
Joined: Oct 2008
Reputation:
14
mafis90...this is a very important thread to a lot of people here. DO NOT HIJACK IT. Your questions has nothing to do with anything here. Do some searching and Im sure you will find your answer. Thanks.
Posts: 1,141
Joined: Mar 2006
Reputation:
0
calm down, a polite request would have served just as well. He's obviously new here, so no need to rip him to pieces.
Posts: 418
Joined: Oct 2004
Reputation:
0
Thanks everyone for your concern and wishes. I just got a cool brain CT scan this morning so hopefully the doctor will be able to tell if I am experiencing a precursor to acquisition of Super Powers of some sort. I'm hoping my SuperPower will be "the ability to divide by 0" or "the ability to use Microsoft Excel pretty well".
Welp, phase 3 is sort of done but there's a problem. The background thumb loader, which is extended to also probe the file for stream information, seems to have some thread safety issues. It creates a thread for every 5 items in a directory and if you give it a directory with more than a few threads, ffmpeg blows up in the background. If I limit the loader to a single background thread, it works just fine. I'm going to see if I can narrow it down further.
As fekker indicated, I've also added support for primary audio language and subtitle/subtitle language indicator (not for external subs yet). I also want to do presentation aspect ratio since people have asked for it.
I'm also not happy about how currently it only works in the video library, since the information hangs off CVideoInfoTag, which is only present for items in the library. There's no reason it can't work in the file view too, especially since the thumbloader is going to extract the stream info anyway. Maybe this is phase 4. Didn't I have a phase 4 already? Thinking hurts.
Posts: 1,747
Joined: Jun 2004
Reputation:
12
blittan
Retired Team-Kodi Member
Posts: 1,747
Good to hear from you CapnBry. I know what you are going thru, am scheduled for a CT scan my self..
Anyways, the external subs thing won't be that hard to add later, since it only requires scanning directorys for specific files.
Posts: 418
Joined: Oct 2004
Reputation:
0
blittan, maybe you're getting superpowers too! XRay Vision would also be cool but only though one layer of clothes and only when I want it. I don't want to be seeing organs or nude fatties. Either way, hope you feel better too man.
Back on topic, phase 3 patch posted to the ticket. We're almost there!
Posts: 586
Joined: Feb 2009
Reputation:
0
I know it has been suggested before but I don't know how the work is going regarding subtitles flagging, so, I'll just give me 2 cents on that matter:
My suggestion is to add 3 logos/flags stating:
- Internal subtitles
- External subtitles
- Internal & External subtitles
Of course, for movies without any kind of subtitles, no logo should be displayed. This is my suggestion because most of the movies I download don't have subtitles and I need to get them, thus the external subtitles logo. Other movies come with internal subtitles (in the case of MKV files), thus the internal subtitles logo. In movies with internal subtitles, some come with an array of languages and once in a while it has the language I need, but most of the time it doesn't and so I have to download the subtitles I want, thus making internal and external subtitles.
I also know it has been mentioned to have audio languages flagging and that it was troublesome because of the many available languages, but, is that really needed? I know that different people have different needs but I hate dubbed stuff, no matter the movie language, I'll ways watch a movie in it's original language and it doesn't really matter which is, if the movie is good and I want to watch it, I'll watch it and I don't care which language it's in. But this is just me, maybe it's really that important for some people, but I just wanted to point this out to see if in a general way, it's really needed or not.
Posts: 1,747
Joined: Jun 2004
Reputation:
12
blittan
Retired Team-Kodi Member
Posts: 1,747
audio language:
I can think of two scenarios.
1: people who want to have dubbed movies (for whatever reason).
2: Kids, I want to see wheater a movie has my language when my kids are going to watch it.
subtitles:
Just display subtitles, no matter if they are external/internal. Might also be interesting to see what language they are in. I see no real reason for external/internal other than if internal, you might have a chance of downloading a external one in the appropriate language if there isn't an internal one.
Posts: 74
Joined: Jul 2004
Reputation:
0
So, in the main menu, we can add Movies (SD) and go directly to the library with all your movies SD. Movies (HD) go to the library with HD movies only...
xbmc.activatewindow(videolibrary,moviessd)
xbmc.activatewindow(videolibrary,movieshd)
Something like that... Do you think its possible?
Posts: 31
Joined: Jan 2009
Reputation:
0
Whats the status on this? Any idea if it will make it to the SVN PPA soon?