2009-07-04, 16:06
jmarshall Wrote:Some stuff is committed. I have some queries about VideoInfoTag changes. What are these for? It seems to me better to just stick with one tag name to save confusion?The VideoInfoTag, the codec/codecid change reflects the decision that fourcc should be used instead of decoder codec. I know the nfo generator can make this decision itself, but there are already utilities out there that put both out so I thought this would be acceptable. The displayaspectratio thing was solely for compatibility but not as tied to that one.
Also, I'm going to change the aspect ratio stuff to work on ranges rather than the current system. Reason is that the current things either overlap, or have spaces between them - thus some fall through the cracks. Better IMO to use something like the geometric mean of each ratio as a cutoff.
And you're right about the aspect ratio (VideoAspectToAspectDescription), it has both overlap and spaces between the range! I originally wrote it as "find the closest" but then I considered that now I was just labeling things for the sake of labeling them. For example if we calculate the aspect to be 2.00, what is that? It could actually be an old 2.00 SuperScope video but "closest" would label it 1.85 which is probably wrong. Then I tried a fixed delta method which had too much overlap, and compromised with the epsilon scaling method. I welcome a better heuristic but do think there should be gaps because some things are just too far away to be called.