2018-01-17, 14:59
(2018-01-17, 13:30)Guilouz Wrote:Yes, the PR got merged. I will PR a small tweak for the new channel group selector today.(2018-01-17, 08:57)ksooo Wrote: @Guilouz you are doing a lot of cool stuff in your mod. Have you ever considered to contribute (parts of) your work back to Estuary upstream?Yes, but not sure what can be accepted in PR. I use some addons for some stuff.
You PR https://github.com/xbmc/xbmc/pull/13364 will be merged or not ?
Regarding contributin to upstream:
- Functionality that introduces dependencies to other addons wont be accepted for Estuary. That's a design decision.
- Every other change is a candidate to get merged upstream.
- I'm the official maintainer of Kodi's PVR component, this includes the user interface (the deafult skins). So, I have a saying when it is to be decided wheter a PVR PR gets merged. And as I stated I like the PVR changes you did. So, go ahead and PR, if you like.
- In case you want to contribute to upstream, please do not a big blob PR, make smaller PRs with specific changes that can easily be reviewed, instead.
