2017-11-03, 13:55
(2017-11-03, 13:47)Glottis Wrote:(2017-11-03, 11:54)axlt2002 Wrote: @dziobak: if the issue is related to DNS settings (so not dependent on the add-on), do you think we still need to include the modifications introduced in patch1 and patch2 or not?
If you'd ask me, the patches are welcome because they stop the add-on from freezing. It can't be wrong to handle an exception even though the add-on code does not cause that error. In my case I could check the logs after the progress finishes and trace back the problems, but I'm not forced to restart Kodi every time I use the add-on. That's why I say keep the patches if they don't introduce any drawbacks.
---
Here are two new things. The first one isn't a bug but more of a feature request:
1) I've got a lot of the older The Simpsons episodes (Season 1 - 6 for example). The seasons are locked at thetvdb.com and do not feature IMDB IDs. Would it make sense to search for original title on IMDB and on >95% match get that IMDB ID and save it?
2) I use thetvdb for most of my tv series, but some (especially documentary series) get their information from themoviedb. (example: https://www.themoviedb.org/tv/1044-plane...uage=en-US)
As soon as the add-on reaches aforementioned episodes I get 8 of the following errors and it freezes. (one error for each thread I think)
Code:03:04:59.680 T:544823046368 ERROR: Unhandled exception in thread started by
03:04:59.680 T:544823046368 ERROR: <function thread_parse_IMDb_page at 0x7ef8156b90>
03:04:59.680 T:544823046368 ERROR: Traceback (most recent call last):
03:04:59.680 T:544823046368 ERROR: File "/storage/.kodi/addons/script.light.imdb.ratings.update/resources/core/update_main.py", line 43, in thread_parse_IMDb_page
03:04:59.680 T:544823046368 ERROR: statusLog( Title + ": " + statusInfo )
03:04:59.680 T:544823046368 ERROR: TypeError
03:04:59.681 T:544823046368 ERROR: :
03:04:59.681 T:544823046368 ERROR: coercing to Unicode: need string or buffer, NoneType found
Quick answer to 1): In the upcoming 3.3.0 release it will be possible to set the missing IMDb/TVDB IDs through the context menus. I'm not so much in favour to add the search by "original title" (it would just add new level of possible errors, not all the users may have the "original title" info, it should match exactly the original title on IMDb site, it will prompt the user to confirm the match and I prefer a more transpartent behaviour of the add-on, etc.)
For 2)...we have to look into it.
Alex