Solved Issue - Mark as watched/Mark as unwatched issue outside of library

  Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Post Reply
ksooo Offline
Team-Kodi Member
Posts: 900
Joined: Jan 2015
Reputation: 47
Location: Hamburg, Germany
Post: #31
(2017-09-11 17:28)Razze Wrote:  
(2017-09-11 13:19)ksooo Wrote:  
(2017-09-11 13:12)Razze Wrote:  I think we can fix this via the same thing I we now do for reseting resume points. We need to do the call to update the gui probably best done near the database change request.


No, this is completely different. It's not at all about notifying changes. We have no clue how to identify the right folders as obviously not all folders should get the context menu items in question. That's the actual problem.

Okay, but not so sure about that. That would mean that the availability of resume points is also not correct and should not be handled by estuary like that?
I somehow still think, it might be two bugs crossing each others path. But that's just a feeling, can't say anything concrete and you seem to have looked at it, so you're probably right Smile


No, these are two completely unrelated stories. The problem discussed here is solely about the visibility condition for mark watched / unwatched.

And I do absolutely not get what Estuary should have to do with that. Core context menu items are 100% coded in c++, no skin xml involved.
(This post was last modified: 2017-09-11 17:33 by ksooo.)
find quote
Razze Offline
Team-Kodi Member
Posts: 1,640
Joined: Jan 2015
Reputation: 51
Location: Osnabrück, Germany
Post: #32
(2017-09-11 17:33)ksooo Wrote:  
(2017-09-11 17:28)Razze Wrote:  
(2017-09-11 13:19)ksooo Wrote:  No, this is completely different. It's not at all about notifying changes. We have no clue how to identify the right folders as obviously not all folders should get the context menu items in question. That's the actual problem.

Okay, but not so sure about that. That would mean that the availability of resume points is also not correct and should not be handled by estuary like that?
I somehow still think, it might be two bugs crossing each others path. But that's just a feeling, can't say anything concrete and you seem to have looked at it, so you're probably right Smile


No, these are two completely unrelated stories. The problem discussed here is solely about the visibility condition for mark watched / unwatched.

And I do absolutely not get what Estuary should have to do with that. Core context menu items are 100% coded in c++, no skin xml involved.

Correct, but I would think that the visible conditions in the c++ context menu are off for this case and that we don't refresh the ui correctly.
See:

(2017-06-18 23:53)Gracus Wrote:  I then try to use the context menu and select "mark as watched" but the file still appear as "in progress":
[Image: 170619120648557090.png]
find quote
ksooo Offline
Team-Kodi Member
Posts: 900
Joined: Jan 2015
Reputation: 47
Location: Hamburg, Germany
Post: #33
(2017-09-12 00:40)Razze Wrote:  
(2017-09-11 17:33)ksooo Wrote:  
(2017-09-11 17:28)Razze Wrote:  Okay, but not so sure about that. That would mean that the availability of resume points is also not correct and should not be handled by estuary like that?
I somehow still think, it might be two bugs crossing each others path. But that's just a feeling, can't say anything concrete and you seem to have looked at it, so you're probably right Smile


No, these are two completely unrelated stories. The problem discussed here is solely about the visibility condition for mark watched / unwatched.

And I do absolutely not get what Estuary should have to do with that. Core context menu items are 100% coded in c++, no skin xml involved.

Correct, but I would think that the visible conditions in the c++ context menu are off for this case and that we don't refresh the ui correctly.
See:

(2017-06-18 23:53)Gracus Wrote:  I then try to use the context menu and select "mark as watched" but the file still appear as "in progress":
[Image: 170619120648557090.png]


@Razze may I suggest to concentrate on fixing the "visibility" bug first. Mixing unrelated problems together only increases complexity and makes people not talking straight to the point and increases chances for not understanding each other. ;-)
find quote
Razze Offline
Team-Kodi Member
Posts: 1,640
Joined: Jan 2015
Reputation: 51
Location: Osnabrück, Germany
Post: #34
So "Mark as watched" does not work because "ClearBookmark" get's called with an empty path variable here https://github.com/xbmc/xbmc/blob/8ddffa...ob.cpp#L99

Because we think we have a VideoInfoTag here: https://github.com/xbmc/xbmc/blob/8ddffa...ob.cpp#L96 and overwrite the valid path with an empty one. VideoInfoTag is not nullptr like it should be and seems to only have resume populated.

I don't think there is a visibility bug as far as I can tell now. It's just that played count get's changed but the bookmarks not.
(This post was last modified: 2017-09-13 01:28 by Razze.)
find quote
ksooo Offline
Team-Kodi Member
Posts: 900
Joined: Jan 2015
Reputation: 47
Location: Hamburg, Germany
Post: #35
(2017-09-13 01:17)Razze Wrote:  So "Mark as watched" does not work because "ClearBookmark" get's called with an empty path variable here https://github.com/xbmc/xbmc/blob/8ddffa...ob.cpp#L99

Because we think we have a VideoInfoTag here: https://github.com/xbmc/xbmc/blob/8ddffa...ob.cpp#L96 and overwrite the valid path with an empty one. VideoInfoTag is not nullptr like it should be and seems to only have resume populated.

I don't think there is a visibility bug as far as I can tell now. It's just that played count get's changed but the bookmarks not.


Sorry, we're talking about different things. Don't know how to explain it with better words. I'm out.
find quote
ksooo Offline
Team-Kodi Member
Posts: 900
Joined: Jan 2015
Reputation: 47
Location: Hamburg, Germany
Post: #36
By reading the OP I just realized that I mixed up threads here and I was talking all the time about an issue reported in another thread.

I do very sorry for the confusion I might have caused.

So yeah @Razze your are probably completely right with what you're writing here.
(This post was last modified: 2017-09-13 08:32 by ksooo.)
find quote
Gracus Offline
Moanbag
Posts: 1,397
Joined: Jun 2016
Reputation: 49
Location: Saint-Brieuc, France
Post: #37
Big Thanks to Razze!

His fix has finally been merged and all works perfectly now

Moanbag is in da place!
find quote
Post Reply