Thread Rating:
  • 0 Vote(s) - 0 Average
Wackiness with updated addon settings dialog
#1
Just installed the latest nightly and made the changes to the addon settings dialog as described in the "Changes to the skinning engine..." thread. https://forum.kodi.tv/showthread.php?tid...pid2603091

Noticed a few strange things that weren't present when using the previous control IDs. I have a scrollbar on the grouplist that is now id 5. It doesn't seem to honor the showonepage=false setting though, and is always displayed. And it doesn't seem to be measuring the correct number of items until it is focused. I tried changing the scrollbar id, but it still had the same issues.

The other thing is that I used to display the addon thumbnail in the settings dialog using the following code:
Code:
$INFO[Window.Property(Addon.ID),special://home/addons/,/icon.png]

This no longer works though, the image isn't displayed. Is this property still available in the addon settings dialog?

Here's my DialogAddonSettings.xml: https://github.com/braz96/skin.omni/comm...e566b0761c

Thanks for any suggestions!
Reply
#2
Thanks for your report. Please see PR12314 for a fix.
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#3
(2017-06-17, 14:39)Montellese Wrote: Thanks for your report. Please see PR12314 for a fix.
Thanks Montellese, will test when there's a Windows build available!
Reply
#4
Watch the test-builds folder for "addon_settings_fallout_3" in about 2 hours
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
#5
Will the scrollbar issue described above be fixed in the new build? I just realized that the addon settings dialog isn't the only one affected. It seems like scrollbars are not working properly for any grouplist that reuses the same ID, including the one in SettingsCategory.xml. Here's a screenshot from Estuary that illustrates the issue. The list only has a few items, but the scrollbar always shows and can be focused.

I can report on trac or a new thread if this is a bigger issue.

Image
Reply
#6
I only fixed tha Addon.ID issue because my knowledge of the GUI library is not good enough to fix the scrollbar issue.
Always read the online manual (wiki), FAQ (wiki) and search the forum before posting.
Do not e-mail Team Kodi members directly asking for support. Read/follow the forum rules (wiki).
Please read the pages on troubleshooting (wiki) and bug reporting (wiki) before reporting issues.
Reply
#7
(2017-06-17, 18:49)Montellese Wrote: I only fixed tha Addon.ID issue because my knowledge of the GUI library is not good enough to fix the scrollbar issue.
No problem, bug report submitted on Trac. https://trac.kodi.tv/ticket/17504
Reply
#8
Confirm this issue and another strange issue with Skin Settings, size of scrollbar does not match with size of list when scrollbar is not focused :

Before focus, not correct :

Image


When focus, ok :

Image
 Estuary MOD V2 
Reply
#9
(2017-06-17, 17:21)Martijn Wrote: Watch the test-builds folder for "addon_settings_fallout_3" in about 2 hours
I couldn't find this test build, but I can confirm that the Addon.ID property is now available in the addon settings dialog when using the latest nightly.
Reply
#10
I have confirmed that this isn't the cause of the grouplist problems; it is PR 12213 instead.

https://github.com/xbmc/xbmc/pull/12213#...-312435368
Reply
#11
Confirmed fixed with this commit -

https://github.com/xbmc/xbmc/pull/12424
Reply
 
Thread Rating:
  • 0 Vote(s) - 0 Average



Logout Mark Read Team Forum Stats Members Help
Wackiness with updated addon settings dialog00