2017-10-24, 14:33
About 10 months ago someone pointed out a typographical error in customcontroller.harmony.xml.
https://forum.kodi.tv/showthread.php?tid=304719
It's still there and I found other possible errors. I would make edits on github but don't know how, sorry. Here is a list with line numbers.
42 <!-- minus --> <button id="102">Down</button>
Although it's just a comment, 'minus' should probably be 'down'.
47 <!-- hold play --> <button id="107">Fullscreen</button>
I don't know if action names are case sensitive, but elsewhere it is 'FullScreen'.
108 <!-- Yellow --> <button id="185">xbmc.ActivateWindow(SystemSettings)</button>
Should 'xbmc.' be dropped?
114 <!-- menu --> <button id="16">ActivateWindow(PlayerControls)</button>
Button id should be 106
There are quite a few button assignments that are the same between Global and other windows. If I understand correctly, they don't need to be specified in other windows if they are Global. Not an error really, but .... Some example lines are 157, 196, 231, 304-314.
In FullScreenVideo, lines 158-159, those actions are already available in Global, but through different buttons (F10 and F11).
The section ScreenCalibration, lines 235-242, is duplicated in lines 243-249, except that one button is missing in the copy (button id 165).
https://forum.kodi.tv/showthread.php?tid=304719
It's still there and I found other possible errors. I would make edits on github but don't know how, sorry. Here is a list with line numbers.
42 <!-- minus --> <button id="102">Down</button>
Although it's just a comment, 'minus' should probably be 'down'.
47 <!-- hold play --> <button id="107">Fullscreen</button>
I don't know if action names are case sensitive, but elsewhere it is 'FullScreen'.
108 <!-- Yellow --> <button id="185">xbmc.ActivateWindow(SystemSettings)</button>
Should 'xbmc.' be dropped?
114 <!-- menu --> <button id="16">ActivateWindow(PlayerControls)</button>
Button id should be 106
There are quite a few button assignments that are the same between Global and other windows. If I understand correctly, they don't need to be specified in other windows if they are Global. Not an error really, but .... Some example lines are 157, 196, 231, 304-314.
In FullScreenVideo, lines 158-159, those actions are already available in Global, but through different buttons (F10 and F11).
The section ScreenCalibration, lines 235-242, is duplicated in lines 243-249, except that one button is missing in the copy (button id 165).