[belltechdave]

Just wondering if the iOS arm64 nightlies will incorporate the new iPhone X display as Kodi doesn't seem to be taking full advantage of the screen.  I believe this only requires a change to a few (if not one) of the files.

[quayrd]

Yes, it would be great if a widescreen movie would go edge to edge on this phone.

[Memphiz]

As far as i am concerned i did that already here: https://github.com/xbmc/xbmc/commit/8ffa...1f640592ea mot sure what else is needed. I thought iphone x uses screen scale 3 doesn't it?

[quayrd]

As far as i am concerned i did that already here: https://github.com/xbmc/xbmc/commit/8ffa...1f640592ea mot sure what else is needed. I thought iphone x uses screen scale 3 doesn't it?

This is what i see on the screen:

[Memphiz]

Please post a debug log (wiki)

[Memphiz]

No wait - 2001x1125 is 16:9 - there is no way to make kodi any bigger on that screen without stretching or loosing pixeldata. I think i have already done it right and this is apples safe area which our app won't exceed because we need either 16:9 or 4:3 aspect ratio.

[belltechdave]

Portrait dimensions
1125px × 2436px (375pt × 812pt @3x)

Landscape dimensions
2436px × 1125px (812pt × 375pt @3x)

[quayrd]

No wait - 2001x1125 is 16:9 - there is no way to make kodi any bigger on that screen without stretching or loosing pixeldata. I think i have already done it right and this is apples safe area which our app won't exceed because we need either 16:9 or 4:3 aspect ratio.

Is it not possible to override the aspect ratio limitation (or some other limitation) just for the video player?

[Memphiz]

Not that I know of - maybe set it to zoom in video settings during playback? How should we fill the screen in your opinion? We would either cut of pixels or stretch the view which both would result in incorrect video views ...

How does playing a 16:9 YouTube video in the YouTube app look?

[quayrd]

Not that I know of - maybe set it to zoom in video settings during playback? How should we fill the screen in your opinion? We would either cut of pixels or stretch the view which both would result in incorrect video views ...

How does playing a 16:9 YouTube video in the YouTube app look?

I am not talking about 16:9 content. Even in the updated youtube app, 16:9 does not fill up side to side on the iphone x.

I am talking more about wide screen movies. Which are wider than 16:9. For example, the typical resolution I have seen on 1080p movies is 1920x800 pixels which comes to 2.4:1 aspect ration (16:9 comes to 1.78:1). For those movies, there is no need to cut pixels at the top and bottom or stretch the sides. The video can fill from side to side.

The second image that i had posted above shows a snapshot from such a video.

Thanks.

[Memphiz]

Try "zoom" then? Just play with the different video views and tell me of any of them draws to the right/left black bars you see ...

[belltechdave]

Using the Zoom or video calibration settings doesn’t have any effect on the window constraints of the app on the iPhone X display. I did read somewhere that all that’s required is a change to a specific device or image type file or something like that to get the apps to properly take advantage of the iPhone X display. This includes having the app accommodation for the “notch” as well. I’ll try to find the reference and post it here. Thank you

[markus3000]

Try "zoom" then? Just play with the different video views and tell me of any of them draws to the right/left black bars you see ...

To better explain... 16:9 content like in the apps of "youtube" have a couple options.   you can play video in 16:9 which would leave the video intact filling the height of the video within the height of the iphone and leaving black bars on the side,,, and then there's a zoom mode which takes advantage of the wider iphone x screen. In essence what it does is slightly cut off the top and bottom of the video to take advantage of the wider iphone x display. Since the iphone x is not a true 16:9 like say an iphone 7 and more like maybe 20:9, cutting off the top and bottom allows more of the phones screen to be used. It looks pretty good to be honest. When it comes to 2.35:1 content like wide screen movies most films will play thru the full width of the screen. or zoomed to take full width and height of the screen.

So right now the way the app is set up it thinks the iphone x is a iphone 7 style phone and only display the whole app in 16:9. xcode allows for some conversion as I am sure you know,  I have done so with another app but I am a rookie with this stuff...

Also the swipe up tab bar does not go away and plays during a movie, its a long line that indicates you can swipe up from there, on most apps it just fades way eventually

[quayrd]

The developers must have solved the same issue on the samsung S8 phone? Assuming they are able to use the entire width of the phone.

[manhas]

I might've misunderstood what changes have been made to add iPhone X support. But for the iPhone X to run the app with the full resolution a launch image with the resolution 1125×2436 (812h@3x) need to be added, otherwise the screen will be cropped down to 667px height when running the app.

Browsing through the image resources in the latest iOS nightly (Nov 11) I don't see any launch image with this resolution.