Thread Rating:
  • 0 Vote(s) - 0 Average
Work in Progress - unused code - make dvd autorun ignoreplaying configurable or remove it completely
#1
Question 
I would be nice to have Optical Disc autoplay during TV playback because it does take a while until an optical drive recognize autoplayable media.

This Feature is already implemented:
https://github.com/xbmc/xbmc/blob/04bdaa...orun.h#L68
https://github.com/xbmc/xbmc/blob/8ddffa...un.cpp#L71

but it's just disabled by default.

If you don't like this feature we should remove this unused code. But would be nice to have it. For example if you listen music, the music could still play while the optical drive is checking the disc.
Reply
#2
What do you think about it? I could implement it by my or remove it by my self but I just want to know which direction is wanted.
Reply
#3
i can't see why anybody would not want the behavior you describe. but i fear there's a reason why it is disabled. have you tried enabling the code and seen what happens?
Reply
#4
No, I didn't try it. I did just to ask for a secound mind because I don't want to do spend time into unwanted behaivors.

But as you don't see any obvious disadvantages I will enable it and test it a little bit. Thanks for your reply.
Reply
#5
It does work very well. I did test PVR Client and Streams and Fileshare Videos.

Would be a setting in advancedsettings.xml enoght with default value true?
Reply
#6
Imo it could just be changed permanently but there are always the possibility somebody do not agree so yeah add adv, flip default behavior.
Reply
#7
Sorry but I'm against adding anything to advancedsettings.xml if it's send to our github.
It either needs to be fixed or whatever or made a gui option as last resort
Read/follow the forum rules.
For troubleshooting and bug reporting, read this first
Interested in seeing some YouTube videos about Kodi? Go here and subscribe
Reply
#8
(2017-12-06, 20:01)Martijn Wrote: Sorry but I'm against adding anything to advancedsettings.xml if it's send to our github.
It either needs to be fixed or whatever or made a gui option as last resort
 So I did it: https://github.com/xbmc/xbmc/pull/13142 just a breaking change.
Reply
#9
It's still nobody there to have a look on this change.
Reply
 
Thread Rating:
  • 0 Vote(s) - 0 Average



Logout Mark Read Team Forum Stats Members Help
unused code - make dvd autorun ignoreplaying configurable or remove it completely00