Posts: 1,332
Joined: Jan 2016
Reputation:
54
You are correct they should be placed in the root of the extras folder if the are normal videos...mp4 mkv iso etc... Only if it is bonus disc in folder format will it be recognized....
Example
Star wars empire strike back bonus disc/bdmv/index.bdmv
Or video_ts/video_ts.ifo
Hopefully that makes sense.
Posts: 7,915
Joined: Feb 2013
Reputation:
1,537
Ok, it is working well so far.
Couple of things:
- When opening the special features there is a pop dialog showing some info. I assume this is for debugging purposes, but it would be nice to be able to disable this (and should be disabled by default).
- When launching special features from the video info dialog of a tvshow, the Container.Content is set to tvshows rather than videos. It needs to be set to videos for the correct viewtypes to be available.
- Also, for official repo, you will need to change your window properties to be prefixed with the plugin name (see SkinHelper properties for e.g.)
e.g. something like Window(Home).Property(SpecialFeatures.HasContent) would be ideal
EDIT: Another thing I noticed. When I launch it from video info dialog, I need to close the dialog first (which is fine). However, when I press back from special features, I end up on the home screen instead of in the library.
Posts: 1,332
Joined: Jan 2016
Reputation:
54
Well you have found 80 percent of the issuses... the info pop up is a piece of code that got left over when I last updated. The window property I can fix fairly easy. You are right with having to close the info dialog first. and the returning to home I have yet to figure out why.. that's why I was hoping to get the thumbnails to show up in the widget/path but for me I have yet to get the extractor to work. and last I was using estuary views to define the content type so the content is set for it to show the way I intended in estuary. not to say something didn't slip through. I will try to get back around to it soon.. been a busy week and its just starting.
Posts: 1,332
Joined: Jan 2016
Reputation:
54
Totally understandable will be fixed for the next update. Just wanted to be sure before changing everything.
Posts: 1,332
Joined: Jan 2016
Reputation:
54
Alright I think all the issues are fixed now and have updated release. If you do find any please open a ticket to get it resolved.
Posts: 1,332
Joined: Jan 2016
Reputation:
54
Last update for today I hope everything is working after this as there has be a lot of changes on the code side.
IMPORTANT
Before updating to the newest release I highly recommend uninstalling the current version you have... I have changed the name to match the official repo and it will cause a conflict if leaving older versions installed so please you your self a favor and uninstall first.
With that out that being said I am going to let this ride another week or so and then if nothing else changes I will be submitting into the official repo... so please anyone and everyone test it out and report back.