•   
  • 1
  • 8
  • 9
  • 10(current)
  • 11
  • 12
  • 14
  •   
Important Skinners: Please test PR13754
Xperience1080 is also broken. It seems it cannot load/save it's own config. 

Everything is reset to default and you cannot assign anything to the widgets.
Reply
(2018-06-04, 18:48)pizzaboy Wrote: Xperience1080 is also broken. It seems it cannot load/save it's own config. 

Everything is reset to default and you cannot assign anything to the widgets.


I doubt that this is related to changes discussed in this thread.
Reply
Yes, it could be that it's not related.

The problem started with KodiSetup-20180603-dba439f5-master-x64.exe (20180602 is fine) and looking through the commits, yours was the only one skin related, so i assumed this might be the culprit.

Edit: Looking through the commits again, i have to say, yours are really the only ones remotely related! Are you sure this has nothing to do with your changes?
Reply
(2018-06-04, 20:16)pizzaboy Wrote: Yes, it could be that it's not related.

The problem started with KodiSetup-20180603-dba439f5-master-x64.exe (20180602 is fine) and looking through the commits, yours was the only one skin related, so i assumed this might be the culprit.

Edit: Looking through the commits again, i have to say, yours are really the only ones remotely related! Are you sure this has nothing to do with your changes?

One never can be 100% sure, but with the information you gave and looking at what I changed I'd say I'm not to blame for the problem.
Reply
AEON MQ is also totally broken. The skin can't load, it's always in the initialization stage. I have to modify the guisettings.xml to make Kodi works. When I revert to 06/02 build, every settings/customization of the skin is missing. I think the issue is due the the PR https://github.com/xbmc/xbmc/pull/13970/files.
Reply
(2018-06-04, 18:04)ksooo Wrote: Could you please try to be more specific. Otherwise I have no chance to analyse/fix the problem.

What exactly broke, which labels/conditions do not work anymore?

The milhouse build you mentioned does not even contain the fix for skin.string condition! It was first introduced with milhouse build 603...

@ksooo I did actually include PR13970 in #0602:

(2018-06-03, 00:24)Milhouse Wrote: Build Details:
  1. Additional commits/pull requests/changes not yet merged upstream:
    • Added: [pkg] PR:13970 (perma): [guiinfo] Fix: 'Skin.String(string1, string2)' did not work if string2 was empty.
Texture Cache Maintenance Utility: Preload your texture cache for optimal UI performance. Remotely manage media libraries. Purge unused artwork to free up space. Find missing media. Configurable QA check to highlight metadata issues. Aid in diagnosis of library and cache related problems.
Reply
Confirming 13970 (PR) as cause for latest skin issues. Working on a fix.
Reply
@xodi @pizzaboy @Aenima99x @Angelinas @Gade ... could you give test build

win32: http://mirrors.kodi.tv/test-builds/windo...70-x86.exe
win64: http://mirrors.kodi.tv/test-builds/windo...70-x64.exe

a try and report back? These builds are supposed to fix the issues you reported.

Thanks.

@Milhouse you may want to include https://github.com/ksooo/xbmc/commit/3c3...8e59030c42 in your next build.
Reply
@ksooo
forbiden access or wrong path...can't download for x86.exe

Edit:Now is ok....downloading
XBoxMediaCenter (Kodi Leia) 18.0 , LibreElec RasPi3 Libreelec-Leia Skin AeonMQ6
Reply
the revert pr-13970 test build winx64 is there but not fix pr13970 build.

I see that in nightly even $INFO[skin.string(*)] returns nothing as well as String.IsEqual and Integer.IsEqual fail on skin.string.

update:  OK got the fix pr13970 build and now the above problems are fixed.

scott s.
.
maintainer of skin  Aeon MQ5 mods for post-Gotham Kodi releases:
Krypton
Leia
Reply
I can confirm that with your Test-Build everything works now!
Reply
I can confirm too, all working and this code is fixed.

If is empty "string1" showing "true"....Smile
Code:
Skin.String(string1,)

You can include this fix for
13970 (PR)

Tnx
XBoxMediaCenter (Kodi Leia) 18.0 , LibreElec RasPi3 Libreelec-Leia Skin AeonMQ6
Reply
13981 (PR) => merged. Fix will be contained in next nightly build.
Reply
It looks like Slideshow.Filename and Slideshow.Path no longer work in slideshow window (working in Alpha 1).  However, I tested one of the EXIF related ones (Slideshow.CameraMake) and that one is working.   I'm not sure if the IPTC ones work (didn't seem to work in Alpha 1either but it may be my jpg test files aren't coded correctly).

scott s.
.
maintainer of skin  Aeon MQ5 mods for post-Gotham Kodi releases:
Krypton
Leia
Reply
(2018-07-02, 06:45)scott967 Wrote: It looks like Slideshow.Filename and Slideshow.Path no longer work in slideshow window (working in Alpha 1).  However, I tested one of the EXIF related ones (Slideshow.CameraMake) and that one is working.   I'm not sure if the IPTC ones work (didn't seem to work in Alpha 1either but it may be my jpg test files aren't coded correctly).

scott s.
.
Should be fixed with 14191 (PR)
Reply
  •   
  • 1
  • 8
  • 9
  • 10(current)
  • 11
  • 12
  • 14
  •   
 
Thread Rating:
  • 0 Vote(s) - 0 Average



Logout Mark Read Team Forum Stats Members Help
Skinners: Please test PR1375400