•   
  • 1
  • 2
  • 3
  • 4(current)
  • 5
  • 6
  • 13
  •   
Important -  Skinners: Please test PR13754
#46
@ksooo 

Nope, same issue on the previous one.

Edit:
If you need a scenario to reproduce it just install the Leia version of Embuary (https://github.com/sualfred/skin.embuary) and go to settings -> system and open the dialog to switch the resolution. You will see the issue on the first item in this menu.
Reply
#47
(2018-04-13, 15:13)sualfred Wrote: @ksooo 

Nope, same issue on the previous one.

Edit:
If you need a scenario to reproduce it just install the Leia version of Embuary (https://github.com/sualfred/skin.embuary) and go to settings -> system and open the dialog to switch the resolution. You will see the issue on the first item in this menu.
Cannot install, all kind of dependency errors. :-(
Reply
#48
New (hopefully the last before merge) test builds available:

Windows:
http://mirrors.xbmc.org/test-builds/wind...ce-x64.exe

OSX:
http://mirrors.xbmc.org/test-builds/osx/...x86_64.dmg

Following issues should be fixed:
* issue reported by @mikeSiLVO
* maybe also the issue reported by @sualfred

It would be nice if the issue reporters could retest and report back. Thanks.

Are there any other open issues?  I'm not aware of any and if there are no objections I plan to merge the PR this weekend.
Reply
#49
@ksooo 

Nope, not solved.

Just delete the dependencies right out of the addon.xml. They are not required for this test.

Edit:

Video of the bug




And in the end of the video you will also see a animation glitch for a fixedlist container where the defaultcontrol is "0".
This is how the window openening looks like in Krypton



Reply
#50
(2018-04-13, 16:40)sualfred Wrote: @ksooo 

Nope, not solved.

Just delete the dependencies right out of the addon.xml. They are not required for this test.

Edit:

Video of the bug




And in the end of the video you will also see a animation glitch for a fixedlist container where the defaultcontrol is "0".
This is how the window openening looks like in Krypton





Have you checked that this works fine on latest Kodi Leia master?
Reply
#51
@sualfred that animation glitch has been around for a long time in Leia.

v18 -  Container Scroll's when opening dialog or window - Scroll/Focused Item Bug?

This PR was meant to fix it but didn't.
Reply
#52
@Hitcher @ksooo 
You are right. This animation glitch also happens in Master.

But I found another one (in this testbuilds, works on master)
Code:
<animation type="Focus" reversible="false" condition="!Skin.HasSetting(MinimalFocusAnimation) + [Container(102).OnNext | Container(102).OnPrevious]">
            <effect type="zoom" end="110" time="75" tween="sine" easing="out" center="auto" />
            <effect type="zoom" end="90.9090909" time="225" tween="sine" delay="100" easing="out" center="auto" />
        </animation>

This focus animation is going to be triggered even if the control is not moving.
Reply
#53
(2018-04-13, 17:30)sualfred Wrote: @Hitcher @ksooo 
You are right. This animation glitch also happens in Master.

But I found another one (in this testbuilds, works on master)
Code:
<animation type="Focus" reversible="false" condition="!Skin.HasSetting(MinimalFocusAnimation) + [Container(102).OnNext | Container(102).OnPrevious]">
            <effect type="zoom" end="110" time="75" tween="sine" easing="out" center="auto" />
            <effect type="zoom" end="90.9090909" time="225" tween="sine" delay="100" easing="out" center="auto" />
        </animation>

This focus animation is going to be triggered even if the control is not moving.


Sorry guys, please keep focused and describe exactly what does not work and how to reproduce as a user. At the moment I have no idea what to fix. I will only take care about regressions introduced by my PR in comparison to latest Leia master.
Reply
#54
Sorry for the confusion. Just ignore the animation glitch of the shutdown menu. The other ones were introduced with your PR (focus animation condition and listitemposition(0))

And as I said you can reproduce it in Embuary.
- listitemposition -> open the GUI resolution menu 
- Container(id).OnNext Container(id).OnPrevious are returning true. This causes a unwanted focus animation -> To reproduce just go to the system settings and press back to return to settings.xml and take a look at the first blue item in the system section.

Broken




Working


Reply
#55
Here's an issue that occurs in the 20180413-0bdf70ba build, but not any of the nightly builds from master. The problem in jurialmunkey's Aura skin is that the first item of the menu inherits the currently focused item's label and state as you navigate the main menu. In the screenshot below, the first item should be Movies, but it changed to Settings when I navigated to that item.

Can't really give you steps/code to recreate the issue, Aura uses script.skinshortcuts so this might affect other skins too. Maybe jurialmunkey can shed some light on the specific code causing this.

Image
Reply
#56
(2018-04-13, 22:40)braz Wrote: Here's an issue that occurs in the 20180413-0bdf70ba build, but not any of the nightly builds from master. The problem in jurialmunkey's Aura skin is that the first item of the menu inherits the currently focused item's label and state as you navigate the main menu. In the screenshot below, the first item should be Movies, but it changed to Settings when I navigated to that item.

Can't really give you steps/code to recreate the issue, Aura uses script.skinshortcuts so this might affect other skins too. Maybe jurialmunkey can shed some light on the specific code causing this.

 Thanks for reporting this. I'm pretty sure this issue has the same root cause as the "wrong labels in display resolution setting list" reported by @sualfred
Reply
#57
(2018-04-13, 22:40)braz Wrote: Aura uses script.skinshortcuts so this might affect other skins too. Maybe jurialmunkey can shed some light on the specific code causing this.

It wouldn't be to do with skinshortcuts, because that just generates static <items> for <content> tags.

I use a fake list with static content and then display that content using button controls in a grouplist.
The button controls grab the info from the list using ListItemAbsolute:

Code:
<label>$INFO[Container($PARAM[id]).ListItemAbsolute($PARAM[pos]).Label]</label>
Reply
#58
Similar issue as mine. So it's broken for ListItemAbsolute(0) and ListItemPosition(0).
Reply
#59
(2018-04-14, 07:20)sualfred Wrote: Similar issue as mine. So it's broken for ListItemAbsolute(0) and ListItemPosition(0).


What I said.
Reply
#60
New (hopefully really the last before merge) test builds available:

Windows:
http://mirrors.kodi.tv/test-builds/windo...ce-x64.exe

OSX:
http://mirrors.kodi.tv/test-builds/osx/x...x86_64.dmg

Following issues should be fixed:
* animation glitch due to Container(id).OnNext andd Container(id).OnPrevious erroneously returning true : reported by @sualfred 
* display resolution settings list (and others) containing wrong entries: reported by @sualfred and @braz 

It would be nice if the issue reporters could retest and report back. Thanks.

Are there any other open issues?  I'm not aware of any and if there are no objections I plan to merge the PR this weekend.
Reply
  •   
  • 1
  • 2
  • 3
  • 4(current)
  • 5
  • 6
  • 13
  •   
 
Thread Rating:
  • 0 Vote(s) - 0 Average



Logout Mark Read Team Forum Stats Members Help
Skinners: Please test PR1375400