[sualfred]

Works, thanks. Both issues are fixed.

[Milhouse]

I've just built LibreELEC for RPi2 now that LIRC is (mostly) fixed.

I navigated to Favourites in stock Estuary, and I'm getting this log - notice the repeating errors at the end: http://ix.io/17Jq

Edit: Ah, just realised this is with PR13754 as it is in @popcornmix's newclock5 branch so any recent updates to PR13754 may not be in newclock5.

[ksooo]

I've just built LibreELEC for RPi2 now that LIRC is (mostly) fixed.

I navigated to Favourites in stock Estuary, and I'm getting this log - notice the repeating errors at the end: http://ix.io/17Jq

Edit: Ah, just realised this is with PR13754 as it is in @popcornmix's newclock5 branch so any recent updates to PR13754 may not be in newclock5.

 Yep, the ERRORs are definitely caused by an outdated revision of PR13754. Should all be fixed with latest code.

[Mr. V]

I am having some issues with Skin.String Boolean.

Code:

Skin.String(string1,string2)

If string1 is set, it will always return 'true' regardless of what value string2 has.

Code:

String.IsEqual(Skin.String(string1),string2)

Is working ok.

[ksooo]

I am having some issues with Skin.String Boolean.

Code:

Skin.String(string1,string2)

If string1 is set, it will always return 'true' regardless of what value string2 has.

Can you please test that this does work in latest kodi Leia master build?

EDIT: I already found the problem. Yep, it's a regression I've introduced. Will be fixed with next test build.

[ksooo]

New (hopefully really really the last before merge) test builds available:

Windows:
http://mirrors.kodi.tv/test-builds/windo...ce-x64.exe

OSX:
http://mirrors.kodi.tv/test-builds/osx/x...x86_64.dmg

Following issues should be fixed:
* Skin.String(string1, string2) not working : reported by @Mr. V  

It would be nice if the issue reporters could retest and report back. Thanks.

Are there any other open issues?  I'm not aware of any and if there are no objections I plan to merge the PR this weekend.

[Mr. V]

Working now.

Cheers

[ksooo]

I just merged the PR. Thanks for your support, guys.

[mikeSiLVO]

Awesome!

Thanks @ksooo!

[sualfred]

@ksooo

Sorry mate, found another one in the pvr guide.

Code:

<itemlayout height="83" width="60">
                        <control type="image" id="2">
                            <height>83</height>
                            <texture colordiffuse="grid_label_inprogress">common/white.jpg</texture>
                            <visible>Integer.IsGreater(ListItem.Progress,0) + Integer.IsLess(ListItem.Progress,100)</visible>
                        </control>
...

ListItem.Progress uses the value of the focused item instead of the listitem.
Easy to reproduce in Embuary if you walk through the guide.

Working in master:


Broken in your builds:

[ksooo]

@ksooo

Sorry mate, found another one in the pvr guide.

Code:

<itemlayout height="83" width="60">
                        <control type="image" id="2">
                            <height>83</height>
                            <texture colordiffuse="grid_label_inprogress">common/white.jpg</texture>
                            <visible>Integer.IsGreater(ListItem.Progress,0) + Integer.IsLess(ListItem.Progress,100)</visible>
                        </control>
...

ListItem.Progress uses the value of the focused item instead of the listitem.
Easy to reproduce in Embuary if you walk through the guide. 

 Thanks for letting me know. I found the problem and will open a PR for the fix.

EDIT: https://github.com/xbmc/xbmc/pull/13772

[MarcosQui]

Hello everyone. I see a problem in the DialogVideoInfo window.
In the $INFO[Container.ListItem.Label] expression the answer is blank, no data.
Works properly on older builds.
This error occurs in 32-bit and 64-bit versions.

[ksooo]

Hello everyone. I see a problem in the DialogVideoInfo window.
In the $INFO[Container.ListItem.Label] expression the answer is blank, no data.
Works properly on older builds.
This error occurs in 32-bit and 64-bit versions.

which build do you use exactly?

[sualfred]

Works on my end with the nightly of today.

[MarcosQui]

Hello everyone. I see a problem in the DialogVideoInfo window.
In the $INFO[Container.ListItem.Label] expression the answer is blank, no data.
Works properly on older builds.
This error occurs in 32-bit and 64-bit versions.

which build do you use exactly?  

 In the build of April 16 does not work - KodiSetup-20180415-d23e30ed-master-x86 / KodiSetup-20180415-d23e30ed-master-x64
Already in the build on April 5th works perfectly - KodiSetup-20180405-c691ac1d-master-x86

I have not tested with other builds yet.

Ps. I only see the problem if I use the generic container (without id). If I specify the container, such as $INFO[Container(x).ListItem.Label] then it works.