[ksooo]

ListItem.Rating(foo)
Now is fixed, I confirm the fix working and resultat for rating work as should.

 Thanks. PR filed: https://github.com/xbmc/xbmc/pull/13963

[Guilouz]

Hi ksooo,

Is it related to this thread ?

There is an issue with $INFO[ListItem.Rating(imdb)], it return same rating as $INFO[ListItem.Rating(themoviedb)].

Tested on dialog video info window. I use The Move Database scrapper addon and 'Also add IMDd ratings' is enable in settings.

$INFO[ListItem.RatingAndVotes(imdb)] and $INFO[ListItem.RatingAndVotes(themoviedb)] are working correctly.


In Red wrong ratings with ListItem.Rating(foo) and In yellow good ratings with ListItem.RatingAndVotes(foo)

 I don't think this is related to this thread.

EDIT: On second thought, it could actually be. Give me some more time, please.  

@Guilouz could you give this test build a try and report back? => http://mirrors.xbmc.org/test-builds/wind...ng-x86.exe 

 I don't use Windows build but Angelinas confirmed it's fixed. Thanks.

[sualfred]

Side question: Does this fix also make the multiple ratings outside of the info dialog available and working?

[Angelinas]

Nop ...only working in dialog.Ksooo just fixed to work like before his changes Gui.

[sualfred]

K, damnit. It's pretty much useless for me without having it available in dynamic containers or library views.

[Gade]

Thanks for the great work on these commits.


Before this commit it was possible comparing one skin string to another using

Code:

Skin.String(string1,string2)

Now you have to use

Code:

String.IsEqual(Skin.String(string1),string2)

I can see a lot of skins rely on the first example.


https://kodi.wiki/view/List_of_boolean_conditions#Skin

[Angelinas]

I think you wrong with that boolean condition

Code:

Skin.String(string1,string2)

This boolean condition working OK

I try your skin and its realy bugy with leia.But this condition was not ganerate this isue.
Main isue is this, this not working.When string is empty your condition is "false"

Code:

Skin.String(string1,)

[Gade]

@Angelinas, you're right that Skin.String(string1,string2) is working.

Using String.IsEmpty(Skin.String(string1)) is much better code practice.
The other bool was used in Rapier from long before I took it over, and I have just been using it since.
Replacing it with String.IsEmpty(Skin.String(string1)) solved all the isues not working.

[ksooo]

Thanks for the great work on these commits.


Before this commit it was possible comparing one skin string to another using

Code:

Skin.String(string1,string2)

Now you have to use

Code:

String.IsEqual(Skin.String(string1),string2)

I can see a lot of skins rely on the first example.


https://kodi.wiki/view/List_of_boolean_conditions#Skin 

Is it only not working if string2 is empty? Does it work if string 2 is not empty?

EDIT: Just saw that @Angelinas already confirmed my assumption.

[Gade]

Yeah, it seems that some old bools from before I took over Rapier now is not working anymore after PR13754:
 

Code:

Skin.String(string,)

I haven't given the bools much thought as they worked fine before this commit, and have just continued using them over the years.

But they're not very logic and using

Code:

String.IsEmpty(Skin.String(string))

makes much more sense code wise.

After replacing the bools everything works perfectly again.
Thank the higher powers for search/replace!

Thanks!

[ksooo]

Yeah, it seems that some old bools from before I took over Rapier now is not working anymore after PR13754:
 

Code:

Skin.String(string,)

I haven't given the bools much thought as they worked fine before this commit, and have just continued using them over the years.

But they're not very logic and using

Code:

String.IsEmpty(Skin.String(string))

makes much more sense code wise.

After replacing the bools everything works perfectly again.
Thank the higher powers for search/replace!

Thanks! 

 Fix is underway: https://github.com/xbmc/xbmc/pull/13970

[Gade]

Yeah, it seems that some old bools from before I took over Rapier now is not working anymore after PR13754:
 

Code:

Skin.String(string,)

I haven't given the bools much thought as they worked fine before this commit, and have just continued using them over the years.

But they're not very logic and using

Code:

String.IsEmpty(Skin.String(string))

makes much more sense code wise.

After replacing the bools everything works perfectly again.
Thank the higher powers for search/replace!

Thanks!  

 Fix is underway: https://github.com/xbmc/xbmc/pull/13970 

Great, thanks a lot!

[Angelinas]

 Fix is underway: https://github.com/xbmc/xbmc/pull/13970 

I have reported that skin with this changes now broke, All AeonMQ skin and mode (Maybe and other skin).
User use this version KodiSetup-20180603-dba439f5-master-x64.exe
 I can't try to see what is broken, I need version for test Win x86.Can you put test version with your changes in
http://mirrors.kodi.tv/test-builds/windows/win32/

tnx...can you chek too https://github.com/xbmc/xbmc/pull/13970

[Aenima99x]

 Fix is underway: https://github.com/xbmc/xbmc/pull/13970 

I have reported that skin with this changes now broke, All AeonMQ skin and mode (Maybe and other skin).
User use this version KodiSetup-20180603-dba439f5-master-x64.exe
 I can't try to see what is broken, I need version for test Win x86.Can you put test version with your changes in
http://mirrors.kodi.tv/test-builds/windows/win32/

tnx...can you chek too https://github.com/xbmc/xbmc/pull/13970 

 I can also confirm that Titan Leia Beta is now broke with theses changes as well using Milhouse build #0602  (LibreELEC-Generic.x86_64-9.0-Milhouse-20180602222909-230602-g330aad4)

[ksooo]

 Fix is underway: https://github.com/xbmc/xbmc/pull/13970 

I have reported that skin with this changes now broke, All AeonMQ skin and mode (Maybe and other skin).
User use this version KodiSetup-20180603-dba439f5-master-x64.exe
 I can't try to see what is broken, I need version for test Win x86.Can you put test version with your changes in
http://mirrors.kodi.tv/test-builds/windows/win32/

tnx...can you chek too https://github.com/xbmc/xbmc/pull/13970 

 I can also confirm that Titan Leia Beta is now broke with theses changes as well using Milhouse build #0602  (LibreELEC-Generic.x86_64-9.0-Milhouse-20180602222909-230602-g330aad4)

Could you please try to be more specific. Otherwise I have no chance to analyse/fix the problem.

What exactly broke, which labels/conditions do not work anymore?

The milhouse build you mentioned does not even contain the fix for skin.string condition! It was first introduced with milhouse build 603...