2018-08-29, 23:28
2018-09-13, 03:33
Another one to check out:
In the music window when navigating to music library - music videos - nodes when titles (mv items) displayed, prior to PR13754 ListItem.DBType was set to "musicvideo" for music video items but now ListItem.DBType is empty. However, it does correctly show "musicvideo" for mixed playlists.
Update: ListItem.DBType works correctly in the videos window.
scott s.
.
In the music window when navigating to music library - music videos - nodes when titles (mv items) displayed, prior to PR13754 ListItem.DBType was set to "musicvideo" for music video items but now ListItem.DBType is empty. However, it does correctly show "musicvideo" for mixed playlists.
Update: ListItem.DBType works correctly in the videos window.
scott s.
.
2018-09-13, 12:04
I found what causes the problem and will come up with a fix soon.
2018-09-13, 22:41
@scott967 could you please try this testbuild to check whether listitem.dbtype now works for music videos? => http://mirrors.kodi.tv/test-builds/windo...pe-x64.exe
It would be great if you could also do some deeper regression tests as well as I needed to change some important bits and pieces for the fix and want to make sure there are no bad side effects.
It would be great if you could also do some deeper regression tests as well as I needed to change some important bits and pieces for the fix and want to make sure there are no bad side effects.
2018-09-14, 03:23
Got your build, and looking at your branch commit on github. Give me a day to do some regression testing unless I see something sooner.
scott s.
.
scott s.
.
2018-09-14, 12:31
@ksooo
ListItem.Path is incorrectly filled. It was working before this PR. Tested on the nightly of today.
ListItem.Path example
Currently (wrong): plugin://?item_id=481612aecc0d9979ff94e3775c579d3d&mode=PLAY&session_id=1536916951.69
Should be: plugin://plugin.video.embycon/
It applies to all plugin based content/items.
ListItem.Path is incorrectly filled. It was working before this PR. Tested on the nightly of today.
ListItem.Path example
Currently (wrong): plugin://?item_id=481612aecc0d9979ff94e3775c579d3d&mode=PLAY&session_id=1536916951.69
Should be: plugin://plugin.video.embycon/
It applies to all plugin based content/items.
2018-09-14, 16:45
@ksooo
Video. But that doesn't matter. All listitems - if folder, video, audio, program, etc - in no matter what kind of media window or widget is returning the listitem.path without the plugin id.
Video. But that doesn't matter. All listitems - if folder, video, audio, program, etc - in no matter what kind of media window or widget is returning the listitem.path without the plugin id.
2018-09-14, 16:53
This is really very strange. Do you have the chance to test with the Sept. 11 nightly?
2018-09-14, 16:58
NVM, no need to test Sep. 11 nightly. You said ist works with Sept 14 nightly, right?
2018-09-14, 17:03
@ksooo
It worked with my test setup of before this PR has been merged. http://ftp.igh.cnrs.fr/pub/xbmc/xbmc/nig...er-x64.exe
I'll give Sep. 11 a quick try. Gimme a sec.
It worked with my test setup of before this PR has been merged. http://ftp.igh.cnrs.fr/pub/xbmc/xbmc/nig...er-x64.exe
I'll give Sep. 11 a quick try. Gimme a sec.
2018-09-14, 17:05
@ksooo
You are right. With https://mirrors.kodi.tv/nightlies/window...er-x64.exe everything is fine.
You are right. With https://mirrors.kodi.tv/nightlies/window...er-x64.exe everything is fine.
2018-09-14, 17:10
It also works with the nightly of Sep 12. But the latest two are having the problem.
It looks like ListItem.Path is returning now the ListItem.Filenameandpath but without the addon id. Before Sep 13 it was just the addon id without arguments.
It looks like ListItem.Path is returning now the ListItem.Filenameandpath but without the addon id. Before Sep 13 it was just the addon id without arguments.
2018-09-14, 17:11
Wait, are we on the same page? I understood that you gave my testbuild for the listitem.dbtype a test and that this testbuild kills listitem.path?
Now I understand that latest nightly build is broken, unrelated to my testbuild?
Now I understand that latest nightly build is broken, unrelated to my testbuild?
2018-09-14, 17:19
Yep, https://github.com/xbmc/xbmc/pull/14409 introduced the regression. I'm out. Not related to my test build.
