•   
  • 1
  • 9
  • 10
  • 11
  • 12
  • 13(current)
Important -  Skinners: Please test PR13754
Yep, accused you too early Smile Sorry. But thanks for taking care and making @garbear aware of it.
Reply
(2018-09-13, 22:41)ksooo Wrote: @scott967 could you please try this testbuild to check whether listitem.dbtype now works for music videos? => http://mirrors.kodi.tv/test-builds/windo...pe-x64.exe

It would be great if you could also do some deeper regression tests as well as I needed to change some important bits and pieces for the fix and want to make sure there are no bad side effects.
 Did some testing.  Good news is ListItem.DBType shows musicvideo correctly now in the music / musicplaylist windows and videos windows unaffected.

But I have a (sort-of) regression.  This is for music m3u playlists containing songs and / or musicvideos.  Before PR13754, ListItem.DBType was null for either songs or musicvideos in both music and musicplaylist windows.  With the test build we actually have this behavior restored.  With original PR13754, ListItem.DBType was set as songs for both songs and musicvideos.  So in some sense ListItem.DBType was improved by PR13754 (for songs) though in error for musicvideos.

In all three builds (Pre-PR13754, Post-PR13754 and this test build) Container.content infolabel is "songs" for all music m3u playlists.

I'm not sure how relevant m3u playlists containing music videos are, just reporting my test results.

From a skinner perspective, knowing the correct DBType for a listitem is valuable as the information available to display to user is different for songs compared to music videos.

scott s.
.
maintainer of skin  Aeon MQ5 mods for post-Gotham Kodi releases:
Krypton
Leia
Reply
(2018-09-15, 04:18)scott967 Wrote:
(2018-09-13, 22:41)ksooo Wrote: @scott967 could you please try this testbuild to check whether listitem.dbtype now works for music videos? => http://mirrors.kodi.tv/test-builds/windo...pe-x64.exe

It would be great if you could also do some deeper regression tests as well as I needed to change some important bits and pieces for the fix and want to make sure there are no bad side effects.
 Did some testing.  Good news is ListItem.DBType shows musicvideo correctly now in the music / musicplaylist windows and videos windows unaffected.

But I have a (sort-of) regression.  This is for music m3u playlists containing songs and / or musicvideos.  Before PR13754, ListItem.DBType was null for either songs or musicvideos in both music and musicplaylist windows.  With the test build we actually have this behavior restored.  With original PR13754, ListItem.DBType was set as songs for both songs and musicvideos.  So in some sense ListItem.DBType was improved by PR13754 (for songs) though in error for musicvideos.

In all three builds (Pre-PR13754, Post-PR13754 and this test build) Container.content infolabel is "songs" for all music m3u playlists.

I'm not sure how relevant m3u playlists containing music videos are, just reporting my test results.

From a skinner perspective, knowing the correct DBType for a listitem is valuable as the information available to display to user is different for songs compared to music videos.

scott s.
Thanks for testing. If pre-PR13754 behavior is restored, I'm done. Fixing other bugs is not on my list. This should be done by the devs responsible for m3u playlists in this case as I cannot judge on what is correct.
Reply
(2018-09-15, 08:52)ksooo Wrote: Thanks for testing. If pre-PR13754 behavior is restored, I'm done. Fixing other bugs is not on my list. This should be done by the devs responsible for m3u playlists in this case as I cannot judge on what is correct. 

Fair enough. Don't see any problem with that.

scott s.
.
maintainer of skin  Aeon MQ5 mods for post-Gotham Kodi releases:
Krypton
Leia
Reply
  •   
  • 1
  • 9
  • 10
  • 11
  • 12
  • 13(current)
 
Thread Rating:
  • 0 Vote(s) - 0 Average



Logout Mark Read Team Forum Stats Members Help
Skinners: Please test PR1375400