2018-09-14, 17:25
Yep, accused you too early Sorry. But thanks for taking care and making @garbear aware of it.
(2018-09-13, 22:41)ksooo Wrote: @scott967 could you please try this testbuild to check whether listitem.dbtype now works for music videos? => http://mirrors.kodi.tv/test-builds/windo...pe-x64.exeDid some testing. Good news is ListItem.DBType shows musicvideo correctly now in the music / musicplaylist windows and videos windows unaffected.
It would be great if you could also do some deeper regression tests as well as I needed to change some important bits and pieces for the fix and want to make sure there are no bad side effects.
(2018-09-15, 04:18)scott967 Wrote:Thanks for testing. If pre-PR13754 behavior is restored, I'm done. Fixing other bugs is not on my list. This should be done by the devs responsible for m3u playlists in this case as I cannot judge on what is correct.(2018-09-13, 22:41)ksooo Wrote: @scott967 could you please try this testbuild to check whether listitem.dbtype now works for music videos? => http://mirrors.kodi.tv/test-builds/windo...pe-x64.exeDid some testing. Good news is ListItem.DBType shows musicvideo correctly now in the music / musicplaylist windows and videos windows unaffected.
It would be great if you could also do some deeper regression tests as well as I needed to change some important bits and pieces for the fix and want to make sure there are no bad side effects.
But I have a (sort-of) regression. This is for music m3u playlists containing songs and / or musicvideos. Before PR13754, ListItem.DBType was null for either songs or musicvideos in both music and musicplaylist windows. With the test build we actually have this behavior restored. With original PR13754, ListItem.DBType was set as songs for both songs and musicvideos. So in some sense ListItem.DBType was improved by PR13754 (for songs) though in error for musicvideos.
In all three builds (Pre-PR13754, Post-PR13754 and this test build) Container.content infolabel is "songs" for all music m3u playlists.
I'm not sure how relevant m3u playlists containing music videos are, just reporting my test results.
From a skinner perspective, knowing the correct DBType for a listitem is valuable as the information available to display to user is different for songs compared to music videos.
scott s.
.
(2018-09-15, 08:52)ksooo Wrote: Thanks for testing. If pre-PR13754 behavior is restored, I'm done. Fixing other bugs is not on my list. This should be done by the devs responsible for m3u playlists in this case as I cannot judge on what is correct.
(2018-10-04, 12:49)bkury Wrote: Fair enough but the "new behavior" doesn't solve the problem that the correct path (favourites.xml) isn't available via infolabel. Honestly, I don't care if I get this information via ListItem.Path/FolderPath or a new ListItem.Property(path). The point is that this information should be available for skins (like it was in krypton), so that we can get rid of script.favourites and use the built-in favourites feature of KODI.
Anyway, I don't want to hijack this thread if you think that it's not related to this PR but can we please get this fixed? Adding a new ListItem.Property(path) would take 5 mins of coding ...
Thanks!
(2018-10-17, 03:57)scott967 Wrote: I think I have another issue.
VideoPlayer.Title
When a video is played from file (not in library) prior to this PR the filename was returned in $INFO[Videoplayer.Title]. Now the infolabel is empty.
scott s.
.
(2018-10-17, 07:05)ksooo Wrote:(2018-10-17, 03:57)scott967 Wrote: I think I have another issue.
VideoPlayer.Title
When a video is played from file (not in library) prior to this PR the filename was returned in $INFO[Videoplayer.Title]. Now the infolabel is empty.
Are you using latest Kodi master? IIRC, there was an issue with this which I fixed recently.
<control type="image">
<visible>String.IsEqual(Container(9000).ListItem.Property(submenuVisibility),movies)</visible>
</control>
<control type="list" id="8000">
<control
<visible>String.IsEqual(Container(9000).ListItem.Property(submenuVisibility),movies)</visible>
</control>
</control>
<param name="widget_header" value=$INFO[Container(9000).ListItem.Property(widgetType)]/>