(2020-04-23, 20:27)RayDawGGG Wrote: (2020-04-22, 17:25)chrisism Wrote: (2020-04-22, 02:54)Fuchs2468 Wrote: I have to say your clip looks good.
Since I know that you take care of the game support for this skin, please take a look at this error. The error is always there, i have no game launcher installed. I have already searched but unfortunately not found the error.
Code:
2020-04-22 00:38:20.890 T:5696 ERROR: Misplaced +
2020-04-22 00:38:20.890 T:5696 ERROR: Error parsing boolean expression [string.contains(container.folderpath,plugin://plugin.program.ael) | string.contains(container.folderpath,plugin://plugin.program.advanced.launcher) | string.contains(container.folderpath,plugin://plugin.program.advanced.emulator.launcher)] + + skin.string(game.thumbshape.ps1)
I'll check it out. I was actually busy simplifying these expressions.
@chrisism
Great work! by your response I see your already aware of the redundancy. Out of curiosity from this error, are there multiple names for this plugin? or does he have multiple versions of this plugin installed? It seems to be looking for ps1 assets and can't access them because of the error? Without having a launcher installed why would it look for assets? Are the category xml paths correct? Many questions that with living your life and coding, more than likely doesn't have the time to answer.AEL looks great inside this skin! My only gripe is the trailer and boxart widgets .The gameplay videos play automatically.. for aesthetic purposes the other art should be accessible via a info view versus widgets IMO.
Well I was actually looking at the double + signs which might cause errors and warnings in the logs, but don't interupt the actual workings of kodi itself. But I was doing some tweaking a little while back on the initial setup and thought up a new approach of determening the correct box sizes where this expression is used for.
The problem is that Kodi does not support custom settings per URI path (a specific view page or list you see, so in AEL case a collection of Nintendo games and a collection of Sega games have two different URIs) only per view. So that means if you enable "show trailers" in the Netflix poster view for Movies, it will also be applied to Netflix poster view for games. AEL game wise this means that if I make it possible in the skin to switch for a specific view your box size (NES games have poster size and SNES has wide box sizes) you can only set it to 1 size. The only workaround is to either create a different view per box size (NetFlix Poster, NetFlix wide, Netflix banner, Netflix blurary, Netflix slimbox etc) which is a lot of work and not really maintainable (Don't think @
mardukL would like it if I just add 20 new views to maintain) or the other way is looking at variables produced by the source/list collection, like is it the Movies db, is it TV shows db, is it programs. The last solutions works good enough for approaching movies and tv shows differently, but with AEL everything is of type 'program'. So we need another thing to check for that.
So bringing it all back to the initial question, I added a lot of expressions to check the following things:
- Which game program is being used (Retroplayer, AEL, Advanced Launcher AL)
- What kind of platform is being shown (NES, SNES, Playstation etc.)
With that info I can decide what kind of box view to apply. Now one catch is that I am builidng and using the latest unstable with AEL and Wintermute who created the plugin switched the plugin internal name to simplify folder structure etc. So the path name went from plugin.program.advanced.emulator.launcher to plugin.program.ael and I wanted to support backwards compatibility. Next to that there is also the old Advanced Launcher that might be used which is the original addon for launching games like more than a decade ago in the early days of XBMC. So a lot of checks to support all versions of game launching programs and different versions of AEL, my personal favorite.
My latest tweakings were injecting window properties to the skin from AEL with the standard box size so that you can easily switch box size changing it in AEL settings instead of doing it in the skin, because that was what I did before and results in adding a separate setting for each game platform and box size in the skin. Next to that I did actually make a double auto-show trailer setting, one for video and one for gaming specific. Just because I like to autoplay with games, but not for my movies and as said before, this is currently not possible in Kodi.
Now the thing that would solve all of this easily and would open up so many more oppertunities when working with skins for Kodi, is if Kodi would make it possible to save/storing a skin setting on URI/path level instead of global view level. For example then you can switch auto-trailers on in the "latest added movies" list but switch it off when opening the "all" list for movies.
Talking about info view, @
mardukL the new info view with shows is looking awesome. Still shows some defects with me but awesome view type. I will see if I can adapt it for games too. Also @
RayDawGGG or others, please help out or come up with ideas or additions for the games part. I am not the best in skinning myself, the whole reason why I hijacked Titan M O D
, having a good base to adapt.