[Kodi Leia] song genres field not supplied
#1
Hi,
in Kodi Leia, there is a change described within this thread: https://forum.kodi.tv/showthread.php?tid=324598
In short:

GetAlbums() and GetAlbumDetails()
The "genre" and "genreid" array values previously returned were not guarenteed to match, to resolve this album genre handling has been brought inline with artist genre handling. The "genreid" field has been removed. The "genre" field values are album genres - these may match that of the songs on the album, or can be replaced via scraping with entirely different strings that are not codified with IDs. A new field "songgenres", an array of {title, id} pairs of matching song genre strings and id, has been added. This returns the union of song genres all the songs on the album.


I just adapted my app to request the "songgenres" property for "AudioLibrary.GetAlbums".
"songgenres" is properly accepted when I do the JSON call (and "genreid" is not accepted anymore), but the resulting array does not contain any "songgenres" field. What could be wrong?
Using Kodi 18.0-ALPHA1 Git:20180304-89a53e418e

Anybody has used this property successfully?

I posted this question in the pull request, but there hasn't been any reply: https://github.com/xbmc/xbmc/pull/13051

Thanks,
Markus
Kodi Music Remote for iOS, the remote control for music lovers - http://kodimusicremote.com
Reply
#2
(2018-05-25, 16:47)markusloffler Wrote: I posted this question in the pull request, but there hasn't been any reply: https://github.com/xbmc/xbmc/pull/13051
As you have discovered adding comments to a PR that was merged 6 months before is not going to get any attention.
 
(2018-05-25, 16:47)markusloffler Wrote: I just adapted my app to request the "songgenres" property for "AudioLibrary.GetAlbums".
"songgenres" is properly accepted when I do the JSON call (and "genreid" is not accepted anymore), but the resulting array does not contain any "songgenres" field. What could be wrong?
Using Kodi 18.0-ALPHA1 Git:20180304-89a53e418e
Just checked and a bug has crept in which I will fix. For future reference Markus, if you had turned on debugging you would have seen error messages that would have made the issue more obvious.

I'm actually looking at speeding up JSON music data access so I may include the fix in that rather than a separate PR. Either way I will post here when there is a build for you to test.
Reply
#3
Fix PR raised PR13938, which will be in tomorrows nightly. Wish all issues were that trivial.
Reply
#4
Misplaced comma, damn Wink

Thanks for fixing this fast!
Kodi Music Remote for iOS, the remote control for music lovers - http://kodimusicremote.com
Reply
#5
Tested ok with the latest nighly Smile
Kodi Music Remote for iOS, the remote control for music lovers - http://kodimusicremote.com
Reply

Logout Mark Read Team Forum Stats Members Help
[Kodi Leia] song genres field not supplied0