"Visualisation.Locked" doesnt return "true" if visualisation is Locked.
#1
if a visualisation preset is locked (i.e. via Button id="501" in MusicOSD)  "Visualisation.Locked" doesnt return "true".

testet with Milkdrop 1 & 2 on Windows.
Reply
#2
(2018-09-30, 12:44)Rantanplan-1 Wrote: if a visualisation preset is locked (i.e. via Button id="501" in MusicOSD)  "Visualisation.Locked" doesnt return "true".

testet with Milkdrop 1 & 2 on Windows.
 You found a bug and I will fix it. Thanks for reporting this.
Reply
#3
14503 (PR) should fix this.
Reply
#4
Thnks !
Reply
#5
(2018-10-02, 07:36)Rantanplan-1 Wrote: Thnks !


Have you runtime tested the fix? There is a guy on github stating it's not fixed but I'm not sure he understood what this fix is about. Can you confirm the fix working?
Reply
#6
Will test this evening

(latest nightly i guess)
Reply
#7
(2018-10-02, 08:42)Rantanplan-1 Wrote: Will test this evening

(latest nightly i guess)


Thanks, yep, latest nightly.
Reply
#8
So, did give it a quick testrun and it works 50% Wink

Works for "Milkdrop"
bot fails in "Milkdropp2"

it looks like i can still lock and unlock Milkdrop2 preset, but still dont get a "true" from "Visualisation.Locked".

in Milkdrop its working.
Reply
#9
(2018-10-02, 09:35)Rantanplan-1 Wrote: So, did give it a quick testrun and it works 50%

Works for "Milkdrop"
bot fails in "Milkdropp2"

it looks like i can still lock and unlock Milkdrop2 preset, but still dont get a "true" from "Visualisation.Locked".

in Milkdrop its working.


Okay, thanks for testing. Then it seems that my fix was just one piece of the puzzle and the milkdrop2 add-on needs a fix, too.

EDIT: fixing the add-on is not my job, thus I'm out for now.
Reply
#10
o.k. thnks

so guess gonna ask in the visualisation subforum as soon as i finde some time.
Reply
#11
@Rantanplan-1 there's a thread about the subject in the vis dev forum: 2779152 (post)

@afedchin in case you have some spare time can you take a look if something need to be adjusted on the addon side?
Do not PM or e-mail Team-Kodi members directly asking for support.
Always read the Forum rules, Kodi online-manual, FAQ, Help and Search the forum before posting.
Reply
#12
fix submitted (untested, but trivial); https://github.com/afedchin/visualizatio...p2/pull/10
Reply
#13
(2018-10-02, 11:38)spiff Wrote: fix submitted (untested, but trivial); https://github.com/afedchin/visualizatio...p2/pull/10

thnx!

this fixed it. (tested with beta3)

---

only "issue" which is left over, is that as soon as i leave the Musicvisualisation Window, it isnt locked anymore. But guess thats by design, as then an other control thakes over to display the visualisation.
Reply
 
Thread Rating:
  • 0 Vote(s) - 0 Average



Logout Mark Read Team Forum Stats Members Help
"Visualisation.Locked" doesnt return "true" if visualisation is Locked.00