Bug -  Some (Skinning related) Kodi Bugs - RC1
#1
1. ListItem.Label2 is empty in DialogPVRChannelsOSD.xml -> ListItem.Label2 did show the same as ListItem.Title in Krypton withing DialogPVRChannelsOSD -> Now its Empty.

2. ListItem.NextDuration is Empty (MyPVR Channels) -> in Krypton it did show the Duration of the next EPG Event (within MyPVRChannels.xml)

3. String.IsEqual(Container(200).ListItemAbsolute(0).Label,ListItem.Label) doesnt work anymore

this did work prior PR15754 
(tested with "KodiSetup-20180408-ff02b71b-master-x64" -> where it works.)

Krypton / Leia before PR15754:
Image

Leia:
Image

@ksooo  for thows maybe.


EDIT:
almost forgot this one:

4. Action(ChannelUP) and Action(ChannelDown) dont work if a PVR-Radio Stream is playing (all fine when playing LiveTV)

looks like channel-UP / -Down also doesnt work by using a Remote, so may not Skinning related.

(i can open a separate Tread or a Ticket if needed)

reg.


EDIT2:
Another one

5. Some Lables dont show up if "Autologin" (Profiles) is disabled, and one Loggin via Loginscreen.

So if one Login via "LoginScreen.xml" instead of Autologin, several Lable doesnt show up. the only thing which help is a "ReloadSkin" or switch to another Skin.

in Estuary it looks like this when entering the Settings after Login:
Image

in the Skin im working on, its worse, as i have also some missing lables in the Homescreen (not mainmenu related).
Reply
#2
(2018-11-23, 06:22)Rantanplan-1 Wrote: 4. Action(ChannelUP) and Action(ChannelDown) dont work if a PVR-Radio Stream is playing (all fine when playing LiveTV)

looks like channel-UP / -Down also doesnt work by using a Remote, so may not Skinning related.
Cannot reproduce. Tell me whether it works with stock Kodi, stock keymaps and stock Estuary, please.
Reply
#3
(2018-11-23, 06:22)Rantanplan-1 Wrote: 2. ListItem.NextDuration is Empty (MyPVR Channels) -> in Krypton it did show the Duration of the next EPG Event (within MyPVRChannels.xml)
There is (and was) no ListItem.NextDuration, only VideoPlayer.NextDuration. Thus, I doubt that it worked in Krypton.

However, for Leia, all EPG stuff was removed from Player/MusicPlayer/VideoPlayer GUI labels/ints/bools. This effects several other GUI labels/ints/bools. VideoPlayer.NextDuration will not return any more any EPG related information.

Seems, as there is no ListItem.NextDuration, we have no replacement for VideoPlayer.NextDuration. Would it help if I add ListItem.NextDuration?

EDIT: EPG support was not (yet) removed from VideoPlayer.Next* labels/bools/ints. So, VideoPlayer.NextDuration should still work for EPG. Hmm.
Reply
#4
(2018-11-24, 13:27)ksooo Wrote:
(2018-11-23, 06:22)Rantanplan-1 Wrote: 2. ListItem.NextDuration is Empty (MyPVR Channels) -> in Krypton it did show the Duration of the next EPG Event (within MyPVRChannels.xml)
There is (and was) no ListItem.NextDuration, only VideoPlayer.NextDuration. Thus, I doubt that it worked in Krypton.

However, for Leia, all EPG stuff was removed from Player/MusicPlayer/VideoPlayer GUI labels/ints/bools. This effects several other GUI labels/ints/bools. VideoPlayer.NextDuration will not return any more any EPG related information.

Seems, as there is no ListItem.NextDuration, we have no replacement for VideoPlayer.NextDuration. Would it help if I add ListItem.NextDuration?

EDIT: EPG support was not (yet) removed from VideoPlayer.Next* labels/bools/ints. So, VideoPlayer.NextDuration should still work for EPG. Hmm.  
 Found the bug. Will introduce ListItem.NextDuration. If I provide a test build, could you test and report back?
Reply
#5
(2018-11-23, 06:22)Rantanplan-1 Wrote: 3. String.IsEqual(Container(200).ListItemAbsolute(0).Label,ListItem.Label) doesnt work anymore
Can you please tell me what "does not work anymore" mean? The two screenshots you posted tell me nothing, sorry. I cannot see what is not working anymore from these pictures.
Reply
#6
(2018-11-24, 13:17)ksooo Wrote: Cannot reproduce. Tell me whether it works with stock Kodi, stock keymaps and stock Estuary, please.
Yes shure, will do a complete fresh install, and report back. (tommorrow), as a beer is waiting in the Fridge. )
 
(2018-11-24, 13:51)ksooo Wrote: Found the bug. Will introduce ListItem.NextDuration. If I provide a test build, could you test and report back?
Yes, shure, will happylie test, thanks a Bunch. I knew its not on the Wiki, but did Work in Krypton.
 
(2018-11-24, 16:28)ksooo Wrote: Can you please tell me what "does not work anymore" mean? The two screenshots you posted tell me nothing, sorry. I cannot see what is not working anymore from these pictures.
I use this "Hack" (below) to determine if a ListItem is "even or odd / to show a grey underlay in the List only for "even" Listitems. The "odd" once without.


<visible>String.IsEqual(Container(200).ListItemAbsolute(0).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(2).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(4).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(6).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(8).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(10).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(12).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(14).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(16).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(18).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(20).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(22).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(24).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(26).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(28).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(30).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(32).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(34).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(36).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(38).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(40).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(42).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(44).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(46).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(48).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(50).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(52).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(54).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(56).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(58).Label,ListItem.Label) | String.IsEqual(Container(200).ListItemAbsolute(60).Label,ListItem.Label)</visible>


Here i compare, the absolute ListItem to the current (every second one) to determine if its "even" or "odd".

Now i get a "true" for every ListItem, and instead of the "grid" i get now just a grey square underneath all ListItems. (Screenshot 2).

There might be a better way to determine if a ListItem is "even" or "odd", this is just something which did work for me. (would also welcome better Solutions if there are some, nd i just didnd think of.)

EDIT:
I have still my "onlinemusic-browser" in my Skin, which mainly is a Skinned Version of the "Soundcloud" and "Mixcloud" Addon - as the Soundcloud Addon is currently broken, i may drop this Feature, so it wouldnt be that bad for me personal if this Stringcompare doesnt work anymore, -> means: as others most likely dont need this, no problem, if this wouldnt work anymore.

---
And thanks a BUNCH for ur Time!

(cant be taken for granted!)
Reply
#7
(2018-11-24, 13:17)ksooo Wrote: Cannot reproduce. Tell me whether it works with stock Kodi, stock keymaps and stock Estuary, please.

You're right

Did a complete fresh Install (portable), and added the Needed Buttons to Estuary -> And yes there is No issue! "UP / DOWN did work as expected. -S o i have to search the issue on my Side

sry. for the Hassle

regards.

EDIT:
Problem was totaly on my side, sry.
Reply
#8
(2018-11-23, 06:22)Rantanplan-1 Wrote: 5. Some Lables dont show up if "Autologin" (Profiles) is disabled, and one Loggin via Loginscreen.

So if one Login via "LoginScreen.xml" instead of Autologin, several Lable doesnt show up. the only thing which help is a "ReloadSkin" or switch to another Skin.

in Estuary it looks like this when entering the Settings after Login:
Image

in the Skin im working on, its worse, as i have also some missing lables in the Homescreen (not mainmenu related).
  

I believe this is a long-standing bug, I think connected to the general problems of the current way profiles are managed and switched.

scott s.
.
maintainer of skin  Aeon MQ5 mods for post-Gotham Kodi releases:
Krypton
Leia
Reply
#9
(2018-11-26, 19:11)Rantanplan-1 Wrote:
(2018-11-24, 13:17)ksooo Wrote: Cannot reproduce. Tell me whether it works with stock Kodi, stock keymaps and stock Estuary, please.

You're right

Did a complete fresh Install (portable), and added the Needed Buttons to Estuary -> And yes there is No issue! "UP / DOWN did work as expected. -S o i have to search the issue on my Side

sry. for the Hassle

regards.

EDIT:
Problem was totaly on my side, sry. 
I don't how you did it, but for me doesen't work in MusicVisualisation (PVR Radio - full screen).

Button with onclick comand "ChannelUp" working from home and from MyPVRChannels but from full screen only working arrow...
I try to change "PlayerControl(Next)", same resultats.

@ksooo here is code for Estuary mod, tested same like in mine mod, not working.
https://github.com/Guilouz/repository.gu...D.xml#L111
XBoxMediaCenter (Kodi Leia) 18.0 , LibreElec RasPi3 Krypton Skin AeonMQ6
Reply
#10
(2018-11-27, 21:37)Angelinas Wrote:
(2018-11-26, 19:11)Rantanplan-1 Wrote:
(2018-11-24, 13:17)ksooo Wrote: Cannot reproduce. Tell me whether it works with stock Kodi, stock keymaps and stock Estuary, please.

You're right

Did a complete fresh Install (portable), and added the Needed Buttons to Estuary -> And yes there is No issue! "UP / DOWN did work as expected. -S o i have to search the issue on my Side

sry. for the Hassle

regards.

EDIT:
Problem was totaly on my side, sry.  
I don't how you did it, but for me doesen't work in MusicVisualisation (PVR Radio - full screen).

Button with onclick comand "ChannelUp" working from home and from MyPVRChannels but from full screen only working arrow...
I try to change "PlayerControl(Next)", same resultats.

@ksooo here is code for Estuary mod, tested same like in mine mod, not working.
https://github.com/Guilouz/repository.gu...D.xml#L111 
 Sorry, no clue. As I said it is working fine on my end (vanilla kodi latest master with stock Estuary and no custom keymaps).
Reply
 
Thread Rating:
  • 0 Vote(s) - 0 Average



Logout Mark Read Team Forum Stats Members Help
Some (Skinning related) Kodi Bugs - RC100