Login at Kodi Home

threshold84 · 2018-12-09, 17:39

I noticed several "defaultt" typos in both Romanv's Kodistubs and xbmc's own code:

https://github.com/romanvm/Kodistubs/blo...i.py#L2229
https://github.com/xbmc/xbmc/search?q=de...q=defaultt

Is this deliberate?

**Martijn** · 2018-12-09, 17:59

I'm sure it's intended cause "default" is usually a reserved word hence "defaultt" is used

threshold84 · 2018-12-09, 18:11

I am certain this is going to break some older addons. Especially those which activate input dialogs with default strings.

**ronie** · 2018-12-10, 00:32

hmm.. how can something that hasn't been changed break anything?

**Roman_V_M** · 2018-12-10, 16:46

default is a reserved keyword in C/C++ since forever so it is forbidden to use for custom names.

threshold84 · 2018-12-10, 20:04

(2018-12-10, 00:32)ronie Wrote: hmm.. how can something that hasn't been changed break anything?

I thought it was changed recently because I was using Kodistubs for quite a while and the positional argument WAS "default" instead of the double t. But Kodistubs has been kept up to date thanks to an automated script by romanvm, so that's why it pulled this keyword.