Posts: 2,510
Joined: Dec 2012
Reputation:
216
2019-07-28, 17:14
(This post was last modified: 2019-07-28, 17:22 by brazen1.)
Yes, colors are washed out when playing HDR titles even though Windows HDR is engaged. Playing the same title solo using a different player without KODI involved and manually engaging Windows HDR prior looks better. SDR titles obviously look terrible with Windows HDR engaged which is what's happening. Same with using a player like DVDFab without madVR or LAV involved at all. That player handles nVidia API and looks great using an early version of it. The latest version using Windows API also looks great. Both versions control HDR on/off and produce a very good picture.
When I use madVR, LAV Filters, and an external player with an HDR title, nVidia API engages HDR. Windows HDR is not part of the equation. It remains off during playback. This is evident bringing up the madVR OSD. It clearly shows when nVidia HDR is in use or O/S HDR is in use had I chose that implementation. So, I understand this is the correct behavior. The way you describe, nVidia API triggers O/S HDR instead. I don't think this is correct.
O/S HDR is applied at title start and switched back off at title end. This is progress but triggering the wrong API considering we want nVidia API, not Windows API. Also needs to distinguish between SDR and HDR for triggering. Then color desaturation in VideoPlayer vs external player can be addressed imo.
Posts: 2,510
Joined: Dec 2012
Reputation:
216
Sure, I'll beta it. More importantly, we appreciate your efforts. Thank you.
Posts: 834
Joined: Jan 2014
Reputation:
262
Got an reply from Madshi.
Getting proper hdr is a little more tricky than I had imagined.
When setting hdr the syntax is:
SetHdrMonitorMode(true, chromacitites, max luminance, min luminance, maxFall, MaxCLL)
All this information is present in the video file metadata.
One option would be use the Lav splitter and decoder code to get this, which is wayyyy... Over my head and is what Madshi uses with MadVR.
Luckily the DXVA code already strip this data.
So I need to include the DXVA header into video player and maybe adding those will work.
Just an update.
Posts: 102
Joined: Feb 2009
Reputation:
1
rexian
Senior Member
Posts: 102
Fandangos, THANK YOU for your continuous work on Kodi HDR. I was able to spend just few minutes but wanted to share my experience -
1. Kodi 0.3 starts fine in SDR
2. When I start playing an HDR video, it switches to HDR mode. The TV detects it. Great job!
3. The video plays, but is very dark. Probably 5% of the actual brightness, barely visible
4. When I stop the video, the HDR doesn't switch off but Kodi looks plenty bright (unlike the actual video)
5. When I exit Kodi, HDR turns off
Tried with 3 separate videos and the above experience is consistent for me. Tried the same videos with the older version (Kody 17.6 w/ DS Player) and they played fine (bright). Will do more detailed testing tomorrow.
My System: Win10 1903 / GTX 1050 TI with 431.36 (color depth: 32-bit, Output: 8bpc, Output format: RGB, Dynamic range: full) / MadVR 0.92.17 / LG OLED E6
Posts: 834
Joined: Jan 2014
Reputation:
262
2019-08-07, 12:17
(This post was last modified: 2019-08-08, 00:58 by fandangos.)
Scrap all that.
Nvapi is the only way to go within windows.
Posts: 44
Joined: Jul 2019
Reputation:
1
If it's included in the DX12 API does that mean that it would potentially work with AMD cards as well?