Player.DisplayAfterSeek conditions
#1
According to the Kodi docs:  "True for the first 2.5 seconds after a seek."

Actually, it is also true if the video is paused and not seeking.  I did a forum search, and a couple users objected to this behavior and removed the visible condition for this in various skin files.

My question, is this behavior intentional?  If so maybe update the documentation.

Update:  did some code searching and see that if playback speed is != 1.0 then it is true.  But if you change tempo rather than FF or REW then it is only true for the first 2.5 seconds.

scott s.
.
Reply
#2
(2019-10-09, 18:19)scott967 Wrote: According to the Kodi docs:  "True for the first 2.5 seconds after a seek."

Actually, it is also true if the video is paused and not seeking.  I did a forum search, and a couple users objected to this behavior and removed the visible condition for this in various skin files.

My question, is this behavior intentional?  If so maybe update the documentation.

Update:  did some code searching and see that if playback speed is != 1.0 then it is true.  But if you change tempo rather than FF or REW then it is only true for the first 2.5 seconds.

scott s.
.

I have to strongly agree here... In my skin it's also used to show the OSD during video playback right after seeking. But it's also triggered after a playback is resumed. This is mostly fine, but having a setting to disable showing the OSD during pause (which users requested) is not working properly with this: the OSD wouldn't show anymore when pressing pause, but it would show up again when pressing play - as DisplayAfterSeek is returning true here.

What might be useful: DisplayAfterSeek only for seeking actions (FF/RW or skip) as well as DisplayAfterResume (paused, pressing play again)... But strictly seperate.
OSMC Skinner      |    The OSMC Skin for Kodi v20 Nexus (native 16:9, 21:9 and 4:3 skin, special cinemascope/CIH version available)      |     GitHub: https://github.com/Ch1llb0/skin.osmc
Reply
#3
I can't comment on whether it is intentional. However, personally I think that it should only be after a "seek" like it says it is. Pausing is not seeking IMHO.

Ideally there would be advancedsettings that could change the delay value individually for delay after seek and delay after pause.

For instance something like:
<displayafterpause>0.5</displayafterpause>
<displayafterseek>2.5</displayafterseek>

Would then set Player.DisplayAfterSeek to True after resuming from pause for 0.5 seconds and after seeking for 2.5 seconds. That way users would be able to adjust the delay in each scenario according to their own preferences.
Arctic Fuse - Alpha now available. Support me on Ko-fi.
Reply
#4
I just wanna bump this thread, before it gets lost.
DisplayAfterSeek should not return True if playback is paused.
Main: Lancool II Mesh  - Ryzen 9 5900x - MSI x570 Unify - Zotac RTX 3080 AMP HOLO - 32GB Trident Z Neo 3600 CL16 -  EVO 960 M.2 250GB / EVO 940 250GB / MX100 512GB /  Crucial P1 2TB / WD Blue 3D Nand 2TB 
Sound: Saxx AS30 DSP - Beyer Dynamic Custom One Pro 
TV: Nvidia Shield 2019 Pro- Adalight 114x LEDs - Sony 65XG9505 - Kodi / Emby - Yamaha RX-V683 - Heco Victa 700/101/251a + Dynavoice Magic FX-4
Server: i3 Skylake - 8GB - OMV4 - 22TB Storage
Reply
#5
(2020-02-02, 09:22)sualfred Wrote: I just wanna bump this thread, before it gets lost.
DisplayAfterSeek should not return True if playback is paused.
I think Ronie's recent PR 17312 has fixed this?

scott s.
.
Reply
#6
Yes, I've asked him if he can fix it after I've posted in this thread. Saw this morning that his change is working. Thanks for testing.
Main: Lancool II Mesh  - Ryzen 9 5900x - MSI x570 Unify - Zotac RTX 3080 AMP HOLO - 32GB Trident Z Neo 3600 CL16 -  EVO 960 M.2 250GB / EVO 940 250GB / MX100 512GB /  Crucial P1 2TB / WD Blue 3D Nand 2TB 
Sound: Saxx AS30 DSP - Beyer Dynamic Custom One Pro 
TV: Nvidia Shield 2019 Pro- Adalight 114x LEDs - Sony 65XG9505 - Kodi / Emby - Yamaha RX-V683 - Heco Victa 700/101/251a + Dynavoice Magic FX-4
Server: i3 Skylake - 8GB - OMV4 - 22TB Storage
Reply
#7
Could this very small fix be backported to Leia as well? It would help quite a lot of users that have asked me to make the seek bar not show up when unpausing on current gen Kodi setups.
OSMC Skinner      |    The OSMC Skin for Kodi v20 Nexus (native 16:9, 21:9 and 4:3 skin, special cinemascope/CIH version available)      |     GitHub: https://github.com/Ch1llb0/skin.osmc
Reply
#8
As i noticed this lately and the forum search leads me here,

as it is not fixed now, i workaround it this ways


<animation effect="fade" start="100" end="0" time="200" delay="2500" condition="!Player.Seeking + Player.Paused + Player.DisplayAfterSeek + !string.startswith(System.BuildVersion,19.)">Conditional</animation>

so i still can keep 'Player.DisplayAfterSeek' visible conditions for groups , though a backpport to leia would be great !
Skins |  Titan M O D   •   S W A N (WIP)
Reply
#9
(2022-01-23, 06:57)mardukL Wrote: a backpport to leia would be great !
Backports for Leia will never happen now we've released Matrix.
Reply

Logout Mark Read Team Forum Stats Members Help
Player.DisplayAfterSeek conditions0