20 Nov 2019 - TVDB Scraper v3.2.0 is now available which reinstates scraping. TVDB are still in the process of fixing a number of bugs so there may still be further breakages. See this post. 2901570 (post)

v18 MusicPlayer.Property(Role.xxxx) not working in Leia
#1
Hi folks,

I wanted to modify my favourite skin (Quartz) to show the Composer in FullScreen playback. When I add MusicPlayer.Propery(Role.Composer) it returns nothing. I just tested with 17.6 and it works. With 18.0 Alpha 3 and later it fails. I had it to work earlier with Leia (pre-Alpha) and there it was OK, but not anymore.

Has this InfoLabel gone away or is it a bug?

- Janne
Reply
#2
Same behavior with 19 Nightly Build
Reply
#3
(2019-10-14, 17:36)JanneT Wrote: Has this InfoLabel gone away or is it a bug?
Sounds like a bug, this should be working. I don't think a debug log will show much, so no rush there. What would help me is a simple skin mod to the player OSD to allow me to test what is happening in core code (skinning is not my thing)
Reply
#4
What I did was to modify MusicVisualization.xml and a bit down i the code replace MusiPlayer.Artist with MusicPlayer.Property(Role.Composer).

And, as I said, it used to work :-)
Reply
#5
(2019-10-15, 13:21)JanneT Wrote: What I did was to modify MusicVisualization.xml and a bit down i the code replace MusiPlayer.Artist with MusicPlayer.Property(Role.Composer).

And, as I said, it used to work :-)
This was just for testing with Estuary
Reply
#6
Thanks for reporting this @JanneT , a fix has been raised 16784 (PR) and will be backported to v18 in due course.
Reply
#7
(2019-10-15, 15:02)DaveBlake Wrote: Thanks for reporting this @JanneT , a fix has been raised 16784 (PR) and will be backported to v18 in due course.
Thanks!
Reply
#8
Just tested with Matrix nightly, and it works as expected. I also added an Icon to the FullScreen layout that shows 'HD' if the music >16bits and >44.1 kHz Sample Rate.

Dave, are BitsPerSample and SampleRate stored in the DB somewhere when the music files are scanned? Or are theyjust available at playback?

It would be nice to add the "HD" icon when browsing through the Albums or Songs. Just the way Movies are listed.

- Janne
Reply
#9
A backport to Leia branch has also been merged so fix should also be in the pre-18.5 nightlies at http://mirrors.kodi.tv/nightlies/windows/win64/Leia/
Reply
#10
(2019-10-17, 13:07)jjd-uk Wrote: A backport to Leia branch has also been merged so fix should also be in the pre-18.5 nightlies at http://mirrors.kodi.tv/nightlies/windows/win64/Leia/
I tried that but it crashed for some reason. Will test again later today
Reply
#11
18 nightly works with my modified skin!
Reply
 
Thread Rating:
  • 0 Vote(s) - 0 Average



Logout Mark Read Team Forum Stats Members Help
MusicPlayer.Property(Role.xxxx) not working in Leia00