Guest - Testers are needed for the reworked CDateTime core component. See... https://forum.kodi.tv/showthread.php?tid=378981 (September 29) x
  • 1(current)
  • 2
  • 3
  • 4
  • 5
  • 92
Release Kodi Matrix 19.0 HDR Windows API (merged)
#1
Kodi Matrix 19.0 HDR Windows API (merged in Kodi 19 alpha master)

 
Inspired on work of @fandangos, this fork offers same HDR functionality (currently more) without using proprietary Nvidia API.

Thanks to this, is compatible with Intel, Nvidia, AMD and Ryzen hardware.
 
 
KEY FEATURES
 
  • Maximum 4K image quality with passthrough of HDR10 metadata perfectly (independently verified with HDMI analyzer).
  • Perfect adjustment of the display refresh rate to match with content: 23.976 fps, 24.000 fps, etc.
  • Auto switch HDR mode and color space. Enable this feature from "Settings > Player > Use HDR display capabilities" = ON.
  • Toggle HDR keymap, default assigned to 'F11' key, to toggle HDR on/off from keyboard/remote (manual mode).
  • No need to install external programs or addons. madVR, MPC-HC, LAV filters, DSPlayer are not needed.
  • Play the SDR content correctly with the Windows HDR switch ON, although it is recommended for maximum quality to play the SDR content with the Windows HDR switch OFF.
  • On systems that do not have an HDR display, it playback HDR content using tone mapping in both DXVA and pixel shaders (HDR to SDR conversion).
  • Fixed important bugs in the tone mapping function present in the versions Kodi v18.x: very dark image or washed colors.
  • It supports the HLG (Hybrid Log-Gamma) format used for HDR in Live TV broadcasts. Compatible with the "IPTV PVR Simple client" addon but in the future more addons can be created / updated supporting it.
  • All HDR functionality has been implemented using only the standard Microsoft Windows API. It does not use pre-compiled external libraries or proprietary APIs from Intel or Nvidia. It does not use hacks that only work for a specific type of HW, therefore, it is highly compatible with most Intel, Nvidia, AMD or Ryzen HDMI 2.0 graphics cards.
  • Improved swapchain performance using some new DX12 / Windows 10 features.
  • Fixed NVIDIA only related stuttering/tearing issues. These are also common for 1080p SDR content but it's less obvious (still present in v18.x and can affect some users).

Tested on Intel NUC 8i3BEK + Denon AVX-1600H + Sony TV KD-55AG9 OLED.

and

Asus Maximus XI Hero + Nvidia GTX1650 +  Denon AVX-1600H + Sony TV KD-55AG9 OLED

Also works on AMD and Ryzen hardware.

Test results on other hardware are welcomed. Smile


RECOMMENDED SETTINGS

KODI:
Settings > System > Display:
  • Resolution 3840 x 2160 (4K)
  • Use full screen window = OFF (real full screen)
  • Delay after change refresh rate = 2 seconds
  • Use limited color range = OFF (full range)
Settings > Player:
  • Adjust display refresh rate = On start/stop
  • Render method = Auto detect
  • Allow hardware acceleration DXVA2 = ON
  • Use display HDR capabilities = ON (enable auto switch HDR mode and color space)

GRAPHICS CONTROL PANEL:
  • Refresh rate: 59 or 60 Hz  (for Windows desktop and Kodi GUI)
  • Color space: RGB 8bit   (driver auto-switch 10 or 12 bit when is output HDR10 signal)
  • Signal range:  0 - 255 / full range
  • Video settings (HW decoding):  All default or "application controlled". All contrast / color enhancements = OFF (can cause artifacts).

TV:
  • HDMI video range: Auto detection or full range / black level high
  • Color space: Auto detection
  • HDR mode: Auto detection


TROUBLESHOOTING / ALTERNATIVE SETTINGS

Some setups do not support HDR at 60Hz because one element of chain doesn't support it (usually by HW limitations).

Then should be used alternate settings:
  • Set Windows desktop refresh to 30 Hz   <= this may be the safest way
  • Set "Delay after change refresh rate" to 0 s.   <=  try these first
  • Set Full screen mode to windowed full screen
  • Set graphics control panel to YCbCr 4:2:2 or 4:2:0   <= when everything else doesn't work

Since almost all movies are at 24 fps and is only need avoid HDR 60 fps (SDR 60 fps for Kodi GUI still is possible) Set "delay after change refresh rate" to 0 s. is a better workaround (if works) because allows fast switch from SDR 60 Hz => HDR 24 Hz  without intermediate state HDR 60 Hz not allowed.


SETUPS WITH AVR

Configuration may NOT be trivial because:
  • AVRs may not support HDR passthrough on all input/output ports.
  • AVRs may not support all HDR formats (4K 60Hz RGB 8bit).
  • AVRs may require activating one o more options in the menu settings (Enhanced mode).
  • Others.

See this MARANTZ HDR PASSTHROUGH FAQ


DOWNLOAD

Since all the code is already merged in master branch, use the most current download links from v19 Beta, RC:
http://mirrors.kodi.tv/releases/windows/win64/


SOURCE

https://github.com/thexai/xbmc


CHANGE LOG

Version 3.7.2
Updated at 29-06-2020 (merged in Kodi 19 alpha master).

Updated with latest master branch commits: includes ffmpeg 4.3, estuary skin improvements, addons installation fixes and improvements.
No changes in HDR code.


Version 3.7.1
Updated at 17-06-2020 (forked from Kodi 19 alpha master).

New advancedsettings option 'disableDXVAdiscretedecoder' for some Nvidia systems who still need it.
Updated with latest master branch commits.


Version 3.7.0
Updated at 13-06-2020 (forked from Kodi 19 alpha master).

Removed "Nvidia shared textures" workaround due is not longer need on Windows 10 2004.
Some code refactored and clean-up.
Updated with latest master branch commits.


Version 3.6.5
Updated at 30-05-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits.
Includes "peripheral.joystick" addon in installer.
No changes in HDR code.


Version 3.6.4
Updated at 20-05-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits.
No changes in HDR code.


Version 3.6.3
Updated at 09-05-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits: increased various add-on API's version.
No changes in HDR code.


Version 3.6.2
Updated at 30-04-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits: fixed seek on interlaced content DXVA.
No changes in HDR code.


Version 3.6.1
Updated at 25-04-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits: increased addons API's (inputstream v2.3.0, PVR v6.4.0) and other updates.
No changes in HDR code.


Version 3.6.0
Updated at 18-04-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits: ISO BluRay is now part of master branch, libdav1d, spdlog, inputstream bump API to v2.2.0 and many other changes.
No important changes in HDR code, only some fixes in log code after spdlog merge.


Version 3.5.0
Updated at 09-04-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits: includes fix for libraries sorting by date, add-ons updates and other issues.
Re-enabled ISO BluRay support using libudfread (although it has not yet merged into master branch).
More robust DXVA code in tone mapping mode: avoids potential apply double mappings in some systems.


Version 3.4.0
Updated at 02-04-2020 (forked from Kodi 19 alpha master).

Reverted master branch commits to 18-feb to fix ISO BluRay bug, incorrect libraries sorting by date (year 1601 bug) and other issues.
Fixed bad render HDR10 sources on some non HDR capable systems using DXVA render method.
Lighter installer since it does not include binary addons (they are also downloaded from the repository).


Version 3.3.1
Updated at 28-03-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits (fix some addons related crashes).
No changes in HDR code.


Version 3.3.0
Updated at 23-03-2020 (forked from Kodi 19 alpha master).

Fixed oversaturated HLG colors.
Switch Windows HDR off on every stop when is played HDR content.
Updated with latest master branch commits.


Version 3.2.1
Updated at 14-03-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits.
No changes in HDR code.


Version 3.2.0
Updated at 06-03-2020 (forked from Kodi 19 alpha master).

On screen notification when toggle HDR with 'F11' key (manual mode).
Removed toggle HDR from power options menu and all associated code.
Improved display HDR detection/status if system has multiple displays HDR or Kodi is using a non HDR display in a system that has HDR display.
Updated with latest master branch commits.


Version 3.1.0
Updated at 28-02-2020 (forked from Kodi 19 alpha master).

Improved HDR auto-switch timings synchronization: playing not start until switch is finished.
SDR is not restored on exit if auto switch setting is not enabled.
Updated with latest master branch commits.


Version 3.0.0
Updated at 21-02-2020 (forked from Kodi 19 alpha master).

Auto switch HDR mode and color space.
Only toggles HDR in screen currently used by Kodi (if system has various HDR screens).
Changed behavior of setting "Use display HDR capabilities": now enables HDR auto switch mode.
Updated with latest master branch commits. Includes ffmpeg 4.2.2.


Version 2.2.2
Updated at 14-02-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits.
Minor improvements in HDR code.


Version 2.2.1
Updated at 07-02-2020 (forked from Kodi 19 alpha master).

In Windows 10 is used swapchain with 6 backbuffers for all content HDR / SDR / 3D.
Updated with latest master branch commits. Includes libaacs decryption fix.
Simplified code to turn HDR on/off when Kodi starts/exits.
HDR display detection code refactored.


Version 2.2.0
Updated at 04-02-2020 (forked from Kodi 19 alpha master).

'F11' keymap to toggle HDR on/off
Restores original Windows HDR config when Kodi exits
Refactor HDR display detection code
Removed unneeded code


Version 2.1.0
Updated at 02-02-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits. Includes UHD BD improvements.
Fix for 4K HDR 60 fps content (Gemini Man).
Disabled Nvidia sharing textures (stuttering fix).
SetMaximumFrameLatency to 1 again.
Discrete decoding can use D3D_FEATURE_LEVEL_12_0.


Version 2.0.0
Updated at 01-02-2020 (forked from Kodi 19 alpha master).

Improved swapchain with some DX12/Windows 10 exclusive features.
Improved NVIDIA stability keeping low latency.
Reduced video memory usage in HDR rendering (all graphics cards).


Version 1.9.2
Updated at 31-01-2020 (forked from Kodi 19 alpha master).

Definitive cure for NVIDIA stuttering/tearing issues. (thanks @bentom)
NVIDIA Control Panel 3D profile (power management) may be no longer necessary but leave it in 'Adaptive' may be a good practice.


Version 1.9.1
Updated at 28-01-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits. Fix some crashes related to Live TV / EPG.
No changes in HDR code.


Version 1.9.0
Updated at 25-01-2020 (forked from Kodi 19 alpha master).

Removed specific NVIDIA code to workaround tearing/stuttering issues. These are due to the power saving functionality in the drivers. It is solved by creating a maximum performance profile in NVIDIA control panel > 3D settings.  (more info => https://forum.kodi.tv/showthread.php?tid...pid2918948)
Removed 'autoHDR' option in advancedsettings.xml. Now is used GUI setting in Settings > Player > Use HDR display capabilities.


Version 1.8.1
Updated at 23-01-2020 (forked from Kodi 19 alpha master).

Fix NVIDIA HDR refresh rate match (tearing).
Updated with latest master branch commits.


Version 1.8.0
Updated at 18-01-2020 (forked from Kodi 19 alpha master).

Improves stability in NVIDIA HDR full screen switching.
Improves detection of HDR display in some multi-screen escenarios.


Version 1.7.5
Updated at 14-01-2020 (forked from Kodi 19 alpha master).

Updated with latest master branch commits. Fix some crashes due recent libraries updates.
No changes in HDR code.


Version 1.7.4
Updated at 10-01-2020 (forked from Kodi 19 alpha master).

New advancedsettings option 'autoHDR' to turn on display HDR when Kodi starts.


Version 1.7.3
Updated at 07-01-2020 (forked from Kodi 19 alpha master).

Rebased to latest master. Now includes libbluray 1.1.2


Version 1.7.2
Updated at 06-01-2020 (forked from Kodi 19 alpha master).

Eliminate rounding errors when handling HDR metadata.
Updated with latest master branch commits.


Version 1.7.1
Updated at 05-01-2020 (forked from Kodi 19 alpha master).

Power options menu closes dialog when toggle HDR is done.
Code cleanup.


Version 1.7.0
Updated at 04-01-2020 (forked from Kodi 19 alpha master).

Toggle display HDR on/off without restart.
Internal code improvements.
Fixed: small incorrectness DXVA HW tone mapping (clipped high luminance values).


Version 1.6.1
Updated at 31-12-2019 (forked from Kodi 19 alpha master).

Some performance improvements.
Internal code changes and refactorings.


Version 1.6.0
Updated at 27-12-2019 (forked from Kodi 19 alpha master).

Fixed: bad image when is used pixel shaders render method in HDR source to SDR render.
Several internal changes that do not affect functionality but are necessary to merge with Kodi master branch.


Version 1.5.1
Updated at 26-12-2019 (forked from Kodi 19 alpha master).

Fixed: bad image when is used pixel shaders render method in HDR mode.
Improved: prevents use tone mapping when HDR is active (regardless of settings).


Version 1.5.0
Updated at 24-12-2019 (forked from Kodi 19 alpha master).

NEW: Toggles Windows HDR On/Off from power options menu.


Version 1.4.1
Updated at 19-12-2019 (forked from Kodi 19 alpha master).

Fixed: very dark image in HDR10 to SRD conversion using DXVA HW tone mapping.


Version 1.4.0
Updated at 19-12-2019 (forked from Kodi 19 alpha master).

Added support for HLG (Hybrid Log-Gamma) and Rec.2020 for Live TV


Version 1.3.0
Updated at 14-12-2019 (forked from Kodi 19 alpha master).

Improved the detection of some HDR10 streams (The Mandalorian).
Improved handle of changes in metadata at middle of stream.


Version 1.2.0
Updated at 11-12-2019 (forked from Kodi 19 alpha master).

Fixed: Some streams 4K BT.2020 are incorrect detected as HDR resulting in bad image (live IPTV).
Various improvements.


Version 1.1.0
Updated at 08-12-2019 (forked from Kodi 19 alpha master).

New: Handle changes in static HDR metadata.
New: Python 2 & Python 3 compatible versions.   


Version 1.0.0:
Updated at 06-12-2019 (forked from Kodi 19 alpha master).

First release.
Reply
#2
@jogal 

Thanks, but where is the source code with your changes? I check and the code in your github is the same master by Kodi Team...

Do you have plans to share?

PS Thanks for sharing the code, I will check..
MediaBrazil forum Website - Youtube Channel
MQ9-1.6.0.29 - 09.15.2023 - Aeon MQ Skin Team
MarcosQui Website Donate and support us.
Reply
#3
(2019-12-06, 23:03)Wanilton Wrote: @jogal 

Thanks, but where is the source code with your changes? I check and the code in your github is the same master by Kodi Team...

Do you have plans to share?

Code is here:
https://github.com/thexai/xbmc/commits/Windows-HDR
Wink
Reply
#4
This is freaking cool Smile)

You can use the DisplayConfig exe from my fork with this and have automatic hdr.

I'll test this soon.

Edit: Would you mind if I use part of your code to fix intel on my fork?
Reply
#5
I haven't added it yet because it causes instability.

It seems that Microsoft does not want to switch from outside...

However, the SDR material is displayed well with the switch ON (but it is not ideal).
Reply
#6
(2019-12-06, 23:11)fandangos Wrote: Edit: Would you mind if I use part of your code to fix intel on my fork?

Of course you can use it. But the goal is to be integrated all into the master branch.
Reply
#7
(2019-12-06, 23:24)jogal Wrote:
(2019-12-06, 23:11)fandangos Wrote: Edit: Would you mind if I use part of your code to fix intel on my fork?

Of course you can use it. But the goal is to be integrated all into the master branch. 
Yes, I'm aware of that and I think this is the way to go forward, in my opinion. 

Still, we need to figure out a way to switch HDR on and OFF. Watching a SDR content if nothing is over 100nits it's a waste of eletrict power and causes the LEDs on TVs to die quicker. 
Also, it would be a great addition if someone with a HDFury or some sort of capture device that can handles HDR could experiment both methods, private APIs and Windows API and check if the metadata is passed correctly now. 

I've seen people debating about this and Madshi also mentioned the metadata problem with me. So if microsoft fixed it we are one step closer for a true Windows solution.

About the switching, the DisplayConfig source code is on my Git, maybe it won't crash if used within Kodi with your code.

And I have to ask, you seem to be a way better coder than I am, would you be willing to take a look at libbluray? Smile
I've tried but I can't fix it.
Reply
#8
Tested your fork with Nvidia hardware.  (in case it's not clear it works!) Smile)

Now I understand the switch, you need to turn it on, but while not playing HDR content Kodi will remain SDR and HDR will be disabled. 
It's way better than I had imagined. 

Also it might be a good idea to toggle tone mapping OFF if HDR is detected. 
I have it off by default on my Git but the code location and what needs to be changed are there. 

Also in VideoDatabase you can see that tone mapping will be set ON again in case the user changes anything like subtitles, audio languages etc. 
So this needs to be addressed too. 
I have disabled it on my git, in case you want to look into this.
Reply
#9
(2019-12-06, 23:50)fandangos Wrote:
(2019-12-06, 23:24)jogal Wrote:
(2019-12-06, 23:11)fandangos Wrote: Edit: Would you mind if I use part of your code to fix intel on my fork?

Of course you can use it. But the goal is to be integrated all into the master branch.   
Yes, I'm aware of that and I think this is the way to go forward, in my opinion. 

Still, we need to figure out a way to switch HDR on and OFF. Watching a SDR content if nothing is over 100nits it's a waste of eletrict power and causes the LEDs on TVs to die quicker. 
Also, it would be a great addition if someone with a HDFury or some sort of capture device that can handles HDR could experiment both methods, private APIs and Windows API and check if the metadata is passed correctly now. 

I've seen people debating about this and Madshi also mentioned the metadata problem with me. So if microsoft fixed it we are one step closer for a true Windows solution. 

I have no way of knowing if the metadata is passed in a strictly correct way but comparing the image with of the internal TV player (Android TV) is identical. For me now is OK.

In any case, this is far better than nothing (in the master branch). 

Logically, can always be improved from this starting point.

Your solution works well on NVIDIA hw however it cannot be included as it is in the master branch.
Reply
#10
(2019-12-07, 00:05)fandangos Wrote: Tested your fork with Nvidia hardware.  (in case it's not clear it works!) Smile)
Cool
Reply
#11
There's always DSPlayer in serious need of some love. Maybe you two could work on it together, once HDR is implemented in Windows?
For troubleshooting and bug reporting please make sure you read this first (usually it's enough to follow instructions in the second post).
Reply
#12
(2019-12-07, 00:20)ashlar Wrote: There's always DSPlayer in serious need of some love. Maybe you two could work on it together, once HDR is implemented in Windows?

This is halted for now on my end. I'm dedicating a good time to my family since I'm finally at home now. 

Still, Jogal seems like a WAY better coder than I'm. I have placed 80% of DSplayer code by hand on the correct places. 
I would enjoy working on this while learning from someone else that knows more than me.
Reply
#13
(2019-12-07, 00:28)fandangos Wrote:
(2019-12-07, 00:20)ashlar Wrote: There's always DSPlayer in serious need of some love. Maybe you two could work on it together, once HDR is implemented in Windows?

This is halted for now on my end. I'm dedicating a good time to my family since I'm finally at home now. 

Still, Jogal seems like a WAY better coder than I'm. I have placed 80% of DSplayer code by hand on the correct places. 
I would enjoy working on this while learning from someone else that knows more than me. 
Yeah, if you two could work together it would be fantastic. Also, it's worth mentioning, Team Kodi is looking for Windows developers for the main release.
For troubleshooting and bug reporting please make sure you read this first (usually it's enough to follow instructions in the second post).
Reply
#14
Hello.

Dunno if this is the right place to post my testing. But here goes, nonetheless.

I have tested it on my Omen laptop.
Intel i7-8750 with 16gb Ram
Nvidia 1060.

All drivers and windows software are up to date.

The TV (Samsung with HDR) now sucessfully detects HDR as soon as i launch Kodi. So this is a BIG improvement for me.
but
Video playback is very bad with constant shuttering.

Also, after returning from video playback, the color of the images (covers) from movies seem oversaturated.

Tested it with 3 different 4kHDR video files.

@
Reply
#15
(2019-12-07, 02:52)NVivas Wrote: Hello.

Dunno if this is the right place to post my testing. But here goes, nonetheless.

I have tested it on my Omen laptop.
Intel i7-8750 with 16gb Ram
Nvidia 1060.

All drivers and windows software are up to date.

The TV (Samsung with HDR) now sucessfully detects HDR as soon as i launch Kodi. So this is a BIG improvement for me.
but
Video playback is very bad with constant shuttering.

Also, after returning from video playback, the color of the images (covers) from movies seem oversaturated.

Tested it with 3 different 4kHDR video files.

@
Update:

After installing HEVC from the windows store:
https://go.skimresources.com/?id=19619X7...52d4fc98aa

I can now play all the files without any problem, with the TV correctly reporting HDR.

(i do have to turn it "on" the TV though as opposed to using PS4 and the TV turning it on automatically).
Reply
  • 1(current)
  • 2
  • 3
  • 4
  • 5
  • 92

Logout Mark Read Team Forum Stats Members Help
Kodi Matrix 19.0 HDR Windows API (merged)2
This forum uses Lukasz Tkacz MyBB addons.