2020-03-03, 04:38
A few years ago, I spent WEEKS (literally, weeks) customising Mimic under v15 to produce an entirely non-graphical, large text UI for a visually impaired friend, and I haven't been able to migrate this to the latest version (too many reasons to list). At some point, I'm gonna have to bite the bullet and rewrite the whole bloody thing from scratch, because there's a slow "unfixed" feature creep.
What I want to know is if this particular issue is still present in the latest version, before I waste 100+ hours customising a new UI. At the moment, this is the only "Show Stopper" I've found in retaining v15.
What is happening is that the v4.1.7 scraper cannot parse a filename containing "(2020)" into a year field, thusly:
1 DEBUG: VideoInfoScanner: No NFO file found. Using title search for 'U:\S\Standing_Up,_Falling_Down_(2020).mkv'
2 DEBUG: ADDON::CScraper::FindMovie: Searching for 'Standing Up, Falling Down (2020)' using The Movie Database scraper (path: 'C:\Users\Media Server\AppData\Roaming\Kodi\addons\metadata.themoviedb.org', content: 'movies', version: '4.1.7')
3 DEBUG: scraper: CreateSearchUrl returned <url>https://api.tmdb.org/3/search/movie?api_key=f090bb54758cabf231fb605d3e3e0468&query=Standing%20Up%2c%20Falling%20Down%20(2020)&year=&language=en</url>
4 DEBUG: CurlFile::Open(336F58E0) https://api.tmdb.org/3/search/movie?api_...anguage=en
Note line 2, where it includes "(2020)" as part of the title, as if it didn't recognise that as a year at all. This is also borne out by lines 3 & 4, where "(2020)" is part of the search term, and "year=" is blank.
Compare that to the same file after being reclassified as "(2019)":
1 DEBUG: VideoInfoScanner: No NFO file found. Using title search for 'U:\S\Standing_Up,_Falling_Down_(2019).mkv'
2 DEBUG: ADDON::CScraper::FindMovie: Searching for 'Standing Up, Falling Down' using The Movie Database scraper (path: 'C:\Users\Media Server\AppData\Roaming\Kodi\addons\metadata.themoviedb.org', content: 'movies', version: '4.1.7')
3 DEBUG: scraper: CreateSearchUrl returned <url>https://api.tmdb.org/3/search/movie?api_key=f090bb54758cabf231fb605d3e3e0468&query=Standing%20Up%2c%20Falling%20Down&year=2019&language=en</url>
4 DEBUG: CurlFile::Open(336F47A0) https://api.tmdb.org/3/search/movie?api_...anguage=en
Note that lines 2 ,3 & 4 now recognise "(2019)" as a year. What's really interesting is that the CurlFile in line 4 has replaced the underscores with spaces, which it did not do when failing with "(2020)".
Would someone please test whether this bug is still present under the new python version of TMDB (v5.1.10 I think)? Just simply place a "(2020)" suffixed file in your movie source path.
If it's gone, then I'll have to take some holidays to convert a new Kodi over to text. Fun fun fun.
BTW: Thinking it was some simple match-first-occurrence regex issue, I tried it with "(1919)", and it created a year from that (not finding a match, obviously).
What I want to know is if this particular issue is still present in the latest version, before I waste 100+ hours customising a new UI. At the moment, this is the only "Show Stopper" I've found in retaining v15.
What is happening is that the v4.1.7 scraper cannot parse a filename containing "(2020)" into a year field, thusly:
1 DEBUG: VideoInfoScanner: No NFO file found. Using title search for 'U:\S\Standing_Up,_Falling_Down_(2020).mkv'
2 DEBUG: ADDON::CScraper::FindMovie: Searching for 'Standing Up, Falling Down (2020)' using The Movie Database scraper (path: 'C:\Users\Media Server\AppData\Roaming\Kodi\addons\metadata.themoviedb.org', content: 'movies', version: '4.1.7')
3 DEBUG: scraper: CreateSearchUrl returned <url>https://api.tmdb.org/3/search/movie?api_key=f090bb54758cabf231fb605d3e3e0468&query=Standing%20Up%2c%20Falling%20Down%20(2020)&year=&language=en</url>
4 DEBUG: CurlFile::Open(336F58E0) https://api.tmdb.org/3/search/movie?api_...anguage=en
Note line 2, where it includes "(2020)" as part of the title, as if it didn't recognise that as a year at all. This is also borne out by lines 3 & 4, where "(2020)" is part of the search term, and "year=" is blank.
Compare that to the same file after being reclassified as "(2019)":
1 DEBUG: VideoInfoScanner: No NFO file found. Using title search for 'U:\S\Standing_Up,_Falling_Down_(2019).mkv'
2 DEBUG: ADDON::CScraper::FindMovie: Searching for 'Standing Up, Falling Down' using The Movie Database scraper (path: 'C:\Users\Media Server\AppData\Roaming\Kodi\addons\metadata.themoviedb.org', content: 'movies', version: '4.1.7')
3 DEBUG: scraper: CreateSearchUrl returned <url>https://api.tmdb.org/3/search/movie?api_key=f090bb54758cabf231fb605d3e3e0468&query=Standing%20Up%2c%20Falling%20Down&year=2019&language=en</url>
4 DEBUG: CurlFile::Open(336F47A0) https://api.tmdb.org/3/search/movie?api_...anguage=en
Note that lines 2 ,3 & 4 now recognise "(2019)" as a year. What's really interesting is that the CurlFile in line 4 has replaced the underscores with spaces, which it did not do when failing with "(2020)".
Would someone please test whether this bug is still present under the new python version of TMDB (v5.1.10 I think)? Just simply place a "(2020)" suffixed file in your movie source path.
If it's gone, then I'll have to take some holidays to convert a new Kodi over to text. Fun fun fun.
BTW: Thinking it was some simple match-first-occurrence regex issue, I tried it with "(1919)", and it created a year from that (not finding a match, obviously).
