v19 Kodi 19.0 Tone Mapping improvements - Beta test build (merged)
#31
Working fine on a Radeon RX570 8gb Ryzen 2600x

Thank you
Reply
#32
working great on amd 4650g apu, hable looks fantastic
Reply
#33
Hi

Works fine on GTX 1660

Cheers
Reply
#34
I must say I'm impressed with Hable tonemapping. I was not shure that 4K HDR convertion to SDR is going to worth it, but the colors are richer and details improvement from this resolution is noticeable. Setting the TV brightness and contrast so you can have nice balance between dark and light scenes is a bit tricky, but its achievable.
Thank you for this great addition!

I'm using j3355 CPU in my HTPC which is capable enough to decode 4K HEVC, but I need to manually switch render method to 'pixel shaders' or the FPS goes down to about 18 to 20 with Auto mode.
I'm also watching TV with Kodi, and with this render method there is no deinterlace method available(and some live shows still broadcast interlaced) and no high quality scalers -only bilinear.
So I want to ask @jogal and @jjd-uk is it possible to set the render method to 'pixel shaders' with Auto mode when tonemapping is used or maybe for another solution if this is not an option.
Thank you!

edit:
For anyone having the same issue, just zoom +1 the video after playing it and Kodi will switch to 'pixel shader'
Reply
#35
Hi, is there anything preventing this from working in, say, Coreelec for Odroid N2+? Isn't it just different math operations in the files in system/shaders compared to the Reinhard ones already in Leia?

edit: guy on coreelec forum says these are only implemented in d3d and opengl, not opengles which is needed for ARM. Somebody else simply said "not possible" and closed the thread so I guess that's that. I don't really understand why the same math can't be done in one interface as in another, but what do I know?
Reply
#36
(2020-12-27, 05:44)jubilex Wrote: Hi, is there anything preventing this from working in, say, Coreelec for Odroid N2+? Isn't it just different math operations in the files in system/shaders compared to the Reinhard ones already in Leia?

edit: guy on coreelec forum says these are only implemented in d3d and opengl, not opengles which is needed for ARM. Somebody else simply said "not possible" and closed the thread so I guess that's that. I don't really understand why the same math can't be done in one interface as in another, but what do I know?
if its not implemented in opengles, this means the "math" isnt recognised at all. doesnt mean it cant be done, just that its not there yet. it probably requires a lot of time to do so i think, so maybe thats the issue. maybe open a thread at opengles development to get support for it? otherwise it's going to be a challenge i'm affraid.
Kodi Matrix 19.0 HDR Windows API
Reply
#37
(2020-12-29, 21:55)Statler1978 Wrote:
(2020-12-27, 05:44)jubilex Wrote: Hi, is there anything preventing this from working in, say, Coreelec for Odroid N2+? Isn't it just different math operations in the files in system/shaders compared to the Reinhard ones already in Leia?

edit: guy on coreelec forum says these are only implemented in d3d and opengl, not opengles which is needed for ARM. Somebody else simply said "not possible" and closed the thread so I guess that's that. I don't really understand why the same math can't be done in one interface as in another, but what do I know?
if its not implemented in opengles, this means the "math" isnt recognised at all. doesnt mean it cant be done, just that its not there yet. it probably requires a lot of time to do so i think, so maybe thats the issue. maybe open a thread at opengles development to get support for it? otherwise it's going to be a challenge i'm affraid.

Thanks, I'll give that a shot. For my own curiosity, can you explain a little more? The math for these algorithms is in the Kodi system/shaders files, it doesn't appear to be calling built-in D3D or OpenGL specific tonemapping functions, it looks like it's Kodi's renderer doing the work. I still don't understand what OpenGLES is, itself, lacking that makes it impossible to do this within Kodi for OpenGLES.

From this thread itself as well as this xbmc pull request it seems like this is something managed entirely within Kodi? If it's not obvious, I'm a layman and don't really understand any of this...

edit: Fritsch answered in another thread that the hardware in the ARM devices is not up to doing this.
Reply
#38
Failure to render with Hable or ACES filmic

System is intel UHD 620 integrated graphics laptop 1080 display (also tested HDMI to SDR 1080p AVR) running windows 10 x64 2004 driver 25.20.100.6617  8 Mar 2019
test file is HDR10-Sony-Bravia-OLED-(www.demolandia.net).mp4 from here
test mediainfo video is:
Code:
Video
ID: 1
Format: HEVC
Format/Info: High Efficiency Video Coding
Format profile: Main [email protected]@High
HDR format: SMPTE ST 2086, HDR10 compatible
Codec ID: hvc1
Codec ID/Info: High Efficiency Video Coding
Duration: 1 min 23 s
Bit rate: 72.9 Mb/s
Maximum bit rate: 94.2 Mb/s
Width: 3 840 pixels
Height: 2 160 pixels
Display aspect ratio: 16:9
Frame rate mode: Constant
Frame rate: 59.940 (60000/1001) FPS
Color space: YUV
Chroma subsampling: 4:2:0 (Type 2)
Bit depth: 10 bits
Bits/(Pixel*Frame): 0.147
Stream size: 722 MiB (100%)
Color range: Limited
Color primaries: BT.2020
Transfer characteristics: PQ
Matrix coefficients: BT.2020 non-constant
Mastering display color primaries: R: x=1.000000 y=1.000000, G: x=1.000000 y=1.000000, B: x=1.000000 y=1.000000, White point: x=1.000000 y=1.000000
Mastering display luminance: min: 0.1000 cd/m2, max: 1 cd/m2
Codec configuration box: hvcC

Kodi 19 win x64 201230 nightly

Log shows playing the file and opening Video OSD then cycling through the color map options Reinhard -> off -> Hable -> ACES filmic - Reinhard

when color map is set to Hable or ACES filmic, screen is black.

other HDR files do color map in all options.

Log is here:  debug log

Thinking maybe an issue with the HDR parameters in the file?

scott s.
.
maintainer of skin  Aeon MQ5 mods for post-Gotham Kodi releases:
Matrix see: Aeon MQ5 Mod Martix release thread
Leia see: Aeon MQ5 Mod Leia release thread
Aeon MQ 5 skin and addon repo
Reply
#39
Yes this metadata are wrong. SDR videos has 100 nits (cd/m2) by definition. HDR videos 400, 600, 1000 nits or more....

This metadata tell 1 nits (of maximum) this means is 100 times darker than SDR video.....   Shocked

Code:
Mastering display luminance: min: 0.1000 cd/m2, max: 1 cd/m2

Also color primaries are wrong.
Reply
#40
Is there a guide for full setup please?
Reply
#41
Any idea how to find which option best fit the display? I think Hable looks best but it's a little dark on my projector..
Reply



Logout Mark Read Team Forum Stats Members Help
Kodi 19.0 Tone Mapping improvements - Beta test build (merged)0
This forum uses Lukasz Tkacz MyBB addons.