[Buschel]

(1) "No connection" after scrolling up. -> Confirmed, just fixed this. Again related to lates dequeuing changes.
(2) Different logo contrast. ->  You are right. This happens, if you scroll up several time. It is getting more contrast each time. Also related to dequeuing changes. Not fixed yet.
(3) Wrong status. -> Good to see you could reproduce this finally. I will have a look a this.

Edit: Cannot reproduce (3) here. Is there anything special, can you share a video?

[amasephy]

Nothing special. Every time I suspend the app and resume it goes into yellow connection status.

Doesn’t matter if I’m at the main menu screen or the remote screen. If I suspend the app and resume I get the same result. Interestingly I do need to swipe up on the main menu OR the right pane to “refresh” the connection status. As soon as I do this it turns yellow. The only difference is the right pane still labels the connection server name.

Here’s a video of it.

[Buschel]

Perfect, thanks. The difference is how you suspend and resume the app. I really switched to a different app or put the iPhone to sleep. You only attempt to do it, and then go back. Only in your case, the problem occurs, and I can reproduce it now as well. The code causing this is >9 years old.

The App ends TCP when receiving notification UIApplicationWillResignActiveNotification, which happens when just attempting to change the App like in your video. This is why the status icon becomes yellow. But TCP is only enabled again when receiving the notification UIApplicationWillEnterForegroundNotification, which is not sent without the App having really entered (not only attempted to enter) background. So, we should only switch off TCP if the App really enters background, which is signaled by UIApplicationDidEnterBackgroundNotification. 

Applying this change locally seems to work, but I need to understand possible side effects before moving on. @kambala, what are your thoughts?

[amasephy]

I can’t believe after over a year of testing it’s only now clear the subtle way to trigger it. Thanks for confirming and explaining. Hopefully your fix will put this annoying bug to rest once and for all.

[Buschel]

Well there are still more issues with the status icons. For example I remember it is possible to to switch off TCP on Kodi server and not see this reflected in all screens. 

Btw, a bigger problem with the issue you find is that the TCP connection is really switched off (the status icon becoming yellow is just right). After this happened you will not receive any notifications by Kodi anymore and the App can only perform updates via polling each second. You can easily see this when observing the volume bar and changing the volume in Kodi server for with another app instance.

[kambala]

Perfect, thanks. The difference is how you suspend and resume the app. I really switched to a different app or put the iPhone to sleep. You only attempt to do it, and then go back. Only in your case, the problem occurs, and I can reproduce it now as well. The code causing this is >9 years old.

The App ends TCP when receiving notification UIApplicationWillResignActiveNotification, which happens when just attempting to change the App like in your video. This is why the status icon becomes yellow. But TCP is only enabled again when receiving the notification UIApplicationWillEnterForegroundNotification, which is not sent without the App having really entered (not only attempted to enter) background. So, we should only switch off TCP if the App really enters background, which is signaled by UIApplicationDidEnterBackgroundNotification. 

Applying this change locally seems to work, but I need to understand possible side effects before moving on. @kambala, what are your thoughts?

current logic is obviously wrong. Either use WillResign+DidBecome or DidEnter+WillEnter. Note that only WillResign will occur if you receive an incoming call, not quite sure if a socket is allowed to work in inactive state (call may be long).

[Buschel]

Thanks. For now I changed it to use only use DidEnter+WillEnter. You think this will be ok for the App, or you expect problems because of the TCP connection?

[kambala]

Thanks. For now I changed it to use only use DidEnter+WillEnter. You think this will be ok for the App, or you expect problems because of the TCP connection?

should be good I think, afaik most app functions don't use the raw TCP connection but rather JSON-RPC over HTTP

[amasephy]

Hi Buschel,

Your fix probably will cover this but revealing the iOS notification pane by swiping down from the top of your phones screen triggers the same yellow connection status.

[Buschel]

Your fix probably will cover this but revealing the iOS notification pane by swiping down from the top of your phones screen triggers the same yellow connection status.

Yes, this is the same underlying problem and also will be fixed.