v19 Media Information from Iso Files
#46
As the current code stands, only the info from the currently playing stream is saved.  That means that if you don't turn on subs whilst playing an ISO then that info doesn't get saved.  As you rightly point out @brazen1, Kodi doesn't probe for all the subtitle/audio info when playing an ISO in the same way it does for say MKV or MP4 etc.  It might be possible to iterate over all the subs and save them but that would be a different PR.

With these changes, Kodi should do the same as Krypton did. Extending things (picking up all the subtitle languages, fixing the odd AR issues) might be possible in the future but this will need merging first as a starting point I think.  The (so far) mainly positive feedback can only help in that regard.

~~~EDIT~~~

Actually, having looked at the code, it turns out it's actually trivial to save all the audio stream and subtitle data.  Still need to play the main title, but all audio streams and all subtitles can be saved (without having to enable them).  Personally, I think it's a great improvement but I need to make sure that I haven't introduced any memory leaks or regressions.  If I can include it with the current PR and if it gets accepted then it would mean that playing the main title of an iso etc would save the same details as the background loader does for MKV's etc.
Learning Linux the hard way !!
Reply



Logout Mark Read Team Forum Stats Members Help
Media Information from Iso Files0
This forum uses Lukasz Tkacz MyBB addons.