[black_eagle]

As you can see in the image the first song as a video, but it's not been scraped, maybe the reason is the '...' at the start of the songs's title ?

I tagged up some dummy files to test that album with and even with the ellipsis at the front, it scraped correctly for me and I got the video link.  I tested it several times with no issues.  The only thing I can think of is that your song title does not contain that ellipsis, or, it is a different unicode character in your song title.  I tagged my test files with Picard and it correctly used … which is U+2026.

[manfeed]

I tagged up some dummy files to test that album with and even with the ellipsis at the front, it scraped correctly for me and I got the video link.  I tested it several times with no issues.  The only thing I can think of is that your song title does not contain that ellipsis, or, it is a different unicode character in your song title.  I tagged my test files with Picard and it correctly used … which is U+2026.

Sorry, but I'm unable to get the video link in that song no matter what I try... I also tagged it with Picard and to no avail, what's more, I noticed that the track 7 of reputation from Taylor Swift is titled So It Goes... and it's not scraped either in my end. There's no problem with all the rest, so obviously it's due to the '...' issue. Only thing I can think of it's the O.S. I'm in Windows and you must probably be using Linux, isn't it?

[black_eagle]

Yeah, I'm on Linux.  Both of those scan in fine for me.  Highlights one of the reasons I wasn't keen on a simple string comparison.

I'll have to spin up a Windows VM and do some testing.

[manfeed]

Just a question, has this feature been added to the Nexus nightlies yet?

[manfeed]

I think this could be an amazing new feature for Nexus, and it worked quite well in the tests, but @black_eagle hasn’t appeared in the forum for several months now… Is there anyone who could resume this? Thanks!

[manfeed]

Hi @enen92 I know that you've done many improvements to Kodi lately, thanks! 

Maybe you're also interested in helping with this (hopefully) new feature for Kodi. The goal is being able to play online music videos (from youtube) of the songs that the user has in his music library when browsing, I mean, I think of an album music view in the skin that shows which songs have youtube videos and allows the user to play either the song or the online video. Theaudiodb.com provides links to many youtube videos for songs, so by adapting the artist scraper to match those with the user's songs it can be possible.

As you can see in this thread this feature was already working great, only with small issues to iron out, there was even a kodi test build (which is currently unavailable) but the dev black_eagle suddenly disappeared of the forum and nothing has be done since then.

I think this could be an amazing new feature, @docwra also was helping with this, so he can explain whatever related to theaudiodb.com.

Thanks in advance!

[enen92]

@black_eagle is still around and active, I doubt there's any reason to pick up after him. Sometimes life just gets in the way
Let's wait, pretty sure he'll progress this, plus music is really his area

[scott967]

Hi @enen92 I know that you've done many improvements to Kodi lately, thanks! 

Maybe you're also interested in helping with this (hopefully) new feature for Kodi. The goal is being able to play online music videos (from youtube) of the songs that the user has in his music library when browsing, I mean, I think of an album music view in the skin that shows which songs have youtube videos and allows the user to play either the song or the online video. Theaudiodb.com provides links to many youtube videos for songs, so by adapting the artist scraper to match those with the user's songs it can be possible.

As you can see in this thread this feature was already working great, only with small issues to iron out, there was even a kodi test build (which is currently unavailable) but the dev black_eagle suddenly disappeared of the forum and nothing has be done since then.

I think this could be an amazing new feature, @docwra also was helping with this, so he can explain whatever related to theaudiodb.com.

Thanks in advance!

extendedinfo script provides a youtube search feature that more or less provides this.

scott s.
.

[manfeed]

This option would be another league, no online searchs on-the-fly that are slow. The user only has to scrape his music and there would be two new listitems: ListItem.SongVideoURL & ListItem.SongVideoThumb, ready to be used in the skin. It’s kind of Listitem.Trailer but for songs. The possibilities from a skinner standpoint would be amazing…

[black_eagle]

Erm,  So..... Really this requires a change to the audiodb to include the artist MBID in the video info so that Kodi can match the MBID's up.  If that can be done, then it's pretty easy to implement in core.  But, the info provider (theaudiodb.com) needs to provide that info back to Kodi.

[manfeed]

Erm,  So..... Really this requires a change to the audiodb to include the artist MBID in the video info so that Kodi can match the MBID's up.  If that can be done, then it's pretty easy to implement in core.  But, the info provider (theaudiodb.com) needs to provide that info back to Kodi.

Great to hear from you again!

@docwra @zag What do you think about what @black_eagle says?

[zag]

Erm,  So..... Really this requires a change to the audiodb to include the artist MBID in the video info so that Kodi can match the MBID's up.  If that can be done, then it's pretty easy to implement in core.  But, the info provider (theaudiodb.com) needs to provide that info back to Kodi.

It's been a while, but I think you mean on the mvid.php API?

If so then yes its easily added. I have done that now on the test api key.

Code:

https://theaudiodb.com/api/v1/json/2/mvid.php?i=112024

Now returns

php:
idArtist": "112024",

"idAlbum": "2115887",

"idTrack": "32793491",

"strTrack": "High for This",

"strTrackThumb": null,

"strMusicVid": "http://www.youtube.com/watch?v=JDe86ul6RmI",

"strDescriptionEN": "High for this is a song by the weeknd featuring on his album Trilogy, released in 2012.",

"strMusicBrainzArtistID": "c8b03190-306c-4120-bb0b-6f2ebfc06ea9"

[black_eagle]

Ha, so I'm revisiting this and staring at code I wrote quite a while ago and thinking "Did I really write this?...."!

Anyway, it looks like I grab all the video links for a specific artist and then later I compare a song title in the music db to a song title in the video links.  This is the bit where it all can go a bit awry.  Really what should be being compared here is the song mbids as they should be consistent regardless of language or punctuation etc etc.  So mvids need a musicbrainzTrackId that I can match on.  EG, ABBA's SOS is 'f2ada1c9-fa39-4d15-aa11-9bd798a885a9'.

In my DB this shows as follows



Even though the titles would not work as a direct string comparison, the MBID ensures that all the tracks are indeed the same track.

@zag This is what the audiodb needs to return in its mvid data so that I can match it up with the tag data from the songs.

[zag]

@black_eagle Sounds like a good evolution of code

Cool how about MBID track lookup?

Its currently only working on the test key here: 

https://theaudiodb.com/api/v1/json/2/mvi...d798a885a9

Now returns

php:


{

"mvids": [

{

"idTrack": "32822116",

"idAlbum": "2118167",

"strTrack": "S.O.S.",

"intDuration": "201426",

"strTrackThumb": null,

"strMusicVid": "https://www.youtube.com/watch?v=cvChjHcABPA",

"strDescriptionEN": null,

"strMusicBrainzArtistID": "d87e52c5-bb8d-4da8-b941-9f4928627dc8",

"strMusicBrainzAlbumID": "b69d665a-3eee-39f3-b156-58b122232304",

"strMusicBrainzID": "f2ada1c9-fa39-4d15-aa11-9bd798a885a9"

}

]

}

[black_eagle]

@zag 
The track ID needs to be returned for a call such as https://theaudiodb.com/api/v1/json/2/mvi...4928627dc8

Basically, when the scraper gets the artist info, it now gets a list of all the videos for that artist.  That bit works fine, the problem is that currently, the code to match one of the videos with a song in the database uses a straight string comparison.  That means that 'S.O.S.' does not match with 'SOS' even though we both know it's the same song.  However, the MusicBrainzTrackID does identify it as the same song.

So, if the artist search for music videos associated with that artist can return the MusicBrainzTrackID for that video/song then I can match the songs Kodi knows with the video list using that ID.  That should mean no issues across platforms etc or irregularities due to naming etc.

In a nutshell, get a list of all the videos associated with an artist from the audiodb and use the trackID to match up against the tracks scanned into Kodi.