[damagedspline]

I am the current maintainer of the notorious Kodi MVC fork (365120 (thread)) and i have decided to upgrade the libbluray to 1.3.0 for windows - starting with the MVC fork and then push this change upstream.
Looking at the latest master branch i see that @Fuzzard did it for non-windows platforms - and windows remains with 1.2.1.

In order to achieve that, i plan to compile from source during kodi build same as @Rechi WIP pull merge for other dependencies ( 16850 (PR)), because i found that it will be easier for me to patch it for MVC support and keeping it synced - currently an old patched version of libbluray (1.0.2)  is used for MVC. Now for the tricky part - i will need to use the same msys2 env that is generated by the make_mingw.bat script. Since I do not want to contaminate the ffmpeg build scripts & process i plan to invoke mintty by cmake during buildsetup.bat.

If any one has already started working on it, please let me know before i step in. 
If anyone has a better solution for cross-compiling it, please let me know.

I prefer to build the sources directly from VLC repos (https://code.videolan.org/videolan/libbluray) rather then any of its the forks (like https://github.com/ShiftMediaProject/lib...ree/master)


Update:
Done!
Commit is currently in the kodi MVC fork repository https://github.com/damagedspline/xbmc/co...f744f4f688

Kodi MVC fork build with this patch (19.3.4) is available here: https://forum.kodi.tv/showthread.php?tid=365120

[jjd-uk]

FYI Windows dependencies are done at https://github.com/xbmc/kodi-deps perhaps look at last pull request for libbluray there.

[jjd-uk]

Actually looks like it may have been done https://github.com/xbmc/kodi-deps/commit...dc8f7731aa

and https://github.com/xbmc/kodi-deps/action...1735872313

On my mobile so not able to check the Artifacts Kodi dependencies file to see if it contains the zips for updated libbluray. If there then possibly all is missing is the zips from the mirror servers.

[jjd-uk]

Yep definitely not at http://mirrors.kodi.tv/build-deps/win32/

[damagedspline]

Actually looks like it may have been done https://github.com/xbmc/kodi-deps/commit...dc8f7731aa

and https://github.com/xbmc/kodi-deps/action...1735872313

On my mobile so not able to check the Artifacts Kodi dependencies file to see if it contains the zips for updated libbluray. If there then possibly all is missing is the zips from the mirror servers.

Yep, Zips of 1.3.0 are missing on the mirror.
So what is the expected workflow?

How can i propagate the mvc patch of libbluray 1.3.0? Should i add a new external project in the cmake with version 1.3.0-mvc and once merged it should automagically appear as a zip on the mirror servers?
If that is the case it means i should branch paxxi's libbluray and link it in the kodi-deps cmakelists.txt

[jjd-uk]

I'm not 100% of your end game here? are you looking to push the MVC patches to the Kodi libbluray version?

To be honest I'm not a core dev so I'm not sure on how you should hanle the MVC patches.

I'll see if I can get some momentum back in bumping Windows 1.3.0

[damagedspline]

I'm not 100% of your end game here? are you looking to push the MVC patches to the Kodi libbluray version?

To be honest I'm not a core dev so I'm not sure on how you should hanle the MVC patches.

I'll see if I can get some momentum back in bumping Windows 1.3.0

I am referring specifically to libbluray. There is a slim chance of the kodi MVC patches to be approved in upstream kodi - most are for historical reasons. My goal is to have the MVC patched kodi built with a patched version of libbluray to allow MVC. The core of the libbluray patch is just to expose an inner struct which is crucial to detect stereoscopic 3D blurays/ISOs and then to trigger the MVC decoding in the patched kodi.
Currently i rely on the zip files to exist on the mirror servers and in order to allow the patched kodi to be built. That is why i wanted to have libbluray built from sources when kodi is being built - so i can apply the libbluray mvc patch and be able to easily patch newer libbluray releases as they come.

But now that i have seen paxxi's libbluray repository, i find it easier to integrate to it than to vlc's libbluray repository as it is now just to download the code and trigger the cmake build. So i can take the entire zip and deps repository out of the question...

Thank you

[damagedspline]

libbluray 1.3.0 & libudfread 1.1.2 updated and compiled from sources during kodi build (+patching libbluray for mvc).
Commit is is currently in the kodi MVC repository https://github.com/damagedspline/xbmc/co...f744f4f688

I will remove all MVC related stuff from the patch and create a pull request for upstream.

Kodi MVC build with this patch (19.3.4) is available here: https://forum.kodi.tv/showthread.php?tid=365120

[Fuzzard]

Before you go too far. My understanding is its not desired to build windows libs during build. This is a bit of a touchy subject internally in the team, but from what ive taken away from the many discussions, theres no intention to move to building windows libs rather than the prepackaged ones.

[damagedspline]

Before you go too far. My understanding is its not desired to build windows libs during build. This is a bit of a touchy subject internally in the team, but from what ive taken away from the many discussions, theres no intention to move to building windows libs rather than the prepackaged ones.

Thanks, you spared me a couple of hours of figgeling with pull requests. If anyone from the upstream dev team would like it, they can use my patch above as reference.

I fail to understand the difference between forcing compilation of ffmpeg which 15min of build but udfread & bluray which less than a minute of build are considered taboo... Beats me, but whatever....

[damagedspline]

FYI
I have created a pull request for Paxxi's libbluray repository with update to libbluray 1.3.1 - it does not include the MVC patch for libbluray so it is a direct merge from libluray origin repository 

This pull can be approved or not, I use it (+MVC patch) either way.

https://github.com/Paxxi/libbluray/pull/1