2023-01-17, 10:02
Hi,
I've re-written the 'visualization.goom' binary addon (from 'C') to C++17. I've submitted a pull request to 'https://github.com/xbmc/visualization.goom' in Jan 2022. I haven't had a response yet. It's a giant pull request so maybe that's why nothing has been said. Also the Jenkins check fails (some tricky error I can't debug) but the other build checks are successful.
Would I be better to try and submit this as a separate new 'Goom++' repo, something like 'https://github.com/xbmc/visualization.goom++'? If so, how is that done. I can't find the right documentation on how to submit new binary addons.
What is the best way to go here?
Thanks
I've re-written the 'visualization.goom' binary addon (from 'C') to C++17. I've submitted a pull request to 'https://github.com/xbmc/visualization.goom' in Jan 2022. I haven't had a response yet. It's a giant pull request so maybe that's why nothing has been said. Also the Jenkins check fails (some tricky error I can't debug) but the other build checks are successful.
Would I be better to try and submit this as a separate new 'Goom++' repo, something like 'https://github.com/xbmc/visualization.goom++'? If so, how is that done. I can't find the right documentation on how to submit new binary addons.
What is the best way to go here?
Thanks
